BAMresearch / bam-masterdata

57%

main: 56%

LAST BUILD ON BRANCH 154-fix-comments-checker

branch: 154-fix-comments-checker

CHANGE BRANCH

x

Reset

Sync Branches

• 154-fix-comments-checker
• 108-checker-for-individual-dsst-repos
• 11-extract-datamodel-json
• 110-add-iri-to-definitions
• 112-get-rid-off-property_typespy
• 113-fix-find_datamodel_dir-in-cli
• 116-removed-property_typespy-throws-error-in-checker-modecompare
• 118-fix-bam-namespace
• 120-hotfix-set-in-checker
• 122-fix-conditions-in-checker-cli-for-individual-datamodel-repos
• 125-raise-error-when-checker-fails
• 127-check-turning-off-certain-pydantic-validations
• 13-add-push-to-openbis-to-update-masterdata-in-openbis
• 13-add-push-to-openbis-to-update-masterdata-in-openbis_new_version
• 130-add-contributors-to-datamodel
• 133-feedback-after-data-store-days-apr-2025
• 137-bugs-when-implementing-cli-in-masterdata-checker
• 139-remove-validation-for-row_location
• 141-fix-mess-with-validation-rules-json-files-location
• 143-add-structlog-as-runtime-dependency
• 145-parsing-infrastructure
• 145-parsing-infrastructure-fixing-rebase
• 147-install-script-for-windows
• 149-adding-methods-for-collectiontype
• 151-implementation-of-__setattr__-for-objecttype-objectcontrolledvocabulary
• 153-change-auto_generated_codes-to-auto_generate_codes
• 155-redefine-datamodel
• 158-fix-checker-for-vocabulary-types
• 162-redefine-controlled-vocabulary-organism_group
• 163-add-existing-project-support-for-run_parser
• 165-write-documentation-about-parsing
• 166-create-graphics-for-parsing-etl-process
• 168-add-mandatory-check-when-setattr-in-objects
• 171-add-missing-vocabularies
• 173-fix-names-for-project-and-collection-in-run_parser
• 175-change-collectiontype-repr
• 177-add-support-to-select-space-when-parsing
• 179-keyerror-when-setting-name-in-nested-object-types
• 182-validation-of-datetime-in-masterdata-and-pybis
• 187-write-documentation-and-api-docstrings-into-the-mkdocs-page
• 189-fix-printing-of-classes
• 190-fix-paths-in-docu
• 193-fix-serialization-issue
• 196-add-possibility-of-update-metadata-in-an-object-during-parsing
• 197-object-data-types-refs
• 199-add-userid-utils
• 213-add-german-replacements-for-username
• 221-add-capability-to-support-collection-and-default-experiment-during-parsing
• 225-solve-checker-bugs
• 233-new-object-type-particle-size-analysis-by-laser-diffraction-methods
• 234-add-threading-to-run_parser-function
• 238-add-message-for-missing-vocabularies
• 242-accept-new-data-type-for-checker
• 244-units-standardization-in-the-datamodel
• 246-add-precommit-hooks
• 25-add-documentation-in-mkdocs
• 29-delete-version-from-definitions
• 30-define-datasettype-in-entities
• 35-interface-with-webprotege
• 38-move-fill-masterdata-to-cli
• 40-fill-masterdata-missing-collectiontype-and-datasettype-properties
• 43-extend-export_to-cli-to-accept-directory-paths
• 50-missing-information-in-propertytypedef-when-datatype-is-object
• 54-dataset_type-not-present-in-excel-header-when-generated-in-entities_to_excel
• 58-fix-export-to-excel
• 59-use-code-for-property-type-definitions
• 62-delete-gitmodules
• 63-clean-code-and-refactor-into-class---excel-to-entities
• 66-add-new-logo-to-repo
• 68-refactor-methods-of-baseentity
• 71-validation-mappings-in-separate-json-for-checker
• 74-clean-up-paths
• 79-fix-property-assignment-modify-setattr-the-behavior-should-be-that-instrumentaliasmyinstru-should-work-without-losing-the-character-of-being-a-propertytypeassignmentdata_typevarchar-right-now-it-overwrittes-it
• 79-fix-property-assignment-setattr
• 82-convert-current-data-model-to-json-format
• 83-convert-incoming-masterdata-to-be-checked-to-json-format
• 84-generate-validation-rules-in-json-format
• 85-perform-the-checks
• 87-add-excel-checker-files
• 91-add-row-cell-information-to-fill-masterdata-from-excel
• 93-export-datamodel-to-a-global-json
• 95-delete-duplicated-logic
• 97-in-fill_masterdata-using-cli-from-excel-files-generate-only-the-files-that-are-present-in-the-excel-file-not-generate-empty-files
• 98-add-all-the-excel-fields-to-excel_to_entities
• 99-add-line-when-generating-python-modules
• change_name_repo
• copilot/add-experiment-type-selection
• copilot/add-object-data-type-support
• copilot/add-support-for-data-type-object
• copilot/add-testing-for-run-parser
• copilot/create-parsing-tutorial
• copilot/fix-a3a6c9a8-b0f1-4cdf-b9b3-3d3ef82d5fa2
• copilot/investigate-github-workflow-failure
• correct_get_properties
• delete_datamodel
• excel_to_entities
• feature/fill_masterdata
• fix-docs-pipeline
• fix_datamodel
• fixes-after-dsd2025
• fixing_release
• hotfix_fill_masterdata
• hotfix_miss_code_in_run_parser
• hotfix_ordinal_attr
• hotfix_run_parser
• hotfix_username
• jmp_excel_to_entities
• jmp_using_classes
• main
• test-cell-info
• test_excel_to_entities
• use_pybis_patch
• v0.0.0
• v0.1.0
• v0.1.1
• v0.2.0
• v0.3.0
• v0.3.1
• v0.4.0
• v0.4.2
• v0.4.3
• v0.5.0
• v0.6.0
• v0.6.1
• v0.6.2
• v0.6.3
• v0.7.0
• v0.8.0
• v0.8.1
• v0.8.2
• v0.8.3
• v0.8.4
• v0.8.5
• v0.8.6
• vtint

Build # 16621067422

Build Type

Pull #157

github

Committed by JosePizarro3

Commit Message

Fix required properties in MasterdataValidator for Comments

Pull Request Pull Request #157: Fix COMMENTS checker

Run Details

917 of 1596 relevant lines covered (57.46%)

0.57 hits per line