Azure / karpenter-provider-azure
94%
main: 94%

Repo Added 23 Jan 2024 02:00AM UTC

Committed 08 Mar 2026 07:42PM UTC coverage: 93.607% (-0.1%) from 93.754%

Committed by

Commit Message

fix: harden multi-subscription error handling and document known limitations

- Remove //nolint:unused from resolveEffectiveClients (it is used)
- Return clear error when subscription differs but AZClientManager is nil,
  instead of silently falling through to default-subscription clients
- Add TODO on beginLaunchInstance documenting deferred multi-sub wiring
- Document known limitations in design doc (create/list/get/delete paths)
- Rewrite tests to actually exercise resolveEffectiveClients error path
- Add test for same-subscription override (no error expected)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

52 of 152 new or added lines in 6 files covered. (34.21%)

2 existing lines in 1 file now uncovered.

58814 of 62831 relevant lines covered (93.61%)

0.95 hits per line

62831 RELEVANT LINES 58814 COVERED LINES

0.95 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
22828425830	comtalyst/multi-sub-datadisk	fix: harden multi-subscription error handling and document known limitations - Remove //nolint:unused from resolveEffectiveClients (it is used) - Return clear error when subscription differs but AZClientManager is nil, instead of silently falli...	Pull #1497	08 Mar 2026 07:55PM UTC	comtalyst	github	93.61
22818707981	comtalyst/multi-sub-datadisk	fix: resolve lint issues in vminstance and vminstance_test - Add nolint:unused directive to resolveEffectiveClients (staged for future controller wiring, not yet called) - Assert on all DefaultVMProvider fields set in tests to fix govet unuse...	Pull #1497	08 Mar 2026 10:07AM UTC	comtalyst	github	93.54
22818375418	comtalyst/multi-sub-datadisk	feat: add multi-subscription support and data disk attachment Add per-NodeClass subscription, resource group, and location overrides to AzureNodeClass, enabling VMs to be created in different Azure subscriptions. Add AZClientManager for lazy per-...	Pull #1497	08 Mar 2026 09:45AM UTC	comtalyst	github	93.54
22807078995	comtalyst/multi-sub-datadisk	feat: add multi-subscription support and data disk attachment Add per-NodeClass subscription, resource group, and location overrides to AzureNodeClass, enabling VMs to be created in different Azure subscriptions. Add AZClientManager for lazy per-...	Pull #1497	07 Mar 2026 09:08PM UTC	comtalyst	github	93.54
22807079081	comtalyst/multi-sub-datadisk	feat: add multi-subscription support and data disk attachment Add per-NodeClass subscription, resource group, and location overrides to AzureNodeClass, enabling VMs to be created in different Azure subscriptions. Add AZClientManager for lazy per-...	Pull #1497	07 Mar 2026 09:08PM UTC	comtalyst	github	93.54
22799063295	comtalyst/multi-sub-datadisk	feat: add multi-subscription support and data disk attachment Add per-NodeClass subscription, resource group, and location overrides to AzureNodeClass, enabling VMs to be created in different Azure subscriptions. Add AZClientManager for lazy per-...	Pull #1497	07 Mar 2026 12:40PM UTC	comtalyst	github	93.54
22782127308	comtalyst/multi-sub-datadisk	feat: add multi-subscription support and dataDiskSizeGB to AzureNodeClass Add per-NodeClass subscription, resource group, and location overrides so VMs can be provisioned in different Azure subscriptions from a single controller. Implement AZClie...	Pull #1497	06 Mar 2026 09:22PM UTC	comtalyst	github	93.53

Azure / karpenter-provider-azure
94%
main: 94%

Azure / karpenter-provider-azure 94% main: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on comtalyst/multi-sub-datadisk

Recent builds

Azure / karpenter-provider-azure
94%
main: 94%

README BADGES
x

CHANGE BRANCH
x