Axelrod-Python / Axelrod

100%

master: 100%

LAST BUILD ON BRANCH fix-typing-for-mypy-2.1

branch: fix-typing-for-mypy-2.1

CHANGE BRANCH

x

Reset

• fix-typing-for-mypy-2.1
• 1038
• 1064
• 1065
• 1069
• 1085
• 1252
• 1282
• 1285
• 225
• 225-fsm
• 479
• 822
• 842
• 868
• 884
• 884-alternator
• 884-appeaser
• 884-averagecopier
• 884-axelrod_first
• 884-axelrodsecond
• 884-handshake
• 884-hunter
• 884-math
• 884-memorytwo
• 884-meta
• 884-mockplayer
• 884-oncebitten
• 884-player
• 884-prober
• 884-punisher
• 884-qlearners
• 884-retaliate
• 884-sequenceplayer
• 884-testmemoryone
• 885
• 957
• 958
• 961
• 971
• 985
• Chadys-802-vk
• Ducksual-680
• MariosZoulias-SteinRap-vk
• Nikoleta-v3-implement_transitive_fingerprint
• actions
• adaptor
• add-ability-to-pass-game-to-moran-process
• add-name-of-missing-author
• add-new-gradual-and-discussion-of-tournament
• add-paper-on-fsm-memory-algorithm
• add-support-for-python3.7
• add-test-for-memory-depth
• add-test-of-memory-to-all-fsms
• add-to-docstring-of-gradual
• add-wang-et-al-to-citations
• ann-patch
• author-fix
• authors
• badge
• badge-cp
• better-reset
• better-reset-test
• cave-patch
• champion
• citations
• clean-match-attribute-length-in-tests
• commits
• conda-appveyor
• contributing
• cover_fingerprint
• dblressurection
• dbs-name-docstring
• docs-fix
• docs-formatting
• docstring
• docstring-space
• document-receive-match-attributes
• eric-s-s-844-b_and_c-vk
• eric-s-s-orig
• extrafsmtest
• fix-broken-test
• fix-champion
• fix-cheating-strategies-bug
• fix-compute-features-and-retrain-ann
• fix-docs-bug-in-interactions
• fix-docstring-for-axl.black
• fix-documentation
• fix-first-tournament-second-tournament-confusion
• fix-geller-test
• fix-inconsistant-CI
• fix-inconsistant-CI-again
• fix-long-description
• fix-matplotlib-incompatibility
• fix-missing-yml-fil
• fix-numpy-depreciation
• fix-rm
• fix-rtd
• fix-sphinx-build
• fix-test
• fix-transitive-fp
• fix_travis
• format
• game-doc
• graph_fix
• grofman
• history-class-2019
• history_class
• improve_serialization
• init_args
• integrate_dojo
• issue-1055
• issue-1074
• issue-1074-vk
• issue-1079
• issue-894-vk
• issue-945
• kjurgielajtis-master
• links
• lookerup-patch
• lookerup-tests
• lower-bound-py-for-pip-install
• make-type-hinting-more-verbose-in-memory-one
• marcharper-patch-1
• marcharper-patch-2
• marcharper-patch-3
• master
• match_attributes
• mem1-rates
• mem2_zd
• meta-tests
• meta-winner-top-types
• minor-bug-in-gladstein
• minor-doc
• minor-doc-formatting
• minor-doc-tweak
• minor-fix-to-documentation
• morality_metrics
• moran-doc-formatting
• moran_plot
• mutation
• mypy-on-travis
• mypy_random
• new_zd
• notes_for_cheaters
• pass-match-attributes
• pep8
• pin-prompt-toolkit-version
• possible-v4
• pt2
• py36
• py37
• pyparsing
• random
• readme-revamp
• reconcile-moran-b
• reconcile-tournaments
• remove-assumed-impementations
• remove-hypothesis-from-setup
• remove-rtd-env
• revert-1301-fix-rs
• revert-prompt-toolkit
• rewrite-result-set
• run_tests
• small-doc-fix
• specify-32bit-for-appveyor
• squashed
• strategies
• strategies-patch
• test-player-tests
• testing-vk
• tfx
• tqdm-unpin
• transformers_docstring
• travis-error
• trim-some-tests
• typo-groffman-docstring
• ultimatum
• v2.10.0
• v2.11.0
• v2.12.0
• v2.13.0
• v2.7.0
• v2.8.0
• v2.9.0
• v3.0.0
• v3.1.0
• v3.1.1
• v3.1.2
• v3.10.0
• v3.11.0
• v3.2.0
• v3.2.1
• v3.3.0
• v3.4.0
• v3.5.0
• v3.6.0
• v3.7.0
• v3.8.0
• v3.8.1
• v3.9.0
• v4.0.0
• v4.1.0
• v4.2.0
• v4.2.1
• v4.2.2
• v4.3.0
• v4.4.0
• v4.5.0
• v4.6.0
• v4.7.0
• v4.8.0
• v4.9.1
• v4.9.1a
• warnings
• zd_docs

Build # 5035

Build Type

push

travis-ci

Committed by drvinceknight

Commit Message

Fix type hints for mypy 2.1

Closes #1176

Various things I've needed to do:

- In a number of places include that the type is `Optional[]`.
- In a number of places include an `assert` so that `mypy` knows that
  the type is no longer None.
- I have made a minor refactor to the Moran process, I could have used
  asserts but this actually pointed out a spot where I believe the tests
  were incorrect: we were testing a specific situation where
  `MoranProcess.birth` or `MoranProcess.death` should have been called with
  default `index=None` but was actually being tested with `index=0`.
- **I have ignored** a type hint check in `fingerprint.py`: I was
  completely unable to get this one happy

To ensure that any new PRs don't break CI let's merge this under bug fix.

Run Details

26 of 26 new or added lines in 8 files covered. (100.0%)

15412 of 15412 relevant lines covered (100.0%)

2.0 hits per line