Altinity / clickhouse-backup

69%

LAST BUILD ON BRANCH master

branch: master

CHANGE BRANCH

x

Reset

Sync Branches

• master
• 1346
• 20230707-cleanDir
• acvp-improve
• add_restore_table_mapping
• add_s3_restore_object
• add_skip_disks
• assume_container_exists
• async_operation_id
• awiik
• aws_sdk_update
• bug1291
• chunk-size
• clean_broken_retention
• clickhouse-go/v2
• codex/fix-s3-deleteobjects-content-md5-fallback
• container-labels
• dependabot/go_modules/cloud.google.com/go/storage-1.56.1
• dependabot/go_modules/cloud.google.com/go/storage-1.57.0
• dependabot/go_modules/cloud.google.com/go/storage-1.63.1
• dependabot/go_modules/github.com/Azure/azure-sdk-for-go/sdk/azcore-1.19.0
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2-1.38.1
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2-1.39.0
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2-1.39.2
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2-1.39.6
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2-1.42.1
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream-1.7.8
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/config-1.31.12
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/config-1.31.20
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/config-1.31.8
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/credentials-1.18.12
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/credentials-1.18.6
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/feature/s3/manager-1.19.12
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/feature/s3/manager-1.19.15
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/feature/s3/manager-1.19.9
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/feature/s3/manager-1.20.4
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/feature/s3/manager-1.20.7
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager-0.2.8
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager-0.3.4
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/s3-1.88.1
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/s3-1.88.3
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/s3-1.88.7
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/s3-1.90.0
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/s3-1.97.3
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/sts-1.38.0
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/sts-1.38.4
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/sts-1.40.2
• dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/sts-1.43.5
• dependabot/go_modules/github.com/aws/smithy-go-1.27.2
• dependabot/go_modules/github.com/aws/smithy-go-1.27.4
• dependabot/go_modules/github.com/buger/jsonparser-1.1.2
• dependabot/go_modules/github.com/docker/go-connections-0.8.1
• dependabot/go_modules/github.com/go-jose/go-jose/v4-4.1.4
• dependabot/go_modules/github.com/golang-jwt/jwt/v4-4.5.2
• dependabot/go_modules/github.com/golang-jwt/jwt/v5-5.2.2
• dependabot/go_modules/github.com/prometheus/client_golang-1.24.0
• dependabot/go_modules/github.com/stretchr/testify-1.11.0
• dependabot/go_modules/github.com/tencentyun/cos-go-sdk-v5-0.7.69
• dependabot/go_modules/github.com/tencentyun/cos-go-sdk-v5-0.7.70
• dependabot/go_modules/github.com/ulikunitz/xz-0.5.14
• dependabot/go_modules/go.etcd.io/bbolt-1.4.3
• dependabot/go_modules/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp-1.43.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.43.0
• dependabot/go_modules/golang.org/x/crypto-0.17.0
• dependabot/go_modules/golang.org/x/crypto-0.31.0
• dependabot/go_modules/golang.org/x/crypto-0.41.0
• dependabot/go_modules/golang.org/x/crypto-0.45.0
• dependabot/go_modules/golang.org/x/mod-0.37.0
• dependabot/go_modules/golang.org/x/net-0.17.0
• dependabot/go_modules/golang.org/x/net-0.36.0
• dependabot/go_modules/golang.org/x/net-0.38.0
• dependabot/go_modules/golang.org/x/sync-0.21.0
• dependabot/go_modules/golang.org/x/text-0.28.0
• dependabot/go_modules/golang.org/x/text-0.38.0
• dependabot/go_modules/google.golang.org/api-0.251.0
• dependabot/go_modules/google.golang.org/api-0.255.0
• dependabot/go_modules/google.golang.org/api-0.289.0
• dependabot/go_modules/google.golang.org/grpc-1.58.3
• dependabot/go_modules/google.golang.org/grpc-1.64.1
• dependabot/go_modules/google.golang.org/grpc-1.79.3
• dependabot/go_modules/google.golang.org/protobuf-1.33.0
• deutsch/example_docker_args
• doc_review_2023-11
• docs-usage-examples
• embbeded_backup_restore
• error-on-watch-when-delete-source-not-specified
• error-on-watch-when-keep-local-is-negative
• feat-gcs-new-skip-credential-property
• feat/1418-max-broken-part-ratio
• feat/acvp-wrapper-public-repro
• feat/cas-backups
• feat/force-rebalance-existing-disks
• feat/gcp-bucket-sa
• feat/gcs-disable-http2
• feat/gcs-disable-http2-v2
• feat/support-keeper-tls
• feat_add_rbac_masking_policy
• feat_calculate_free_space
• feat_disable_env_overriding
• feat_rbac_conflicts_ignore
• feat_rebalance
• feature/add_gcs_client_pool
• feature/fixhangingproblem
• feature/general-callback-url
• feature/info-command
• feature/manifest-skip-walk
• feature_add_rbac_configs_in_watch
• feature_rebase
• feature_tables_parts_and_partitions
• feature_watch_crontab
• fips
• fips_140_autotests
• fips_140_test
• fix-callbacks
• fix-gcs-custom-endpoint
• fix-k8s-example
• fix-readme-docker-run-casing
• fix-restore-table-mapping-schema
• fix-system-backups-empty-result
• fix-typo
• fix/1172-resumable-state-fatal-to-warn
• fix/1423-on-cluster-live-window-view
• fix/1428-rebind-replica-path-opt-in
• fix/1429-mask-sensitive-env-overrides
• fix/1432-restore-rbac-missing-access
• fix/batch-inprogress-mutations
• fix/cache-disk-name-resolution
• fix/force-rebalance-audit-bugs
• fix/incorrect-query-for-access-management-path
• fix/keeper-tls
• fix/live-view-on-cluster-enrich
• fix/restore-tablelist-o-n2
• fix/s3-credentials-cache
• fix/upload-part-checksum-object-lock
• fix_example_k8s_job_docs
• fix_issue_868
• fix_issue_878
• fix_issue_906
• fix_list_duration_s3_api_walk_5
• gcs_multipart
• get_status_by_operationid
• hermes-auto/clickhouse-backup-1379-skip-missing-metadata
• hermes-auto/clickhouse-backup-1382-resume-validate-parts
• hermes-auto/clickhouse-backup-1383-resume-missing-state
• hotfix_2_6_44
• hotfix_putMultipartCRC32
• improve_restore_table_mapping
• k8s-image-document-fix
• less_strict_check_parts_columns
• make_tests_parallel
• mapping-update
• minguyen/disablecheck
• minguyen/listformat
• minguyen/restore_remote
• modernize-azblob-auth
• object_disk_backup
• parallel_tests
• patch-1
• patch-2
• pgalbraith-backup-doc-container-doc-fix
• replicated_copy_to_attached
• respect-s3-max-parts-count
• restore-db-mapping-regex-fix
• s3-chunksize
• sharded-backup
• tadasobolevicius/server-stop-fix
• tadasobolevicius/stop_api_server_if_watch_fails
• testcontainers_migration
• v2.5
• v2.6
• watch
• zerolog

Build # 30480776381

Build Type

push

github

Committed by Slach

Commit Message

fix flaky TestResumeOperationsAfterRestart: don't treat broken backups as listed

backupListed matched any 'list' output containing the backup name, so a
partially uploaded remote backup (marked 'broken (can't stat metadata.json)')
satisfied the upload-resume assertion while the server-side
ResumeOperationsAfterRestart was still re-uploading. The test then deleted
the local backup (and its shadow hardlinks) from under the in-flight upload,
leaving a broken remote backup and failing the following download step with
'is empty backup'. Reproduced on slow COS in CI.

Now the backup only counts as listed when its own list line is not marked
broken/error.

Coverage Stats

16825 of 24483 relevant lines covered (68.72%)

44201.62 hits per line