AfterShip / clickhouse-sql-parser
56%
master: 56%

LAST BUILD BRANCH: fix/alter-table-settings-statement-level
DEFAULT BRANCH: master
Repo Added
Token F4x2H6fmkWoZPkof5HTWcZ5HSIXKiqDLa regen
Build 586 Last
Files 17
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/alter-table-settings-statement-level
branch: fix/alter-table-settings-statement-level
CHANGE BRANCH
x
Sync Branches

coverage: 56.199% (+0.06%) from 56.14%
33832045281

Pull #320

github

Lance726 
Move ALTER TABLE SETTINGS to the statement level

SETTINGS on ALTER TABLE is a query-level clause: ClickHouse accepts it
once, after the last alter clause, and rejects it mid-statement.

  -- rejected by ClickHouse
  ALTER TABLE t ADD COLUMN c Int SETTINGS alter_sync = 2, DROP COLUMN b
  -- accepted by ClickHouse
  ALTER TABLE t ADD COLUMN c Int, DROP COLUMN b SETTINGS alter_sync = 2

It was instead parsed per clause, by ADD COLUMN, ADD INDEX, DETACH
PARTITION and DROP PARTITION only, so every other form failed to parse
even though ClickHouse accepts it:

  ALTER TABLE t MODIFY COLUMN a Int64 SETTINGS alter_sync = 2
  ALTER TABLE t DROP COLUMN b SETTINGS alter_sync = 2
  ALTER TABLE t ADD COLUMN c Int, DROP COLUMN b SETTINGS alter_sync = 2
  ALTER TABLE t MATERIALIZE INDEX IF EXISTS idx SETTINGS mutations_sync = 2

Parse it once in parseAlterTable instead, after the clause list, and
reject it mid-statement as ClickHouse does.

Formatted SQL is unchanged for the clauses that already accepted
SETTINGS: only the AST placement moves, so their format/ goldens do not
change.

Breaking AST change: AlterTableAddColumn.Settings,
AlterTableAddIndex.Settings, AlterTableDetachPartition.Settings and
AlterTableDropPartition.Settings are removed in favour of
AlterTable.Settings.

Every form above was verified against clickhouse-local 26.8.2.7, in both
directions: the SQL parses here, and this parser's formatted output is
accepted by ClickHouse.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pull Request #320: Move ALTER TABLE SETTINGS to the statement level

16 of 24 new or added lines in 4 files covered. (66.67%)

1 existing line in 1 file now uncovered.

9542 of 16979 relevant lines covered (56.2%)

4095.09 hits per line

Relevant lines Covered
16979 RELEVANT LINES 9542 COVERED LINES
4095.09 HITS PER LINE
Source Files on fix/alter-table-settings-statement-level

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
33832045281 fix/alter-table-settings-statement-level Move ALTER TABLE SETTINGS to the statement level SETTINGS on ALTER TABLE is a query-level clause: ClickHouse accepts it once, after the last alter clause, and rejects it mid-statement. -- rejected by ClickHouse ALTER TABLE t ADD COLUMN c Int... Pull #320 Lance726 github
56.2
See All Builds (586)

Badge your Repo: clickhouse-sql-parser

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh