5monkeys / djedi-cms

97%

master: 96%

LAST BUILD ON BRANCH fix-race-condition-2

branch: fix-race-condition-2

CHANGE BRANCH

x

Reset

• fix-race-condition-2
• 1.0.1
• 1.0.2
• 1.0b2
• 1.0b3
• 1.0b4
• 1.0b5
• 1.0b6
• 1.0b7
• 1.1.5b0
• 1.1.7
• 1.2
• 1.2.1
• 1.2.2
• 1.2.3
• 1.2.4
• 1.3
• 1.3.1
• 1.3.2
• 1.3.3
• add-example-project
• andrei-wip
• argspec-3.0
• bugfix/no-duplicated-ast-nodes
• django1.11
• docs
• drop-python34
• feature/api
• feature/circleci
• feature/default-scheme
• feature/enable-sorting-nodes
• feature/json-validation
• feature/request-permissions
• feature/rest-disable-cache-default
• fix-race-condition
• fix-tests
• fix/get_cache
• fix/travis-pythons
• images
• master
• overflow-auto
• react
• release/2019-09-02
• silence-403
• test-suite-upgrade
• v3
• v4.0.1
• various-fixes

Build # 330

Build Type

Pull #42

travis-ci

Committed by web-flow

Commit Message

Fix race condition when clicking outlines to edit

Sometimes when clicking an outline for a node to edit it, the node is
blanked out. It still works to fill in some new text and save, but the
initial node text failed to load. This is due to a race condition. See the
comment added in the code for all the details.

Normally, these are the `console.log`s when clicking an outline:

```
cms.js?v=1.2.1:159 select node
cms.js?v=1.2.1:349 Plugin.connect()
cms.js?v=1.2.1:357 Plugin.connect().loaded
cms.js?v=1.2.1:378 Plugin.resize()
editor.js?v=1.2.1:232 Editor.onLoad() i18n://sv-se@home/test.md
editor.js?v=1.2.1:219 Editor.trigger page:node:fetch
editor.js?v=1.2.1:236 Editor.inititial data {data: "I like djedi!", content: "<p>I like djedi!</p>"}
editor.js?v=1.2.1:266 Editor.setNode()
editor.js?v=1.2.1:290 Editor.setState() new
editor.js?v=1.2.1:219 Editor.trigger page:node:fetch
editor.js?v=1.2.1:428 Editor.renderContent()
editor.js?v=1.2.1:362 Editor.renderRevisions()
editor.js?v=1.2.1:219 Editor.trigger plugin:loaded
editor.js?v=1.2.1:395 Editor.render()
editor.js?v=1.2.1:248 content <p>I like djedi!</p>
editor.js?v=1.2.1:219 Editor.trigger node:render
cms.js?v=1.2.1:16 Event node:render
cms.js?v=1.2.1:98 Node.render
```

But when the bug occurs, the logs are:

```
cms.js?v=1.2.1:159 select node
editor.js?v=1.2.1:232 Editor.onLoad() i18n://sv-se@home/test.md
editor.js?v=1.2.1:219 Editor.trigger page:node:fetch
editor.js?v=1.2.1:266 Editor.setNode()
editor.js?v=1.2.1:290 Editor.setState() new
editor.js?v=1.2.1:219 Editor.trigger page:node:fetch
editor.js?v=1.2.1:362 Editor.renderRevisions()
editor.js?v=1.2.1:219 Editor.trigger plugin:loaded
editor.js?v=1.2.1:395 Editor.render()
editor.js?v=1.2.1:248 content
cms.js?v=1.2.1:349 Plugin.connect()
cms.js?v=1.2.1:357 Plugin.connect().loaded
cms.js?v=1.2.1:378 Plugin.resize()
editor.js?v=1.2.1:219 Editor.trigger node:render
cms.js?v=1.2.1:16 Event node:render
```

Notice how `Editor.onLoad()` is called _before_ `Pl... (continued)

Pull Request Pull Request #42: Fix race condition when clicking outlines to edit

Run Details

1248 of 1282 relevant lines covered (97.35%)

0.97 hits per line