4finance / micro-infra-spring

76%

master: 74%

LAST BUILD ON BRANCH correlation-id-leak

branch: correlation-id-leak

CHANGE BRANCH

x

Reset

• correlation-id-leak
• 0.0.2
• 0.0.3
• 0.0.4
• 0.0.5
• 0.0.6
• 0.0.7
• 0.0.8
• 0.0.9
• 0.1.0
• 0.2.0
• 0.2.1
• 0.2.2
• 0.3.0
• 0.4.0
• 0.4.1
• 0.4.2
• 0.4.3
• 0.5.0
• 0.5.2
• 0.5.3
• 0.5.4
• 0.6.0
• 0.7.0
• 0.7.1
• 0.7.2
• 0.7.3
• 0.8.12
• 0.8.14
• 0.8.24
• 0.9.13
• 2.0.0
• 291-encrypt-key-cleanup
• Brixton.SR2
• abstract-spec-refactoring
• additional-properties-in-json-config
• allow_cipher_prefix
• async-retry
• backward-compatibility-for-stubs-artifacts
• beans-definition-and-overriding-POC
• bugfix/feign-obfuscated-response-logging
• bugfix/feign-request-logging-configuration
• bugfix/microservice-without-dependencies
• buildStages
• bumping-versions
• camel_correlation_id_aspect
• cb-java
• change/default-groovy-method-removed
• change/enable_gradle_deamon_and_parallel_build_by_default
• change/micro-infra-baseConfigToJava
• change/micro-infra-baseHystrixToJava
• change/micro-infra-spring-baseDiscoveryToJava
• change/micro-infra-spring-baseHealthcheckToJava
• change/micro-infra-spring-baseHystrixPackageToJava
• change/micro-infra-spring-baseMetricsToJava
• change/micro-infra-springModuleToJava
• change/migrate-micro-deps-to-java7
• change/migrate_correlationId_to_jdk7
• cipher-in-quotas
• clean_up_after_migration_to_java
• cobertura-branch
• common_directory_for_module_sources
• compile_static_micro_deps
• compile_static_stub_runner
• config-tests-refactoring
• configurable-jvm-metrics-path-base
• contributing_guidelines
• correlationId-in-jms
• correlationid-on-scheduled-actions
• crlf-in-tests
• deprecate_SwaggerDocumentationConfiguration
• disable-api-docs-validation
• disable_jmx_reporter_in_test
• document-in-wiki
• exclude_exception_handlers_config
• extract-collaborators
• feature/551-disableAllMetrics
• feature/aether
• feature/betterPublishing
• feature/boot122
• feature/brixton_release
• feature/brixton_sr1
• feature/changeReleasePrefix
• feature/commonRelease-0.1.17
• feature/daemonOnTravis
• feature/dependenciesUpdate
• feature/enableExternalPropertiesMetaAnnotation
• feature/force_stub_downloading
• feature/gradle_214
• feature/micro-infra-view-release1
• feature/new_wiremock
• feature/options-constructor-httpmockserver
• feature/ping_collaborator
• feature/portScannerBindException
• feature/rest-template-metrics-improvements
• feature/service_name_for_custom_stubs
• feature/spock10
• feature/spockInIdea
• feature/spring_boot_update
• feature/stubRunnerDeployFat
• feature/swagger095
• feature/track-user-activity
• feature/trackingFailingTravis
• feature/trackingFailingTravis2
• feature/update
• feature/urlInYaml
• feature/wiremock-2
• feature/wrapClosureMultipleParameters
• fix-base-path-value-expression
• fix/activity_tracker_index_out_of_band
• fix/allow_to_ping_any_service
• fix/autowire_zookeeperdiscoveryproperties
• fix/binary_data_encoding
• fix/collaborators-view-adjacency-matrix-controller-fix
• fix/correlationId-webasynctask-support
• fix/corrupted_response_on_obfuscating
• fix/npe_for_not_existing_span
• fix/port_clash
• fix/revert_port_clash
• fix/reverted-migrate-micro-deps-to-java7
• fix/skip_logging
• fix/track-user-actity-param-logging
• fix_for_Cannot_create_instance_whose_port_is_not_greater_than_0
• gitterWebhook
• global-properties-v2
• groovydoc
• healthcheck-endpoint-on-collaborators
• hystrix
• hystrix-graphite
• ignore-swagger-requests
• ignoreTildeFiles
• ip-tests
• issue/166-asyncCorrelationId
• issue/497-logging-all-communication
• issue/511-remove-internal-logs
• issue/539-permature_end_of_file_obfus
• issue/542-Logger-handling-no-content
• issue/556-stubs-property
• issues/107
• issues/133
• issues/138
• issues/139
• issues/140
• issues/144
• issues/148
• issues/150
• issues/153
• issues/157
• issues/160-GebTests
• issues/160-acceptanceTests
• issues/161
• issues/169
• issues/178
• issues/181
• issues/183
• issues/184-stubbed-health-ping
• issues/187-hystrix-rest-client
• issues/191
• issues/193
• issues/195
• issues/202-uuid-gen
• issues/203-merge-cleanup
• issues/208-javadoc
• issues/209
• issues/22
• issues/221
• issues/235
• issues/244
• issues/245-grapes-not-working
• issues/247
• issues/248
• issues/249-acceptanceGui
• issues/250-curator_retry_policy
• issues/253-bugWithZkPayload
• issues/255-sharedPropsAcrossEnvs
• issues/258-longPortAllocation
• issues/262
• issues/269-stubrunner-grabdeps
• issues/270-fix-ip-in-metrics-path
• issues/272-stubRunnerFailsLocally
• issues/277-default-udp-to-graphite
• issues/279-countrySpecificSharedProps
• issues/280-warnWhenConfigDirIsMissing
• issues/282
• issues/292-no-excep-on-stub-missing
• issues/297-build-issues
• issues/308
• issues/309-ignoredYamlErrors
• issues/315
• issues/321-old-servlet-api
• issues/332
• issues/334-servlet-api-3.1
• issues/336-wrapping-with-response-entity
• issues/337-lazy-service-url-eval
• issues/338-adding-callable-as-hystrix-fallback
• issues/341-moving-microservice.json-to-props
• issues/342
• issues/345
• issues/347
• issues/365-jceTests
• issues/396-moved-commit-hash
• issues/402
• issues/416
• issues/434
• issues/441-stub-runner-offline-accesses-repo
• issues/457-precedence-of-git-props
• issues/459-metrics-path-env-from-sys-props
• issues/470
• issues/495
• issues/502-custom-stub-naming
• issues/533-default-props-for-nonspringcloud
• issues/553-hardcodedEnv
• issues/556-to-legacy
• issues/585-incompatibility-between-versions
• issues/79
• issues/load-balanced-interceptor-in-rest-template
• issues/workaround-for-ip-resolution
• jacoco
• json_serialization_improvements
• jvm-metrics-switch
• legacy
• legacy-feature/stubs-repository-layout-change
• legacy__bumping-wiremock-version
• legacy_branch
• log-myself
• logback-configuration
• master
• merge/micro-deps-spring-config
• metric_path_nodename_without_dots
• metrics-base-path
• micro_deps_spring_readme
• migratingBaseToJdk7
• migratingInfraToJdk7
• modularization
• moving_changelog
• new-metrics
• option-fromNullable
• origin/bumpUpVersions
• ping-200-ok
• porting_more_tolerance_on_payload_and_urispec_from_0.9.13
• proper-sourcesets
• propertiesEncryption
• provider-strategies-fix
• qualifier
• reactorModule
• rebasingPRWithLessCode
• rebasingPullRequestDoc
• release
• release/0.1.206-delete-me
• release/0.1.207-delete-me
• release/0.7.2
• release/0.9.1
• remove-deprecated-code
• remove-groovy-transformations-from-java-classes
• remove-superfluous-component-scan
• remove-unused-resources
• remove_WebAppConfiguration
• remove_groovy_from_swagger
• remove_groovy_methods_from_java_code
• remove_noverify_flag
• remove_obsolete_changelogs
• remove_outdated_examples
• remove_redundant_files
• resolver_config
• restTemplateFluentApi
• retry-threads-property
• revert-640-master
• service-alias
• smokeTestsProfile
• spring-cloud-edgware-sr1
• spring_update
• suffixSpecInSpockSpecs
• swagger-skip-pattern
• tech/461-excludeSwaggerFromSonar
• tech/add-more-logging-for-stubrunner
• tech/adding-more-logging-to-config
• tech/backporting_service_instance_ignoring_payload
• tech/betterHttpQueryParameters
• tech/boot_update
• tech/bump_wiremock
• tech/bumping-gradle
• tech/cacheTravis2
• tech/cglib-3.2.0
• tech/closureCallable
• tech/do-not-ignore-hash-file
• tech/enableGuiTests
• tech/fixReleaseToken
• tech/hash-bang-for-ruby-script
• tech/https_for_nexus
• tech/integration_with_sleuth
• tech/micro-infra-version-in-boot-check
• tech/migratingCamelToJdk7
• tech/migratingMicroDepsSpringConfigToJdk7
• tech/migratingMicroDepsToJdk7
• tech/migratingReactorToJdk7
• tech/migration-to-spring-cloud-zookeeper
• tech/migration-to-spring-cloud-zookeeper-fix
• tech/new_version_spring_cloud
• tech/providedSpock10
• tech/queryParameters
• tech/rx_java_dependency
• tech/sonar
• tech/spockGlobalUnroll
• tech/spring-cloud-zoo-issues
• tech/stackOverflowBadge
• tech/stubs_information
• tech/tracing_and_logging_capabilities
• tech/update_nexus
• tech/uptodate-in-gui
• tech/versionInLegacy
• test-fix
• throws-exception
• timeout-listener-refactoring
• topic/auto-configure
• topic/coverallsSandbox
• topic/depsUpdate
• topic/depsUpdate2
• topic/docPRName
• topic/enable-correlation-id-for-camel
• topic/enable-documentation
• topic/i101JacksonFeaturesB
• topic/i116animalSniffer
• topic/i70dependencyManagement
• topic/i83regionalConfigs
• topic/i89runtimeDependencies
• topic/jceUs
• topic/mergeFF
• topic/restClientCustomization
• topic/restCustomization
• topic/spock10
• topic/spock10b
• topic/springBoot12
• topic/starter
• topic/timeout
• two_rest_templates
• typo-fix
• un-ignore-decrypt-tests
• unmodifiable-collections
• updating-springfox-swagger
• upgrade-hystrix
• upgrade-spring
• use-domain-classes
• use-service-cache
• useMicroserviceDefinitionsAllowFalseValue

Build # 1751

Build Type

push

travis-ci

Committed by nurkiewicz

Commit Message

Correlation ID passed to CorrelationIdUpdater.withId() is not cleaned afterwards

If thread has no correlation ID attached, after calling withId() this explicit CID remains

This happens because during cleanup we call updateCorrelationId(null), which does nothing rather than cleaning up

Run Details

1806 of 2387 relevant lines covered (75.66%)

0.76 hits per line