4579

pending completion

Build # 4579

Build Type

Pull #1905

travis-ci

Committed by

web-flow

Commit Message

<a href="https://github.com/openmrs/openmrs-core/commit/<a class=hub.com/openmrs/openmrs-core/commit/a0b767d813713efda2e63ab72dcf553310a1422c">a0b767d81<a href="https://github.com/openmrs/openmrs-core/commit/a0b767d813713efda2e63ab72dcf553310a1422c">&quot;&gt;Revert &amp;quot;GCI-142 fixing bad code practices from Sonar&quot;

This reverts commit </a><a class="double-link" href="https://github.com/openmrs/openmrs-core/commit/<a class="double-link" href="https://github.com/openmrs/openmrs-core/commit/eaaee0d5853fe104c5eac1b09cb75c3916972e0a">eaaee0d58</a>">eaaee0d58</a><a href="https://github.com/openmrs/openmrs-core/commit/a0b767d813713efda2e63ab72dcf553310a1422c">.

"GCI Fix bad code through SonarQube"

Pull Request Pull Request #1905: GCI-142 Check bad code practices on Sonar

Run Details

4 of 4 new or added lines in 2 files covered. (100.0%)

18062 of 32332 relevant lines covered (55.86%)

0.56 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.05

/api/src/main/java/org/openmrs/ConceptNameTag.java

/**
 * This Source Code Form is subject to the terms of the Mozilla Public License,
 * v. 2.0. If a copy of the MPL was not distributed with this file, You can
 * obtain one at http://mozilla.org/MPL/2.0/. OpenMRS is also distributed under
 * the terms of the Healthcare Disclaimer located at http://openmrs.org/license.
 *
 * Copyright (C) OpenMRS Inc. OpenMRS is a registered trademark and the OpenMRS
 * graphic logo is a trademark of OpenMRS Inc.
 */
package org.openmrs;

import java.util.Date;

import org.codehaus.jackson.annotate.JsonIgnore;

/**
 * ConceptNameTag is a textual tag which can be applied to a ConceptName.
 */
public class ConceptNameTag extends BaseOpenmrsObject implements Auditable, Voidable, java.io.Serializable {
        
        public static final long serialVersionUID = 33226787L;
        
        // Fields
        private Integer conceptNameTagId;
        
        private String tag;
        
        private String description;
        
        private User creator;
        
        private Date dateCreated;
        
        private Boolean voided = false;
        
        private User voidedBy;
        
        private Date dateVoided;
        
        private String voidReason;
        
        // Constructors
        
        /**
         * Default constructor.
         */
        public ConceptNameTag() {
        }
        
        /**
         * Public constructor. Use factory methods to obtain copies of the desired tags.
         * 
         * @param tag
         * @param description
         */
        public ConceptNameTag(String tag, String description) {
                setTag(tag);
                setDescription(description);
        }
        
        // Property accessors
        
        /**
         * Returns the textual representation of this ConceptNameTag.
         * 
         * @return the textual representation of this ConceptNameTag.
         */
        public String getTag() {
                return tag;
        }
        
        /**
         * Sets the textual representation of this ConceptNametag.
         * 
         * @param tag the textual representation
         */
        public void setTag(String tag) {
                this.tag = tag;
        }
        
        /**
         * Returns the description of this tag.
         * 
         * @return the description of this tag
         */
        public String getDescription() {
                return description;
        }
        
        /**
         * Sets the description of this tag.
         * 
         * @param description
         */
        public void setDescription(String description) {
                this.description = description;
        }
        
        /**
         * @return Returns the creator.
         */
        public User getCreator() {
                return creator;
        }
        
        /**
         * @param creator The creator to set.
         */
        public void setCreator(User creator) {
                this.creator = creator;
        }
        
        /**
         * @return Returns the dateCreated.
         */
        public Date getDateCreated() {
                return dateCreated;
        }
        
        /**
         * @param dateCreated The dateCreated to set.
         */
        public void setDateCreated(Date dateCreated) {
                this.dateCreated = dateCreated;
        }
        
        /**
         * Returns whether the ConceptName has been voided.
         * 
         * @return true if the ConceptName has been voided, false otherwise.
         * 
         * @deprecated as of 2.0, use {@link #getVoided()}
         */
        @Deprecated
        @JsonIgnore
        public Boolean isVoided() {
                return getVoided();
        }
        
        /**
         * Returns whether the ConceptName has been voided.
         * 
         * @return true if the ConceptName has been voided, false otherwise.
         */
        public Boolean getVoided() {
                return voided;
        }
        
        /**
         * Sets the voided status of the ConceptName.
         * 
         * @param voided the voided status to set.
         */
        public void setVoided(Boolean voided) {
                this.voided = voided;
        }
        
        /**
         * Returns the User who voided this ConceptName.
         * 
         * @return the User who voided this ConceptName, or null if not set
         */
        public User getVoidedBy() {
                return voidedBy;
        }
        
        /**
         * Sets the User who voided this ConceptName.
         * 
         * @param voidedBy the user who voided this ConceptName.
         */
        public void setVoidedBy(User voidedBy) {
                this.voidedBy = voidedBy;
        }
        
        /**
         * Returns the Date this ConceptName was voided.
         * 
         * @return the Date this ConceptName was voided.
         */
        public Date getDateVoided() {
                return dateVoided;
        }
        
        /**
         * Sets the Data this ConceptName was voided.
         * 
         * @param dateVoided the date the ConceptName was voided.
         */
        public void setDateVoided(Date dateVoided) {
                this.dateVoided = dateVoided;
        }
        
        /**
         * Returns the reason this ConceptName was voided.
         * 
         * @return the reason this ConceptName was voided
         */
        public String getVoidReason() {
                return voidReason;
        }
        
        /**
         * Sets the reason this ConceptName was voided.
         * 
         * @param voidReason the reason this ConceptName was voided
         */
        public void setVoidReason(String voidReason) {
                this.voidReason = voidReason;
        }
        
        public String toString() {
                return this.tag;
        }
        
        /**
         * @return the conceptNameTagId
         */
        public Integer getConceptNameTagId() {
                return conceptNameTagId;
        }
        
        /**
         * @param conceptNameTagId the conceptNameTagId to set
         */
        public void setConceptNameTagId(Integer conceptNameTagId) {
                this.conceptNameTagId = conceptNameTagId;
        }
        
        /**
         * @since 1.5
         * @see org.openmrs.OpenmrsObject#getId()
         */
        public Integer getId() {
                return getConceptNameTagId();
        }
        
        /**
         * @since 1.5
         * @see org.openmrs.OpenmrsObject#setId(java.lang.Integer)
         */
        public void setId(Integer id) {
                setConceptNameTagId(id);
        }
        
        /**
         * Not currently used. Always returns null.
         * 
         * @see org.openmrs.Auditable#getChangedBy()
         */
        public User getChangedBy() {
                return null;
        }
        
        /**
         * Not currently used. Always returns null.
         * 
         * @see org.openmrs.Auditable#getDateChanged()
         */
        public Date getDateChanged() {
                return null;
        }
        
        /**
         * Not currently used.
         * 
         * @see org.openmrs.Auditable#setChangedBy(org.openmrs.User)
         */
        public void setChangedBy(User changedBy) {
                
        }
        
        /**
         * Not currently used.
         * 
         * @see org.openmrs.Auditable#setDateChanged(java.util.Date)
         */
        public void setDateChanged(Date dateChanged) {
                
        }
}

1	/**
2	* This Source Code Form is subject to the terms of the Mozilla Public License,
3	* v. 2.0. If a copy of the MPL was not distributed with this file, You can
4	* obtain one at http://mozilla.org/MPL/2.0/. OpenMRS is also distributed under
5	* the terms of the Healthcare Disclaimer located at http://openmrs.org/license.
6	*
7	* Copyright (C) OpenMRS Inc. OpenMRS is a registered trademark and the OpenMRS
8	* graphic logo is a trademark of OpenMRS Inc.
9	*/
10	package org.openmrs;
11
12	import java.util.Date;
13
14	import org.codehaus.jackson.annotate.JsonIgnore;
15
16	/**
17	* ConceptNameTag is a textual tag which can be applied to a ConceptName.
18	*/
19	public class ConceptNameTag extends BaseOpenmrsObject implements Auditable, Voidable, java.io.Serializable {
20
21	public static final long serialVersionUID = 33226787L;
22
23	// Fields
24	private Integer conceptNameTagId;
25
26	private String tag;
27
28	private String description;
29
30	private User creator;
31
32	private Date dateCreated;
33
34	private Boolean voided = false;	1✔
35
36	private User voidedBy;
37
38	private Date dateVoided;
39
40	private String voidReason;
41
42	// Constructors
43
44	/**
45	* Default constructor.
46	*/
47	public ConceptNameTag() {	1✔
48	}	1✔
49
50	/**
51	* Public constructor. Use factory methods to obtain copies of the desired tags.
52	*
53	* @param tag
54	* @param description
55	*/
56	public ConceptNameTag(String tag, String description) {	1✔
57	setTag(tag);	1✔
58	setDescription(description);	1✔
59	}	1✔
60
61	// Property accessors
62
63	/**
64	* Returns the textual representation of this ConceptNameTag.
65	*
66	* @return the textual representation of this ConceptNameTag.
67	*/
68	public String getTag() {
69	return tag;	1✔
70	}
71
72	/**
73	* Sets the textual representation of this ConceptNametag.
74	*
75	* @param tag the textual representation
76	*/
77	public void setTag(String tag) {
78	this.tag = tag;	1✔
79	}	1✔
80
81	/**
82	* Returns the description of this tag.
83	*
84	* @return the description of this tag
85	*/
86	public String getDescription() {
87	return description;	1✔
88	}
89
90	/**
91	* Sets the description of this tag.
92	*
93	* @param description
94	*/
95	public void setDescription(String description) {
96	this.description = description;	1✔
97	}	1✔
98
99	/**
100	* @return Returns the creator.
101	*/
102	public User getCreator() {
103	return creator;	1✔
104	}
105
106	/**
107	* @param creator The creator to set.
108	*/
109	public void setCreator(User creator) {
110	this.creator = creator;	1✔
111	}	1✔
112
113	/**
114	* @return Returns the dateCreated.
115	*/
116	public Date getDateCreated() {
117	return dateCreated;	1✔
118	}
119
120	/**
121	* @param dateCreated The dateCreated to set.
122	*/
123	public void setDateCreated(Date dateCreated) {
124	this.dateCreated = dateCreated;	1✔
125	}	1✔
126
127	/**
128	* Returns whether the ConceptName has been voided.
129	*
130	* @return true if the ConceptName has been voided, false otherwise.
131	*
132	* @deprecated as of 2.0, use {@link #getVoided()}
133	*/
134	@Deprecated
135	@JsonIgnore
136	public Boolean isVoided() {
137	return getVoided();	1✔
138	}
139
140	/**
141	* Returns whether the ConceptName has been voided.
142	*
143	* @return true if the ConceptName has been voided, false otherwise.
144	*/
145	public Boolean getVoided() {
146	return voided;	1✔
147	}
148
149	/**
150	* Sets the voided status of the ConceptName.
151	*
152	* @param voided the voided status to set.
153	*/
154	public void setVoided(Boolean voided) {
155	this.voided = voided;	1✔
156	}	1✔
157
158	/**
159	* Returns the User who voided this ConceptName.
160	*
161	* @return the User who voided this ConceptName, or null if not set
162	*/
163	public User getVoidedBy() {
164	return voidedBy;	1✔
165	}
166
167	/**
168	* Sets the User who voided this ConceptName.
169	*
170	* @param voidedBy the user who voided this ConceptName.
171	*/
172	public void setVoidedBy(User voidedBy) {
173	this.voidedBy = voidedBy;	1✔
174	}	1✔
175
176	/**
177	* Returns the Date this ConceptName was voided.
178	*
179	* @return the Date this ConceptName was voided.
180	*/
181	public Date getDateVoided() {
182	return dateVoided;	1✔
183	}
184
185	/**
186	* Sets the Data this ConceptName was voided.
187	*
188	* @param dateVoided the date the ConceptName was voided.
189	*/
190	public void setDateVoided(Date dateVoided) {
191	this.dateVoided = dateVoided;	1✔
192	}	1✔
193
194	/**
195	* Returns the reason this ConceptName was voided.
196	*
197	* @return the reason this ConceptName was voided
198	*/
199	public String getVoidReason() {
200	return voidReason;	1✔
201	}
202
203	/**
204	* Sets the reason this ConceptName was voided.
205	*
206	* @param voidReason the reason this ConceptName was voided
207	*/
208	public void setVoidReason(String voidReason) {
209	this.voidReason = voidReason;	1✔
210	}	1✔
211
212	public String toString() {
213	return this.tag;	1✔
214	}
215
216	/**
217	* @return the conceptNameTagId
218	*/
219	public Integer getConceptNameTagId() {
220	return conceptNameTagId;	1✔
221	}
222
223	/**
224	* @param conceptNameTagId the conceptNameTagId to set
225	*/
226	public void setConceptNameTagId(Integer conceptNameTagId) {
227	this.conceptNameTagId = conceptNameTagId;	1✔
228	}	1✔
229
230	/**
231	* @since 1.5
232	* @see org.openmrs.OpenmrsObject#getId()
233	*/
234	public Integer getId() {
235	return getConceptNameTagId();	1✔
236	}
237
238	/**
239	* @since 1.5
240	* @see org.openmrs.OpenmrsObject#setId(java.lang.Integer)
241	*/
242	public void setId(Integer id) {
243	setConceptNameTagId(id);	×
244	}	×
245
246	/**
247	* Not currently used. Always returns null.
248	*
249	* @see org.openmrs.Auditable#getChangedBy()
250	*/
251	public User getChangedBy() {
252	return null;	×
253	}
254
255	/**
256	* Not currently used. Always returns null.
257	*
258	* @see org.openmrs.Auditable#getDateChanged()
259	*/
260	public Date getDateChanged() {
261	return null;	×
262	}
263
264	/**
265	* Not currently used.
266	*
267	* @see org.openmrs.Auditable#setChangedBy(org.openmrs.User)
268	*/
269	public void setChangedBy(User changedBy) {
270
271	}	×
272
273	/**
274	* Not currently used.
275	*
276	* @see org.openmrs.Auditable#setDateChanged(java.util.Date)
277	*/
278	public void setDateChanged(Date dateChanged) {
279
280	}	×
281	}

openmrs / openmrs-core / 4579

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous