1102

pending completion

Build # 1102

Build Type

Pull #401

travis-ci

Committed by

web-flow

Commit Message

Replace GetListenEndpoint() with ReadyForConnections()

The RunServer() function (and the various variants)
call Server.Start() in a go-routine, but do not return until
it has verified that the server is ready to accept connections.
To do so, it use GetListenEndpoint() to get a suitable connect
address (replacing "0.0.0.0" or "::" with localhost - important
on Windows). It then creates a raw TCP connection to ensure the
server is started, repeating the process in case of failure up
to 10 seconds.

This PR replaces this with a function that checks that client
listener, and route listener if configured, are set. This removes
the need to get a connect address and create test tcp connections.

The reason for this change is that NATS Streaming when starting
the NATS Server (unless configured to connect to a remote one)
calls RunServerWithAuth(), which when getting "localhost" from
GetListenEndpoint(), would fail trying to resolve it. This happened
for the NATS Streaming Docker image built with Go 1.7+.

Pull Request Pull Request #401: Replace GetListenEndpoint() with ReadyForConnections()

Run Details

18 of 18 new or added lines in 3 files covered. (100.0%)

4926 of 5500 relevant lines covered (89.56%)

2624.85 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.4

/test/test.go

Build SHA Not Found

The commit SHA "3e0bd14a0c1d9a8834e64a64b0f6a45ba4612a96" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

nats-io / gnatsd / 1102

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous