14564

pending completion

Build # 14564

Build Type

Pull #8422

travis-ci

Committed by

web-flow

Commit Message

Fix portal unmounting

We used to terminate the search on host nodes, and then use the nested unmount algorithm.
However this means we didn't unmount portals inside the host nodes.

We will probably need to restructure this somehow but for now I just added a recursive call to unblock myself.

Pull Request Pull Request #8422: [Fiber] Fix portal unmounting

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

8349 of 9978 relevant lines covered (83.67%)

2502.29 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.82

/src/renderers/shared/fiber/ReactFiberCommitWork.js

Build SHA Not Found

The commit SHA "1a796558acae302647243a594a976f7493c5c2aa" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

facebook / react / 14564

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous