14529

pending completion

Build # 14529

Build Type

Pull #8406

travis-ci

Committed by

web-flow

Commit Message

Remove output field

The idea was originally that each fiber has a return value. In practice
most of what we're modelling here are void functions and we track side
effects instead of return values.

We do use this for coroutines to short cut access to terminal yields.
However, since this can be nested fragments we end up searching the tree
anyway. We also have to manage this in transferOutput so it ends up being
as expensive. Maybe we can save some traversal for updates when coroutine
branches bail out but meh.

Pull Request Pull Request #8406: [Fiber] Remove output field

Run Details

32 of 32 new or added lines in 4 files covered. (100.0%)

8347 of 9974 relevant lines covered (83.69%)

2503.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

89.92

/src/renderers/shared/fiber/ReactFiberCompleteWork.js

Build SHA Not Found

The commit SHA "1b408171d3e4fb294bdc8838add45091fb4f18c7" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

facebook / react / 14529

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous