14524

pending completion

Build # 14524

Build Type

Pull #8400

travis-ci

Committed by

web-flow

Commit Message

Split initial children out of createInstance

The goal of this is to avoid passing an opaque data structure that needs
to be recursively searched by the host.

I considered having some helper for doing the recursion but I figured it
might be helpful to let the reconciler move this around. For example we
might want to create an instance in beginWork and add to it as we go.
This would let us avoid traversing the tree twice and would solve the IE11
perf issue.

So instead, we create the instance first then call appendChild. I could
just call the normal one but I figured that I would make a special one
just in case. For example if you wanted to perform commits on a separate
thread from creation. This turned out to be useful in ReactNoop where I
can avoid searching the array for an existing one since I know the child
isn't there already. (Although splitting placement into insertion/move
might be better.)

Finally, we need the ability to update an instance after all the children
have been insertion. Such as `<select value={...} />`. I called this
finalizeInitialChildren.

Pull Request Pull Request #8400: [Fiber] Update root children using appendChild/insertBefore/removeChild

Run Details

59 of 59 new or added lines in 5 files covered. (100.0%)

8349 of 9974 relevant lines covered (83.71%)

2502.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

62.31

/src/renderers/noop/ReactNoop.js

Build SHA Not Found

The commit SHA "b52ab0629c74a443bf147df9f69719193b5a18a1" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

facebook / react / 14524

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous