14203

pending completion

Build # 14203

Build Type

Pull #8251

travis-ci

Committed by

web-flow

Commit Message

Handle nested controlled events

I came up with a contrived case of where nested controlled events could
fire within the same batch - but on different targets.

I think we came to the conclusion that controlled values typically cannot
use preventDefault so it is ok that they don't flush until after the event
has finished. So therefore we accumulate a queue of all the nested targets
within a batch and then restore state on all of them.

I'm still skeptical that this is the correct way to do controlled values.
The reason we have to do them in a single event loop is because when you
type, the sequence of values that get accepted or not can matter. I wonder
if there is a scenario we can come up with where you can fire multiple
inner events in an event loop and end up with batching causing problems.

This effectively just reimplements asap again but with no allocations for
a single target and no closure allocations.

Pull Request Pull Request #8251: Handle nested controlled events

Run Details

29 of 29 new or added lines in 4 files covered. (100.0%)

8378 of 9439 relevant lines covered (88.76%)

3042.31 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.21

/src/renderers/shared/shared/event/ReactControlledComponent.js

Build SHA Not Found

The commit SHA "43881b62fd1434b74b568915574b3edd05d58a94" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

facebook / react / 14203

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous