14134

pending completion

Build # 14134

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Revert "Check for event listener in props instead of bank (#8192)" (#8239)

This reverts commit a878c3056.

The previous stuff that this builds on didn't successfully land fully. Since I
want to measure this in isolation, I'll revert this for now.

Run Details

69 of 69 new or added lines in 3 files covered. (100.0%)

8343 of 9413 relevant lines covered (88.63%)

3052.19 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.52

/src/renderers/native/ReactNativeBaseComponent.js

/**
 * Copyright (c) 2015-present, Facebook, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the BSD-style license found in the
 * LICENSE file in the root directory of this source tree. An additional grant
 * of patent rights can be found in the PATENTS file in the same directory.
 *
 * @providesModule ReactNativeBaseComponent
 * @flow
 */
'use strict';

var NativeMethodsMixin = require('NativeMethodsMixin');
var ReactNativeAttributePayload = require('ReactNativeAttributePayload');
var ReactNativeComponentTree = require('ReactNativeComponentTree');
var ReactNativeEventEmitter = require('ReactNativeEventEmitter');
var ReactNativeTagHandles = require('ReactNativeTagHandles');
var ReactMultiChild = require('ReactMultiChild');
var UIManager = require('UIManager');

var deepFreezeAndThrowOnMutationInDev = require('deepFreezeAndThrowOnMutationInDev');

var registrationNames = ReactNativeEventEmitter.registrationNames;
var putListener = ReactNativeEventEmitter.putListener;
var deleteListener = ReactNativeEventEmitter.deleteListener;
var deleteAllListeners = ReactNativeEventEmitter.deleteAllListeners;

type ReactNativeBaseComponentViewConfig = {
  validAttributes: Object;
  uiViewClassName: string;
}

// require('UIManagerStatTracker').install(); // uncomment to enable

/**
 * @constructor ReactNativeBaseComponent
 * @extends ReactComponent
 * @extends ReactMultiChild
 * @param {!object} UIKit View Configuration.
 */
var ReactNativeBaseComponent = function(
  viewConfig: ReactNativeBaseComponentViewConfig
) {
  this.viewConfig = viewConfig;
};

/**
 * Mixin for containers that contain UIViews. NOTE: markup is rendered markup
 * which is a `viewID` ... see the return value for `mountComponent` !
 */
ReactNativeBaseComponent.Mixin = {
  getPublicInstance: function() {
    // TODO: This should probably use a composite wrapper
    return this;
  },

  unmountComponent: function(safely, skipLifecycle) {
    ReactNativeComponentTree.uncacheNode(this);
    deleteAllListeners(this);
    this.unmountChildren(safely, skipLifecycle);
    this._rootNodeID = 0;
  },

  /**
   * Every native component is responsible for allocating its own `tag`, and
   * issuing the native `createView` command. But it is not responsible for
   * recording the fact that its own `rootNodeID` is associated with a
   * `nodeHandle`. Only the code that actually adds its `nodeHandle` (`tag`) as
   * a child of a container can confidently record that in
   * `ReactNativeTagHandles`.
   */
  initializeChildren: function(children, containerTag, transaction, context) {
    var mountImages = this.mountChildren(children, transaction, context);
    // In a well balanced tree, half of the nodes are in the bottom row and have
    // no children - let's avoid calling out to the native bridge for a large
    // portion of the children.
    if (mountImages.length) {

      // TODO: Pool these per platform view class. Reusing the `mountImages`
      // array would likely be a jit deopt.
      var createdTags = [];
      for (var i = 0, l = mountImages.length; i < l; i++) {
        var mountImage = mountImages[i];
        var childTag = mountImage;
        createdTags[i] = childTag;
      }
      UIManager.setChildren(containerTag, createdTags);
    }
  },

  /**
   * Updates the component's currently mounted representation.
   *
   * @param {object} nextElement
   * @param {ReactReconcileTransaction} transaction
   * @param {object} context
   * @internal
   */
  receiveComponent: function(nextElement, transaction, context) {
    var prevElement = this._currentElement;
    this._currentElement = nextElement;

    if (__DEV__) {
      for (var key in this.viewConfig.validAttributes) {
        if (nextElement.props.hasOwnProperty(key)) {
          deepFreezeAndThrowOnMutationInDev(nextElement.props[key]);
        }
      }
    }

    var updatePayload = ReactNativeAttributePayload.diff(
      prevElement.props,
      nextElement.props,
      this.viewConfig.validAttributes
    );

    if (updatePayload) {
      UIManager.updateView(
        this._rootNodeID,
        this.viewConfig.uiViewClassName,
        updatePayload
      );
    }

    this._reconcileListenersUponUpdate(
      prevElement.props,
      nextElement.props
    );
    this.updateChildren(nextElement.props.children, transaction, context);
  },

  /**
   * @param {object} initialProps Native component props.
   */
  _registerListenersUponCreation: function(initialProps) {
    for (var key in initialProps) {
      // NOTE: The check for `!props[key]`, is only possible because this method
      // registers listeners the *first* time a component is created.
      if (registrationNames[key] && initialProps[key]) {
        var listener = initialProps[key];
        putListener(this, key, listener);
      }
    }
  },

  /**
   * Reconciles event listeners, adding or removing if necessary.
   * @param {object} prevProps Native component props including events.
   * @param {object} nextProps Next native component props including events.
   */
  _reconcileListenersUponUpdate: function(prevProps, nextProps) {
    for (var key in nextProps) {
      if (registrationNames[key] && (nextProps[key] !== prevProps[key])) {
        if (nextProps[key]) {
          putListener(this, key, nextProps[key]);
        } else {
          deleteListener(this, key);
        }
      }
    }
  },

  /**
   * Currently this still uses IDs for reconciliation so this can return null.
   *
   * @return {null} Null.
   */
  getHostNode: function() {
    return this._rootNodeID;
  },

  /**
   * @param {ReactNativeReconcileTransaction} transaction
   * @param {?ReactNativeBaseComponent} the parent component instance
   * @param {?object} info about the host container
   * @param {object} context
   * @return {string} Unique iOS view tag.
   */
  mountComponent: function(transaction, hostParent, hostContainerInfo, context) {
    var tag = ReactNativeTagHandles.allocateTag();

    this._rootNodeID = tag;
    this._hostParent = hostParent;
    this._hostContainerInfo = hostContainerInfo;

    if (__DEV__) {
      for (var key in this.viewConfig.validAttributes) {
        if (this._currentElement.props.hasOwnProperty(key)) {
          deepFreezeAndThrowOnMutationInDev(this._currentElement.props[key]);
        }
      }
    }

    var updatePayload = ReactNativeAttributePayload.create(
      this._currentElement.props,
      this.viewConfig.validAttributes
    );

    var nativeTopRootTag = hostContainerInfo._tag;
    UIManager.createView(
      tag,
      this.viewConfig.uiViewClassName,
      nativeTopRootTag,
      updatePayload
    );

    ReactNativeComponentTree.precacheNode(this, tag);

    this._registerListenersUponCreation(this._currentElement.props);
    this.initializeChildren(
      this._currentElement.props.children,
      tag,
      transaction,
      context
    );
    return tag;
  },
};

/**
 * Order of mixins is important. ReactNativeBaseComponent overrides methods in
 * ReactMultiChild.
 */
Object.assign(
  ReactNativeBaseComponent.prototype,
  ReactMultiChild,
  ReactNativeBaseComponent.Mixin,
  NativeMethodsMixin
);

module.exports = ReactNativeBaseComponent;

1	/**
2	* Copyright (c) 2015-present, Facebook, Inc.
3	* All rights reserved.
4	*
5	* This source code is licensed under the BSD-style license found in the
6	* LICENSE file in the root directory of this source tree. An additional grant
7	* of patent rights can be found in the PATENTS file in the same directory.
8	*
9	* @providesModule ReactNativeBaseComponent
10	* @flow
11	*/
12	'use strict';	49✔
13
14	var NativeMethodsMixin = require('NativeMethodsMixin');	49✔
15	var ReactNativeAttributePayload = require('ReactNativeAttributePayload');	49✔
16	var ReactNativeComponentTree = require('ReactNativeComponentTree');	49✔
17	var ReactNativeEventEmitter = require('ReactNativeEventEmitter');	49✔
18	var ReactNativeTagHandles = require('ReactNativeTagHandles');	49✔
19	var ReactMultiChild = require('ReactMultiChild');	49✔
20	var UIManager = require('UIManager');	49✔
21
22	var deepFreezeAndThrowOnMutationInDev = require('deepFreezeAndThrowOnMutationInDev');	49✔
23
24	var registrationNames = ReactNativeEventEmitter.registrationNames;	49✔
25	var putListener = ReactNativeEventEmitter.putListener;	49✔
26	var deleteListener = ReactNativeEventEmitter.deleteListener;	49✔
27	var deleteAllListeners = ReactNativeEventEmitter.deleteAllListeners;	49✔
28
29	type ReactNativeBaseComponentViewConfig = {
30	validAttributes: Object;
31	uiViewClassName: string;
32	}
33
34	// require('UIManagerStatTracker').install(); // uncomment to enable
35
36	/**
37	* @constructor ReactNativeBaseComponent
38	* @extends ReactComponent
39	* @extends ReactMultiChild
40	* @param {!object} UIKit View Configuration.
41	*/
42	var ReactNativeBaseComponent = function(	49✔
43	viewConfig: ReactNativeBaseComponentViewConfig
44	) {
45	this.viewConfig = viewConfig;	145✔
46	};
47
48	/**
49	* Mixin for containers that contain UIViews. NOTE: markup is rendered markup
50	* which is a `viewID` ... see the return value for `mountComponent` !
51	*/
52	ReactNativeBaseComponent.Mixin = {	49✔
53	getPublicInstance: function() {
54	// TODO: This should probably use a composite wrapper
55	return this;	9✔
56	},
57
58	unmountComponent: function(safely, skipLifecycle) {
59	ReactNativeComponentTree.uncacheNode(this);	222✔
60	deleteAllListeners(this);	222✔
61	this.unmountChildren(safely, skipLifecycle);	222✔
62	this._rootNodeID = 0;	222✔
63	},
64
65	/**
66	* Every native component is responsible for allocating its own `tag`, and
67	* issuing the native `createView` command. But it is not responsible for
68	* recording the fact that its own `rootNodeID` is associated with a
69	* `nodeHandle`. Only the code that actually adds its `nodeHandle` (`tag`) as
70	* a child of a container can confidently record that in
71	* `ReactNativeTagHandles`.
72	*/
73	initializeChildren: function(children, containerTag, transaction, context) {
74	var mountImages = this.mountChildren(children, transaction, context);	226✔
75	// In a well balanced tree, half of the nodes are in the bottom row and have
76	// no children - let's avoid calling out to the native bridge for a large
77	// portion of the children.
78	if (mountImages.length) {	226✔
79
80	// TODO: Pool these per platform view class. Reusing the `mountImages`
81	// array would likely be a jit deopt.
82	var createdTags = [];	94✔
83	for (var i = 0, l = mountImages.length; i < l; i++) {	94✔
84	var mountImage = mountImages[i];	142✔
85	var childTag = mountImage;	142✔
86	createdTags[i] = childTag;	142✔
87	}
88	UIManager.setChildren(containerTag, createdTags);	94✔
89	}
90	},
91
92	/**
93	* Updates the component's currently mounted representation.
94	*
95	* @param {object} nextElement
96	* @param {ReactReconcileTransaction} transaction
97	* @param {object} context
98	* @internal
99	*/
100	receiveComponent: function(nextElement, transaction, context) {
101	var prevElement = this._currentElement;	26✔
102	this._currentElement = nextElement;	26✔
103
104	if (__DEV__) {	26✔
105	for (var key in this.viewConfig.validAttributes) {	26✔
106	if (nextElement.props.hasOwnProperty(key)) {	1✔
107	deepFreezeAndThrowOnMutationInDev(nextElement.props[key]);	1✔
108	}
109	}
110	}
111
112	var updatePayload = ReactNativeAttributePayload.diff(	26✔
113	prevElement.props,
114	nextElement.props,
115	this.viewConfig.validAttributes
116	);
117
118	if (updatePayload) {	26✔
119	UIManager.updateView(	1✔
120	this._rootNodeID,
121	this.viewConfig.uiViewClassName,
122	updatePayload
123	);
124	}
125
126	this._reconcileListenersUponUpdate(	26✔
127	prevElement.props,
128	nextElement.props
129	);
130	this.updateChildren(nextElement.props.children, transaction, context);	26✔
131	},
132
133	/**
134	* @param {object} initialProps Native component props.
135	*/
136	_registerListenersUponCreation: function(initialProps) {
137	for (var key in initialProps) {	226✔
138	// NOTE: The check for `!props[key]`, is only possible because this method
139	// registers listeners the first time a component is created.
140	if (registrationNames[key] && initialProps[key]) {	251✔
141	var listener = initialProps[key];	8✔
142	putListener(this, key, listener);	8✔
143	}
144	}
145	},
146
147	/**
148	* Reconciles event listeners, adding or removing if necessary.
149	* @param {object} prevProps Native component props including events.
150	* @param {object} nextProps Next native component props including events.
151	*/
152	_reconcileListenersUponUpdate: function(prevProps, nextProps) {
153	for (var key in nextProps) {	26✔
154	if (registrationNames[key] && (nextProps[key] !== prevProps[key])) {	20✔
155	if (nextProps[key]) {	×
156	putListener(this, key, nextProps[key]);	×
157	} else {
158	deleteListener(this, key);	×
159	}
160	}
161	}
162	},
163
164	/**
165	* Currently this still uses IDs for reconciliation so this can return null.
166	*
167	* @return {null} Null.
168	*/
169	getHostNode: function() {
170	return this._rootNodeID;	34✔
171	},
172
173	/**
174	* @param {ReactNativeReconcileTransaction} transaction
175	* @param {?ReactNativeBaseComponent} the parent component instance
176	* @param {?object} info about the host container
177	* @param {object} context
178	* @return {string} Unique iOS view tag.
179	*/
180	mountComponent: function(transaction, hostParent, hostContainerInfo, context) {
181	var tag = ReactNativeTagHandles.allocateTag();	226✔
182
183	this._rootNodeID = tag;	226✔
184	this._hostParent = hostParent;	226✔
185	this._hostContainerInfo = hostContainerInfo;	226✔
186
187	if (__DEV__) {	226✔
188	for (var key in this.viewConfig.validAttributes) {	226✔
189	if (this._currentElement.props.hasOwnProperty(key)) {	5✔
190	deepFreezeAndThrowOnMutationInDev(this._currentElement.props[key]);	5✔
191	}
192	}
193	}
194
195	var updatePayload = ReactNativeAttributePayload.create(	226✔
196	this._currentElement.props,
197	this.viewConfig.validAttributes
198	);
199
200	var nativeTopRootTag = hostContainerInfo._tag;	226✔
201	UIManager.createView(	226✔
202	tag,
203	this.viewConfig.uiViewClassName,
204	nativeTopRootTag,
205	updatePayload
206	);
207
208	ReactNativeComponentTree.precacheNode(this, tag);	226✔
209
210	this._registerListenersUponCreation(this._currentElement.props);	226✔
211	this.initializeChildren(	226✔
212	this._currentElement.props.children,
213	tag,
214	transaction,
215	context
216	);
217	return tag;	226✔
218	},
219	};
220
221	/**
222	* Order of mixins is important. ReactNativeBaseComponent overrides methods in
223	* ReactMultiChild.
224	*/
225	Object.assign(	49✔
226	ReactNativeBaseComponent.prototype,
227	ReactMultiChild,
228	ReactNativeBaseComponent.Mixin,
229	NativeMethodsMixin
230	);
231
232	module.exports = ReactNativeBaseComponent;	49✔

facebook / react / 14134

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous