jmcarp / robobrowser / 80

pending completion

Build # 80

Build Type

Pull #56

travis-ci

Committed by

web-flow

Commit Message

If Button tag has no type, assume the type of it is 'submit'.

According to <https://developer.mozilla.org/nl/docs/Web/HTML/Element/button>:

+ The type of the button. Possible values are:
    + submit: The button submits the form data to the server.
        + This is the default if the attribute is not specified, or if the attribute is dynamically changed to an empty or invalid value.
    + reset: The button resets all the controls to their initial values.
    + button: The button has no default behavior. It can have client-side scripts associated with the element's events, which are triggered when the events occur.
    + menu: The button opens a popup menu defined via its designated <menu> element.

So, we can treat the button tag with no type specifed as a submit tag.

Thanks Vincent Wagelaar <vincent@iterator.nl> for emailing about this
patch.

Pull Request Pull Request #56: Fix button in form issue

Run Details

8 of 8 new or added lines in 2 files covered. (100.0%)

481 of 521 relevant lines covered (92.32%)

3.6 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.29

/robobrowser/compat.py

Build SHA Not Found

The commit SHA "5854e17d4a788044c36eef3ba4d2ba5ff43f3434" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

jmcarp / robobrowser / 80

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous