halostatue / minitar / 46

pending completion

Build # 46

Build Type

Pull #18

travis-ci

Committed by

web-flow

Commit Message

No unnecessary strings on POSIX header creation

The POSIX header creation methods created a new 512-byte string of NULL
bytes just to see if the header was an empty header. This could be simplified
with a single 512-byte constant string for comparison, but a short-circuiting
comparison will be more efficient over-all. Use the #each_byte enumerator with
the #any? test method on #nonzero? (data.each_byte.any?(&:nonzero?)).

This commit tests the behaviour, but is probably not compatible with Ruby 1.8
versions.

Pull Request Pull Request #18: No unnecessary strings on POSIX header creation

Run Details

7 of 7 new or added lines in 2 files covered. (100.0%)

713 of 896 relevant lines covered (79.58%)

189.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

34.91

/lib/archive/tar/minitar.rb

Build SHA Not Found

The commit SHA "07b10d8485a23b75fffa8c38cae54fc53066195a" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

halostatue / minitar / 46

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous