1682

pending completion

Build # 1682

Build Type

Pull #629

travis-ci

Committed by

web-flow

Commit Message

Apply first round of PR feedback

* Change `sort-order` option to `sort`
* Rename `alphabetical` function to `isAlphabetized`
* Change `isAlphabetized` to include equality comparison, to handle duplicate imports
* Add test cases to verify alphabetical sort is applied correctly to duplicate imports
* Simplify `isAlphabetized` with guard clause
* Make explicit comparison for `array.length === 0`
* Have a single check of `sort` option before triggering `makeOutOfAlphabeticalOrderReport`, do not pass as parameter

Pull Request Pull Request #629: Allow secondary alphabetical sorting

Run Details

17 of 17 new or added lines in 2 files covered. (100.0%)

1673 of 1762 relevant lines covered (94.95%)

253.53 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

99.14

/src/rules/order.js

Build SHA Not Found

The commit SHA "2b8d4dc135c0d5e4d32eaf1c67a7aba2dc1f2649" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

benmosher / eslint-plugin-import / 1682

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous