13545

pending completion

Build # 13545

Build Type

Pull #8015

travis-ci

Committed by

web-flow

Commit Message

Add more life-cycles to Fiber

This refactors the initialization process so that we can share
it with the "module pattern" initialization.

There are a few new interesting scenarios unlocked by this.
E.g. constructor -> componentWillMount -> shouldComponentUpdate
-> componentDidMount when a render is aborted and resumed.
If shouldComponentUpdate returns true then we create a new
instance instead of trying componentWillMount again or
componentWillReceiveProps without being mounted.

Another strange thing is that the "previous props and state"
during componentWillReceiveProps, shouldComponentUpdate and
componentWillUpdate are all the previous render attempt. However,
componentDidMount's previous is the props/state at the previous
commit. That is because the first three can execute multiple
times before a didMount.

Pull Request Pull Request #8015: [Fiber] Add more life-cycles

Run Details

79 of 79 new or added lines in 3 files covered. (100.0%)

7944 of 9075 relevant lines covered (87.54%)

3156.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.02

/src/renderers/shared/fiber/ReactFiberClassComponent.js

Build SHA Not Found

The commit SHA "b4eddd734c3d2430f1bffa77eb3b8301db9c5158" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

facebook / react / 13545

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous