• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

temporalio / sdk-java / #427

16 Nov 2026 04:17PM UTC coverage: 71.787% (+0.1%) from 71.675%
#427

push

github

web-flow
Provide the namespace to storage drivers (#3203)

8613 of 14069 branches covered (61.22%)

Branch coverage included in aggregate %.

13 of 22 new or added lines in 12 files covered. (59.09%)

140 existing lines in 13 files now uncovered.

34118 of 45456 relevant lines covered (75.06%)

0.75 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.93
/temporal-sdk/src/main/java/io/temporal/internal/activity/ActivityTaskHandlerImpl.java
1
package io.temporal.internal.activity;
2

3
import com.google.common.base.Joiner;
4
import com.google.common.collect.ImmutableSet;
5
import com.uber.m3.tally.Scope;
6
import com.uber.m3.util.ImmutableMap;
7
import io.temporal.activity.DynamicActivity;
8
import io.temporal.api.failure.v1.Failure;
9
import io.temporal.api.workflowservice.v1.PollActivityTaskQueueResponseOrBuilder;
10
import io.temporal.api.workflowservice.v1.RespondActivityTaskCanceledRequest;
11
import io.temporal.api.workflowservice.v1.RespondActivityTaskFailedRequest;
12
import io.temporal.client.ActivityCanceledException;
13
import io.temporal.common.context.ContextPropagator;
14
import io.temporal.common.converter.DataConverter;
15
import io.temporal.common.interceptors.WorkerInterceptor;
16
import io.temporal.common.metadata.POJOActivityImplMetadata;
17
import io.temporal.common.metadata.POJOActivityMethodMetadata;
18
import io.temporal.internal.activity.ActivityTaskExecutors.ActivityTaskExecutor;
19
import io.temporal.internal.common.FailureUtils;
20
import io.temporal.internal.common.env.ReflectionUtils;
21
import io.temporal.internal.worker.ActivityTask;
22
import io.temporal.internal.worker.ActivityTaskHandler;
23
import io.temporal.serviceclient.MetricsTag;
24
import io.temporal.worker.MetricsType;
25
import io.temporal.worker.TypeAlreadyRegisteredException;
26
import java.lang.reflect.Method;
27
import java.util.*;
28
import javax.annotation.Nonnull;
29
import javax.annotation.Nullable;
30

31
public final class ActivityTaskHandlerImpl implements ActivityTaskHandler {
32
  public static final ImmutableSet<String> ACTIVITY_HANDLER_STACKTRACE_CUTOFF =
1 ✔
33
      ImmutableSet.<String>builder()
1 ✔
34
          // POJO
35
          .add(
1 ✔
36
              ReflectionUtils.getMethodNameForStackTraceCutoff(
1 ✔
37
                  ActivityTaskExecutors.POJOActivityImplementation.class,
38
                  "execute",
39
                  ActivityInfoInternal.class,
40
                  Scope.class))
41
          // Dynamic
42
          .add(
1 ✔
43
              ReflectionUtils.getMethodNameForStackTraceCutoff(
1 ✔
44
                  ActivityTaskExecutors.DynamicActivityImplementation.class,
45
                  "execute",
46
                  ActivityInfoInternal.class,
47
                  Scope.class))
48
          .build();
1 ✔
49

50
  private final DataConverter dataConverter;
51
  private final String namespace;
52
  private final String taskQueue;
53
  private final ActivityExecutionContextFactory executionContextFactory;
54
  // <ActivityType, Implementation>
55
  private final Map<String, ActivityTaskExecutor> activities =
1 ✔
56
      Collections.synchronizedMap(new HashMap<>());
1 ✔
57
  private ActivityTaskExecutor dynamicActivity;
58
  private final WorkerInterceptor[] interceptors;
59
  private final List<ContextPropagator> contextPropagators;
60

61
  public ActivityTaskHandlerImpl(
62
      @Nonnull String namespace,
63
      @Nonnull String taskQueue,
64
      @Nonnull DataConverter dataConverter,
65
      @Nonnull ActivityExecutionContextFactory executionContextFactory,
66
      @Nonnull WorkerInterceptor[] interceptors,
67
      @Nullable List<ContextPropagator> contextPropagators) {
1 ✔
68
    this.namespace = Objects.requireNonNull(namespace);
1 ✔
69
    this.taskQueue = Objects.requireNonNull(taskQueue);
1 ✔
70
    this.dataConverter = Objects.requireNonNull(dataConverter);
1 ✔
71
    this.executionContextFactory = Objects.requireNonNull(executionContextFactory);
1 ✔
72
    this.interceptors = Objects.requireNonNull(interceptors);
1 ✔
73
    this.contextPropagators = contextPropagators;
1 ✔
74
  }
1 ✔
75

76
  @Override
77
  public boolean isAnyTypeSupported() {
78
    return !activities.isEmpty() || dynamicActivity != null;
1 ✔
79
  }
80

81
  @Override
82
  public boolean isTypeSupported(String type) {
83
    return activities.get(type) != null || dynamicActivity != null;
1 ✔
84
  }
85

86
  public boolean requestCancel(byte[] taskToken) {
87
    return executionContextFactory.cleanupContext(taskToken, true);
×
88
  }
89

90
  public void registerActivityImplementations(Object[] activitiesImplementation) {
91
    for (Object activity : activitiesImplementation) {
1 ✔
92
      registerActivityImplementation(activity);
1 ✔
93
    }
94
  }
1 ✔
95

96
  @Override
97
  public Result handle(ActivityTask activityTask, Scope metricsScope, boolean localActivity) {
98
    PollActivityTaskQueueResponseOrBuilder pollResponse = activityTask.getResponse();
1 ✔
99
    String activityType = pollResponse.getActivityType().getName();
1 ✔
100
    ActivityInfoInternal activityInfo =
1 ✔
101
        new ActivityInfoImpl(
102
            pollResponse,
103
            this.namespace,
104
            this.taskQueue,
105
            localActivity,
106
            activityTask.getCompletionCallback(),
1 ✔
107
            localActivity ? activityTask.getLocalActivityArguments() : null);
1 ✔
108
    ActivityTaskExecutor activity = activities.get(activityType);
1 ✔
109
    if (activity != null) {
1 ✔
110
      return activity.execute(activityInfo, metricsScope);
1 ✔
111
    }
112
    if (dynamicActivity != null) {
1 !
113
      return dynamicActivity.execute(activityInfo, metricsScope);
1 ✔
114
    }
115

116
    // unregistered activity
117
    try {
118
      String knownTypes = Joiner.on(", ").join(activities.keySet());
×
UNCOV
119
      throw new IllegalArgumentException(
×
120
          "Activity Type \""
121
              + activityType
122
              + "\" is not registered with a worker. Known types are: "
123
              + knownTypes);
124
    } catch (Exception exception) {
×
UNCOV
125
      return mapToActivityFailure(
×
126
          exception,
UNCOV
127
          pollResponse.getActivityId(),
×
128
          null,
129
          metricsScope,
130
          localActivity,
131
          dataConverter);
132
    }
133
  }
134

135
  private void registerActivityImplementation(Object activity) {
136
    if (activity instanceof Class) {
1 !
UNCOV
137
      throw new IllegalArgumentException("Activity object instance expected, not the class");
×
138
    }
139
    if (activity instanceof DynamicActivity) {
1 ✔
140
      if (dynamicActivity != null) {
1 !
UNCOV
141
        throw new TypeAlreadyRegisteredException(
×
142
            "DynamicActivity",
143
            "An implementation of DynamicActivity is already registered with the worker");
144
      }
145
      dynamicActivity =
1 ✔
146
          new ActivityTaskExecutors.DynamicActivityImplementation(
147
              (DynamicActivity) activity,
148
              dataConverter,
149
              contextPropagators,
150
              interceptors,
151
              executionContextFactory);
152
    } else {
153
      Class<?> cls = activity.getClass();
1 ✔
154
      POJOActivityImplMetadata activityImplMetadata = POJOActivityImplMetadata.newInstance(cls);
1 ✔
155
      for (POJOActivityMethodMetadata activityMetadata :
156
          activityImplMetadata.getActivityMethods()) {
1 ✔
157
        String typeName = activityMetadata.getActivityTypeName();
1 ✔
158
        if (activities.containsKey(typeName)) {
1 ✔
159
          throw new TypeAlreadyRegisteredException(
1 ✔
160
              typeName, "\"" + typeName + "\" activity type is already registered with the worker");
161
        }
162
        Method method = activityMetadata.getMethod();
1 ✔
163
        ActivityTaskExecutor implementation =
1 ✔
164
            new ActivityTaskExecutors.POJOActivityImplementation(
165
                method,
166
                activity,
167
                dataConverter,
168
                contextPropagators,
169
                interceptors,
170
                executionContextFactory);
171
        activities.put(typeName, implementation);
1 ✔
172
      }
1 ✔
173
    }
174
  }
1 ✔
175

176
  @SuppressWarnings("deprecation")
177
  static ActivityTaskHandler.Result mapToActivityFailure(
178
      Throwable exception,
179
      String activityId,
180
      @Nullable Object lastHeartbeatDetails,
181
      Scope metricsScope,
182
      boolean isLocalActivity,
183
      DataConverter dataConverter) {
184
    if (exception instanceof ActivityCanceledException) {
1 ✔
185
      if (isLocalActivity) {
1 !
186
        metricsScope.counter(MetricsType.LOCAL_ACTIVITY_EXEC_CANCELLED_COUNTER).inc(1);
×
UNCOV
187
        metricsScope.counter(MetricsType.LOCAL_ACTIVITY_CANCELED_COUNTER).inc(1);
×
188
      } else {
189
        metricsScope.counter(MetricsType.ACTIVITY_EXEC_CANCELLED_COUNTER).inc(1);
1 ✔
190
        metricsScope.counter(MetricsType.ACTIVITY_CANCELED_COUNTER).inc(1);
1 ✔
191
      }
192
      return new ActivityTaskHandler.Result(
1 ✔
193
          activityId, null, null, RespondActivityTaskCanceledRequest.newBuilder().build(), false);
1 ✔
194
    }
195
    Scope ms =
1 ✔
196
        metricsScope.tagged(
1 ✔
197
            ImmutableMap.of(MetricsTag.EXCEPTION, exception.getClass().getSimpleName()));
1 ✔
198
    if (!FailureUtils.isBenignApplicationFailure(exception)) {
1 ✔
199
      // The deprecated counter keeps its original tags so that dashboards still reading it are
200
      // not split into a new series.
201
      Scope failureScope =
1 ✔
202
          ms.tagged(
1 ✔
203
              ImmutableMap.of(
1 ✔
204
                  MetricsTag.TASK_FAILURE_TYPE, MetricsTag.TASK_FAILURE_VALUE_ACTIVITY_ERROR));
205
      if (isLocalActivity) {
1 ✔
206
        failureScope.counter(MetricsType.LOCAL_ACTIVITY_EXEC_FAILED_COUNTER).inc(1);
1 ✔
207
        ms.counter(MetricsType.LOCAL_ACTIVITY_FAILED_COUNTER).inc(1);
1 ✔
208
      } else {
209
        failureScope.counter(MetricsType.ACTIVITY_EXEC_FAILED_COUNTER).inc(1);
1 ✔
210
      }
211
    }
212
    Failure failure = dataConverter.exceptionToFailure(exception);
1 ✔
213
    RespondActivityTaskFailedRequest.Builder result =
214
        RespondActivityTaskFailedRequest.newBuilder().setFailure(failure);
1 ✔
215
    if (lastHeartbeatDetails != null) {
1 ✔
216
      dataConverter.toPayloads(lastHeartbeatDetails).ifPresent(result::setLastHeartbeatDetails);
1 ✔
217
    }
218
    return new ActivityTaskHandler.Result(
1 ✔
219
        activityId,
220
        null,
221
        new ActivityTaskHandler.Result.TaskFailedResult(result.build(), exception),
1 ✔
222
        null,
223
        false);
224
  }
225
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc