IQSS / dataverse / #30915

Pull #12801

github

Some extra fixes and refactoring, a combined commit.
 - removed the remaining filemetadatas from the permissions logic; extended check for the best available filemetadata to use; left a comment for potential further refactoring (per conversation with Jim);
 - switched to using the name of the external tool for the eventtype of the GBR in all cases;
 - cleaned up and expanded the test FilesIT#testDownloadFileWithGuestbookResponseViaExternalTool to validate the output of /toolUrl and /toolparams;
 - (slightly) rearranged/refactored the logic inside /api/access/datafile for recording file downloads w/ guestbooks from within external tools. #12760

13 of 124 new or added lines in 13 files covered. (10.48%)

24649 of 96030 relevant lines covered (25.67%)

0.26 hits per line