13263

pending completion

Build # 13263

Build Type

Pull #7707

travis-ci

Committed by

web-flow

Commit Message

Fix resuming bug

If we abort work but have some completed, we can bail out if
the shouldComponentUpdate returns true. However, then we have
a tree that is low priority. When we bailout we currently use
the "current" tree in this case. I don't think this is right.
I'm not sure why I did that.

Similarly, when we complete we use the "current" props if we
didn't have pending props to do. However, we should be using
the memoized props of that tree if it is a pending work tree.

Added a unit test that covers these two cases.

Pull Request Pull Request #7707: [WIP][Fiber] Child Reconciliation, Refs and Life-Cycles

Run Details

571 of 571 new or added lines in 11 files covered. (100.0%)

7876 of 8990 relevant lines covered (87.61%)

3132.43 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

55.56

/src/renderers/shared/fiber/ReactReifiedYield.js

Build SHA Not Found

The commit SHA "f4c90bc78f5164da2d93f6cd611e833c16748f6b" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

facebook / react / 13263

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous