paulmillr / chokidar / 595

pending completion

Build # 595

Build Type

Pull #539

travis-ci

Committed by

web-flow

Commit Message

Improve ignore paths globifying

Ensures that if only a directory's basename is provided (without the preceeding path, just `dirname`), it prefixes `**/`

Currently when only a directory name is provided, it adds a postfix `/**` which is great for matching the entire tree ***if*** the tree is a *child* of the dir.  So `path` (converted to `path/**`) can filter paths like `path/to/file.js`, **but** if `path` is actually only a directory's basename it fails to match `/some/path/to/file.js`. This can be solved by prefixing `**/path`

Really helpful when only "node_modules" is provided as ignore path (like in `.gitignore` file) and it's actually some level deeper than current dir.

Also adjust the postfix to add just `**` instead of `/**` based on if last char is already a `/`

Pull Request Pull Request #539: Improve ignore paths globifying

Run Details

36 of 36 new or added lines in 2 files covered. (100.0%)

1760 of 1945 relevant lines covered (90.49%)

377.09 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

13.86

/lib/fsevents-handler.js

Build SHA Not Found

The commit SHA "f0a1af7614b2ac18e5ed8e44aabe976088706870" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

paulmillr / chokidar / 595

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous