37965809739

Committed 09 Oct 2026 05:22PM UTC coverage: 48.076% (-0.5%) from 48.588%

Build # 37965809739

Build Type

push

github

Committed by

jcelerier

Commit Message

3rdparty: pin avendish to main, now that #219 is merged

celtera/avendish#219 merged as 797b3c9d7e, so the ColorDisplay fix this
branch needs is on main and the pin no longer has to name
fix/color-display-unit-aliases. Pinned to main's tip a1f6471c53, which
also picks up #220.

Content is unchanged where it matters: the tree at the old pin and at
797b3c9d7e is byte-identical (`git diff` reports no files), and #220 on
top touches one line -- a Catch2 tag inside `if(BUILD_TESTING)` in
cmake/avendish.tests.cmake -- which score never evaluates.

Note `git cherry` is useless for checking this: #219 was squash-merged, so
its 7 commits collapsed into 1 and no patch-id matches. Compare trees, not
commits. A pin on a feature branch dies when that branch is tidied up,
which is why this matters beyond neatness.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019QYyvhRXvSMSRQPaq12Teq

Coverage Stats

156491 of 325507 relevant lines covered (48.08%)

146731.39 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/plugins/score-plugin-protocols/Protocols/OSCQuery/OSCQueryProtocolSettingsWidget.cpp

// This is an open source non-commercial project. Dear PVS-Studio, please check
// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
#include "OSCQueryProtocolSettingsWidget.hpp"

#include "OSCQueryProtocolFactory.hpp"
#include "OSCQuerySpecificSettings.hpp"

#include <State/Widgets/AddressFragmentLineEdit.hpp>

#include <Device/Protocol/ProtocolSettingsWidget.hpp>

#include <Protocols/RateWidget.hpp>

#include <score/widgets/HelpInteraction.hpp>
#include <score/widgets/Pixmap.hpp>

#include <QAction>
#include <QFormLayout>
#include <QJsonDocument>
#include <QJsonObject>
#include <QLabel>
#include <QLineEdit>
#include <QNetworkReply>
#include <QPushButton>
#include <QString>
#include <QVariant>
namespace Protocols
{
OSCQueryProtocolSettingsWidget::OSCQueryProtocolSettingsWidget(QWidget* parent)
    : ProtocolSettingsWidget(parent)
{
  m_deviceNameEdit = new State::AddressFragmentLineEdit{this};
  checkForChanges(m_deviceNameEdit);

  m_localHostEdit = new QLineEdit(this);
  score::setHelp(
      m_localHostEdit, tr("The OSCQuery host. Example: ws://127.0.0.1:5678, "
                          "http://my.oscquery.host, ..."));
  m_rate = new RateWidget{this};
  score::setHelp(m_rate, tr("Rate limiting for outgoing messages"));
  m_localPort = new QSpinBox(this);
  m_localPort->setRange(0, 65535);
  m_localPort->setValue(0);
  score::setHelp(
      m_localPort,
      tr("Port score listens on for OSC feedback. 0 picks a random port."));
  checkForChanges(m_localPort);

  m_dense = new QCheckBox("Dense message packing", this);
  m_dense->setChecked(false);
  m_dense->setEnabled(false);
  score::setHelp(m_dense, tr("Whether the remote API supports dense packing of values"));

  QFormLayout* layout = new QFormLayout;

  layout->addRow(tr("Name"), m_deviceNameEdit);
  layout->addRow(tr("Host"), m_localHostEdit);
  layout->addRow(tr("Local port"), m_localPort);
  layout->addRow(tr("Rate"), m_rate);
  layout->addRow(new QLabel("Supported extensions: "));
  layout->addRow(m_dense);

  setLayout(layout);

  m_deviceNameEdit->setText("newDevice");
  m_localHostEdit->setText("ws://127.0.0.1:5678");
  m_rate->setRate({});
  m_localPort->setValue(0);
  m_dense->setChecked(false);
}

Device::DeviceSettings OSCQueryProtocolSettingsWidget::getSettings() const
{
  Device::DeviceSettings s;
  s.name = m_deviceNameEdit->text();
  s.protocol = OSCQueryProtocolFactory::static_concreteKey();

  OSCQuerySpecificSettings OSCQuery;
  OSCQuery.host = m_localHostEdit->text();
  OSCQuery.rate = m_rate->rate();
  OSCQuery.localPort = m_localPort->value();
  OSCQuery.dense = m_dense->isChecked();

  s.deviceSpecificSettings = QVariant::fromValue(OSCQuery);
  return s;
}

void OSCQueryProtocolSettingsWidget::setSettings(const Device::DeviceSettings& settings)
{
  m_deviceNameEdit->setText(settings.name);
  OSCQuerySpecificSettings OSCQuery;
  if(settings.deviceSpecificSettings.canConvert<OSCQuerySpecificSettings>())
  {
    OSCQuery = settings.deviceSpecificSettings.value<OSCQuerySpecificSettings>();
    m_localHostEdit->setText(OSCQuery.host);
    m_localPort->setValue(OSCQuery.localPort);
    m_rate->setRate(OSCQuery.rate);
    m_dense->setChecked(OSCQuery.dense);
  }
}
}

1	// This is an open source non-commercial project. Dear PVS-Studio, please check
2	// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
3	#include "OSCQueryProtocolSettingsWidget.hpp"
4
5	#include "OSCQueryProtocolFactory.hpp"
6	#include "OSCQuerySpecificSettings.hpp"
7
8	#include <State/Widgets/AddressFragmentLineEdit.hpp>
9
10	#include <Device/Protocol/ProtocolSettingsWidget.hpp>
11
12	#include <Protocols/RateWidget.hpp>
13
14	#include <score/widgets/HelpInteraction.hpp>
15	#include <score/widgets/Pixmap.hpp>
16
17	#include <QAction>
18	#include <QFormLayout>
19	#include <QJsonDocument>
20	#include <QJsonObject>
21	#include <QLabel>
22	#include <QLineEdit>
23	#include <QNetworkReply>
24	#include <QPushButton>
25	#include <QString>
26	#include <QVariant>
27	namespace Protocols
28	{
29	OSCQueryProtocolSettingsWidget::OSCQueryProtocolSettingsWidget(QWidget* parent)	×
30	: ProtocolSettingsWidget(parent)	×
31	{	×
32	m_deviceNameEdit = new State::AddressFragmentLineEdit{this};	×
33	checkForChanges(m_deviceNameEdit);	×
34
35	m_localHostEdit = new QLineEdit(this);	×
36	score::setHelp(	×
37	m_localHostEdit, tr("The OSCQuery host. Example: ws://127.0.0.1:5678, "	×
38	"http://my.oscquery.host, ..."));
39	m_rate = new RateWidget{this};	×
40	score::setHelp(m_rate, tr("Rate limiting for outgoing messages"));	×
41	m_localPort = new QSpinBox(this);	×
42	m_localPort->setRange(0, 65535);	×
43	m_localPort->setValue(0);	×
44	score::setHelp(	×
45	m_localPort,	×
46	tr("Port score listens on for OSC feedback. 0 picks a random port."));	×
47	checkForChanges(m_localPort);	×
48
49	m_dense = new QCheckBox("Dense message packing", this);	×
50	m_dense->setChecked(false);	×
51	m_dense->setEnabled(false);	×
52	score::setHelp(m_dense, tr("Whether the remote API supports dense packing of values"));	×
53
54	QFormLayout* layout = new QFormLayout;	×
55
56	layout->addRow(tr("Name"), m_deviceNameEdit);	×
57	layout->addRow(tr("Host"), m_localHostEdit);	×
58	layout->addRow(tr("Local port"), m_localPort);	×
59	layout->addRow(tr("Rate"), m_rate);	×
60	layout->addRow(new QLabel("Supported extensions: "));	×
61	layout->addRow(m_dense);	×
62
63	setLayout(layout);	×
64
65	m_deviceNameEdit->setText("newDevice");	×
66	m_localHostEdit->setText("ws://127.0.0.1:5678");	×
67	m_rate->setRate({});	×
68	m_localPort->setValue(0);	×
69	m_dense->setChecked(false);	×
70	}	×
71
72	Device::DeviceSettings OSCQueryProtocolSettingsWidget::getSettings() const	×
73	{
74	Device::DeviceSettings s;	×
75	s.name = m_deviceNameEdit->text();	×
76	s.protocol = OSCQueryProtocolFactory::static_concreteKey();	×
77
78	OSCQuerySpecificSettings OSCQuery;	×
79	OSCQuery.host = m_localHostEdit->text();	×
80	OSCQuery.rate = m_rate->rate();	×
81	OSCQuery.localPort = m_localPort->value();	×
82	OSCQuery.dense = m_dense->isChecked();	×
83
84	s.deviceSpecificSettings = QVariant::fromValue(OSCQuery);	×
85	return s;	×
86	}	×
87
88	void OSCQueryProtocolSettingsWidget::setSettings(const Device::DeviceSettings& settings)	×
89	{
90	m_deviceNameEdit->setText(settings.name);	×
91	OSCQuerySpecificSettings OSCQuery;	×
92	if(settings.deviceSpecificSettings.canConvert<OSCQuerySpecificSettings>())	×
93	{
94	OSCQuery = settings.deviceSpecificSettings.value<OSCQuerySpecificSettings>();	×
95	m_localHostEdit->setText(OSCQuery.host);	×
96	m_localPort->setValue(OSCQuery.localPort);	×
97	m_rate->setRate(OSCQuery.rate);	×
98	m_dense->setChecked(OSCQuery.dense);	×
99	}	×
100	}	×
101	}

ossia / score / 37965809739

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous