35789245541

Committed 22 Sep 2026 09:52PM UTC coverage: 40.05%. First build

Build # 35789245541

Build Type

push

github

Committed by

ahongbynder

Commit Message

API-2971: fix socket timeout and OOM on large file uploads

- Thread HttpConnectionSettings through the Amazon S3 upload client
  (ApiFactory, AmazonS3Service/Impl, FileUploader, AssetService/Impl,
  BynderClientImpl) so upload timeouts are configurable instead of
  silently defaulting to OkHttp's hardcoded 10s connect/read/write
  timeouts, which caused SocketTimeoutException on large file uploads.
- Fix RXUtils.mapWithIndex to pair chunks with their index via a lazy
  map instead of zipWith(Observable.range(...)), which greedily drained
  the entire file into memory before any chunk was uploaded, causing an
  OutOfMemoryError on multi-gigabyte files.
- Switch FileUploader's chunk upload from flatMapSingle to
  concatMapSingle to process chunks strictly one at a time.
- Update HttpConnectionSettingsTest to match the new default timeout.
- Update OAuthClientCredentialsSample with the fixed timeout config and
  an additional uploadFile() example.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

17 of 45 new or added lines in 9 files covered. (37.78%)

805 of 2010 relevant lines covered (40.05%)

0.4 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/main/java/com/bynder/sdk/sample/OAuthClientCredentialsSample.java

package com.bynder.sdk.sample;

import com.bynder.sdk.configuration.Configuration;
import com.bynder.sdk.configuration.HttpConnectionSettings;
import com.bynder.sdk.configuration.OAuthSettings;
import com.bynder.sdk.model.Brand;
import com.bynder.sdk.model.Media;
import com.bynder.sdk.model.MediaType;
import com.bynder.sdk.model.upload.SaveMediaResponse;
import com.bynder.sdk.model.upload.UploadProgress;
import com.bynder.sdk.query.MediaQuery;
import com.bynder.sdk.query.OrderBy;
import com.bynder.sdk.query.upload.UploadQuery;
import com.bynder.sdk.service.BynderClient;
import com.bynder.sdk.service.asset.AssetService;
import com.bynder.sdk.service.oauth.OAuthService;
import com.bynder.sdk.util.Utils;
import io.reactivex.Observable;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.io.IOException;
import java.net.URISyntaxException;
import java.net.URL;
import java.util.Arrays;
import java.util.List;
import java.util.Properties;

public class OAuthClientCredentialsSample {
    private static final Logger LOG = LoggerFactory.getLogger(MediaSample.class);

    public static void main(final String[] args) throws IOException, URISyntaxException {
        /**
         * Loads app.properties file under src/main/resources
         */
        Properties appProperties = Utils.loadConfig("app");

        // Initialize BynderClient with OAuth
        String baseUrl = appProperties.getProperty("BASE_URL");
        OAuthSettings oAuthSettings = new OAuthSettings(appProperties.getProperty("CLIENT_ID"), appProperties.getProperty("CLIENT_SECRET"), null);
        BynderClient client = BynderClient.Builder.create(
                new Configuration.Builder(new URL(baseUrl))
                        .setOAuthSettings(oAuthSettings)
                        .setHttpConnectionSettings(new HttpConnectionSettings(
                                null, null, null,
                                120, 120, true)).build());
        List<String> scopes = Arrays.asList("offline", "asset:read", "asset:write", "asset.usage:read",
                "asset.usage:write", "collection:read", "collection:write", "meta.assetbank:read",
                "meta.assetbank:write", "meta.workflow:read");

        // Initialize OAuthService
        OAuthService oauthService = client.getOAuthService();

        // use client credentials
        oauthService.getAccessTokenClientCredentials(scopes).blockingSingle();

        // Initialize asset service
        AssetService assetService = client.getAssetService();

//        // Call the API to request for brands
//        List<Brand> brands = assetService.getBrands().blockingSingle().body();
//        if (brands != null && !brands.isEmpty()) {
//            for (Brand brand : brands) {
//                LOG.info("Brand ID: " + brand.getId());
//                LOG.info("Brand Name: " + brand.getName());
//                LOG.info("Brand Description: " + brand.getDescription());
//            }
//        }
//
//        // Call the API to request for media assets
//        MediaQuery mediaQuery =  new MediaQuery().setType(MediaType.IMAGE).setOrderBy(OrderBy.NAME_DESC).setLimit(10).setPage(1);
//        List<Media> mediaList = assetService.getMediaList(mediaQuery).blockingSingle().body();
//        if (mediaList != null && !mediaList.isEmpty()) {
//            for (Media media : mediaList) {
//                LOG.info("Media ID: " + media.getId());
//                LOG.info("Media Name: " + media.getName());
//            }
//        }


        // Upload a file
        // Call the API to request for brands
        String brandId = "";
        List<Brand> brands = assetService.getBrands().blockingSingle().body();
        if (brands != null && !brands.isEmpty()) {
            brandId = brands.get(0).getId();
        }

//        String filePath = "src/main/java/com/bynder/sdk/sample/over 5gb.mov";
//        LOG.info(filePath);
//        UploadQuery uploadQuery = new UploadQuery(filePath, brandId);
//        // Add the filename you want to specify in this manner
//        uploadQuery.setFileName("5gb.mov");
//        Observable<UploadProgress> uploadProgress = assetService.uploadFileWithProgress(uploadQuery);
//
//        uploadProgress.subscribe(uploadProgress1 -> {
//            LOG.info("Uploaded chunks: " + uploadProgress1.getUploadedChunks());
//            LOG.info("Transmitted bytes: " + uploadProgress1.getTransmittedBytes());
//            LOG.info("Total bytes: " + uploadProgress1.getTotalBytes());
//
//            if (uploadProgress1.getTransmittedBytes() == uploadProgress1.getTotalBytes()) {
//                LOG.info("Upload finished");
//            }
//        }, throwable -> {
//            LOG.error("Error uploading file", throwable);
//        });

        // Upload a file without progress reporting: the returned Observable emits a single
        // SaveMediaResponse once the upload, chunk registration, finalisation and media save
        // have all completed.
        String secondFilePath = "src/main/java/com/bynder/sdk/sample/GG_K16SPR4BTS_Bubble132.tif";
        UploadQuery secondUploadQuery = new UploadQuery(secondFilePath, brandId);
        secondUploadQuery.setFileName("GG_K16SPR4BTS_Bubble132.tif");

        LOG.info("Uploading: " + secondFilePath);

        SaveMediaResponse saveMediaResponse = assetService.uploadFile(secondUploadQuery).blockingSingle();
        if (saveMediaResponse.getSuccess()) {
            LOG.info("Upload finished successfully.");
            LOG.info("Media ID: " + saveMediaResponse.getMediaId());
            LOG.info("Portal: " + baseUrl);
        } else {
            LOG.error("Upload failed.");
        }

        System.exit(0);
    }
}

1	package com.bynder.sdk.sample;
2
3	import com.bynder.sdk.configuration.Configuration;
4	import com.bynder.sdk.configuration.HttpConnectionSettings;
5	import com.bynder.sdk.configuration.OAuthSettings;
6	import com.bynder.sdk.model.Brand;
7	import com.bynder.sdk.model.Media;
8	import com.bynder.sdk.model.MediaType;
9	import com.bynder.sdk.model.upload.SaveMediaResponse;
10	import com.bynder.sdk.model.upload.UploadProgress;
11	import com.bynder.sdk.query.MediaQuery;
12	import com.bynder.sdk.query.OrderBy;
13	import com.bynder.sdk.query.upload.UploadQuery;
14	import com.bynder.sdk.service.BynderClient;
15	import com.bynder.sdk.service.asset.AssetService;
16	import com.bynder.sdk.service.oauth.OAuthService;
17	import com.bynder.sdk.util.Utils;
18	import io.reactivex.Observable;
19	import org.slf4j.Logger;
20	import org.slf4j.LoggerFactory;
21	import java.io.IOException;
22	import java.net.URISyntaxException;
23	import java.net.URL;
24	import java.util.Arrays;
25	import java.util.List;
26	import java.util.Properties;
27
28	public class OAuthClientCredentialsSample {	×
29	private static final Logger LOG = LoggerFactory.getLogger(MediaSample.class);	×
30
31	public static void main(final String[] args) throws IOException, URISyntaxException {
32	/**
33	* Loads app.properties file under src/main/resources
34	*/
35	Properties appProperties = Utils.loadConfig("app");	×
36
37	// Initialize BynderClient with OAuth
NEW 38	String baseUrl = appProperties.getProperty("BASE_URL");	×
39	OAuthSettings oAuthSettings = new OAuthSettings(appProperties.getProperty("CLIENT_ID"), appProperties.getProperty("CLIENT_SECRET"), null);	×
40	BynderClient client = BynderClient.Builder.create(	×
41	new Configuration.Builder(new URL(baseUrl))
42	.setOAuthSettings(oAuthSettings)	×
NEW 43	.setHttpConnectionSettings(new HttpConnectionSettings(	×
44	null, null, null,
NEW 45	120, 120, true)).build());	×
46	List<String> scopes = Arrays.asList("offline", "asset:read", "asset:write", "asset.usage:read",	×
47	"asset.usage:write", "collection:read", "collection:write", "meta.assetbank:read",
48	"meta.assetbank:write", "meta.workflow:read");
49
50	// Initialize OAuthService
51	OAuthService oauthService = client.getOAuthService();	×
52
53	// use client credentials
54	oauthService.getAccessTokenClientCredentials(scopes).blockingSingle();	×
55
56	// Initialize asset service
57	AssetService assetService = client.getAssetService();	×
58
59	// // Call the API to request for brands
60	// List<Brand> brands = assetService.getBrands().blockingSingle().body();
61	// if (brands != null && !brands.isEmpty()) {
62	// for (Brand brand : brands) {
63	// LOG.info("Brand ID: " + brand.getId());
64	// LOG.info("Brand Name: " + brand.getName());
65	// LOG.info("Brand Description: " + brand.getDescription());
66	// }
67	// }
68	//
69	// // Call the API to request for media assets
70	// MediaQuery mediaQuery = new MediaQuery().setType(MediaType.IMAGE).setOrderBy(OrderBy.NAME_DESC).setLimit(10).setPage(1);
71	// List<Media> mediaList = assetService.getMediaList(mediaQuery).blockingSingle().body();
72	// if (mediaList != null && !mediaList.isEmpty()) {
73	// for (Media media : mediaList) {
74	// LOG.info("Media ID: " + media.getId());
75	// LOG.info("Media Name: " + media.getName());
76	// }
77	// }
78
79
80	// Upload a file
81	// Call the API to request for brands
NEW 82	String brandId = "";	×
83	List<Brand> brands = assetService.getBrands().blockingSingle().body();	×
84	if (brands != null && !brands.isEmpty()) {	×
NEW 85	brandId = brands.get(0).getId();	×
86	}
87
88	// String filePath = "src/main/java/com/bynder/sdk/sample/over 5gb.mov";
89	// LOG.info(filePath);
90	// UploadQuery uploadQuery = new UploadQuery(filePath, brandId);
91	// // Add the filename you want to specify in this manner
92	// uploadQuery.setFileName("5gb.mov");
93	// Observable<UploadProgress> uploadProgress = assetService.uploadFileWithProgress(uploadQuery);
94	//
95	// uploadProgress.subscribe(uploadProgress1 -> {
96	// LOG.info("Uploaded chunks: " + uploadProgress1.getUploadedChunks());
97	// LOG.info("Transmitted bytes: " + uploadProgress1.getTransmittedBytes());
98	// LOG.info("Total bytes: " + uploadProgress1.getTotalBytes());
99	//
100	// if (uploadProgress1.getTransmittedBytes() == uploadProgress1.getTotalBytes()) {
101	// LOG.info("Upload finished");
102	// }
103	// }, throwable -> {
104	// LOG.error("Error uploading file", throwable);
105	// });
106
107	// Upload a file without progress reporting: the returned Observable emits a single
108	// SaveMediaResponse once the upload, chunk registration, finalisation and media save
109	// have all completed.
NEW 110	String secondFilePath = "src/main/java/com/bynder/sdk/sample/GG_K16SPR4BTS_Bubble132.tif";	×
NEW 111	UploadQuery secondUploadQuery = new UploadQuery(secondFilePath, brandId);	×
NEW 112	secondUploadQuery.setFileName("GG_K16SPR4BTS_Bubble132.tif");	×
113
NEW 114	LOG.info("Uploading: " + secondFilePath);	×
115
NEW 116	SaveMediaResponse saveMediaResponse = assetService.uploadFile(secondUploadQuery).blockingSingle();	×
NEW 117	if (saveMediaResponse.getSuccess()) {	×
NEW 118	LOG.info("Upload finished successfully.");	×
NEW 119	LOG.info("Media ID: " + saveMediaResponse.getMediaId());	×
NEW 120	LOG.info("Portal: " + baseUrl);	×
121	} else {
NEW 122	LOG.error("Upload failed.");	×
123	}
124
125	System.exit(0);	×
126	}	×
127	}

Bynder / bynder-java-sdk / 35789245541

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous