konradmichalik / typo3-file-sync / 32383467378

push

github

fix: guard against closed response body in RemoteInstanceResource (#40)

* fix: guard against closed response body in RemoteInstanceResource

* test: cover remote file fetching against a real HTTP server

* fix: retry test server bind on port allocation race

Releasing the discovered port before binding the built-in PHP server left a window where another process could claim it, causing sporadic skips on CI.

* chore(deps): allow phpstan-typo3-preset ^0.4

0.3.x requires both rector/type-perfect and an unconstrained tomasvotruba/type-coverage, which register the same PHPStan service twice and break static analysis. 0.4.0 caps type-coverage to avoid the collision.

* fix: resolve strict PHPStan rule violations from ergebnis/phpstan-rules

Narrow visibility to private where methods are only used internally, replace
error suppression on unlink() with an explicit is_file() guard, drop a named
argument in favor of positional, and remove a constructor default that no
caller relies on. The two remaining violations (a dynamically resolved handler
class passed to GeneralUtility::makeInstance(), and the resulting optional
constructor parameter needed for that instantiation contract) are baselined
since fixing them would require changing the public resource handler API.

13 of 18 new or added lines in 5 files covered. (72.22%)

677 of 777 relevant lines covered (87.13%)

3.89 hits per line