cheeriojs / cheerio / 30668946525

Pull #5388

github

fix(website): address review feedback

- Restore the post slug in the blog index links. A perl substitution
  interpolated `${post.id}` as a shell variable, leaving both links
  pointing at `/blog//`. The link check missed it because path joining
  normalises the double slash away, so a dead link resolved to the
  index; it now rejects malformed hrefs before resolving them.

- Fix the ESLint failures blocking CI: drop the unneeded shebang, set
  `process.exitCode` from a single catch instead of calling
  `process.exit()` mid-script, convert consecutive line comments to
  block comments, and sort the package scripts.

- Declare `mdast-util-to-string`, which was being resolved through a
  transitive dependency.

- Compare the read-back configuration with sorted keys. Algolia is free
  to return nested objects in any key order, which the previous
  stringify comparison would have reported as drift, failing the sync
  job every run even when nothing had changed.

- Time out the crawler API calls so an unresponsive endpoint fails the
  job rather than hanging it.

- Split the query string off before appending a trailing slash, so
  `/docs/page?tab=api` no longer becomes `/docs/page?tab=api/`.

- Point the sync script's header at the sync-crawler job in site.yml.

265 of 265 branches covered (100.0%)

Branch coverage included in aggregate %.

872 of 877 relevant lines covered (99.43%)

378.88 hits per line