AfterShip / clickhouse-sql-parser / 30455578247

Build # 30455578247

Build Type

Pull #290

github

Committed by therealpandey

Commit Message

Support SQL-standard keyword arguments for trim, substring and overlay (#289)

ClickHouse accepts `trim(BOTH ' ' FROM s)`, `substring(s FROM 2 FOR 3)` and
`overlay(s PLACING r FROM 2 FOR 3)`, but the parser only split arguments on
commas, so it rejected all of them.

Recognise the keyword form from a per-function table listing the leading
modifiers, the separator keywords in order, and how many are mandatory. The
form is decided after the first argument, as parseColumnExtractExpr already
does for EXTRACT, so comma arguments and `both`/`placing`/`overlay` as column
names keep working.

Each separator becomes a BinaryOperation and the trim modifier a UnaryExpr, so
no new AST node is needed and traversal and formatting are unchanged.

Grammar verified against ClickHouse 26.8.1.337 in both directions: the forms it
rejects — a missing trim modifier, a missing FROM, out-of-order separators, and
substringUTF8, which has no keyword form unlike overlayUTF8 — stay rejected.

Pull Request Pull Request #290: Support SQL-standard keyword arguments for trim, substring and overlay

Coverage Stats

9015 of 16550 relevant lines covered (54.47%)

3061.06 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available