valkyrjaio / valkyrja-starter-app-java / 30423835214
coverage: 94.322% (-1.1%) from 95.409%
push
github
web-flow[CI] Stop uploading the sindri-junit JaCoCo report to Coveralls (#62) # Description This repo calls `_java-junit.yml` twice, and both jobs upload a JaCoCo report to Coveralls. Only one of them describes this app's test coverage. - **`junit`** copies the empty `*.example.java` stubs and tests the app — currently 95.16% line / 88.89% branch. This is the meaningful number. - **`sindri-junit`** runs Sindri and asserts the **generated** `App*Data` classes. It deliberately does not exercise controllers, commands or providers, but it compiles the whole app, so JaCoCo counts every one of them as missed. Its report reads **55.47% line / 11.11% branch**. Neither upload sets a Coveralls `flag-name` or any parallel/carryforward configuration, so the two reports land on the same Coveralls build and fight. The practical effect is that this repo's Coveralls number moves for reasons that have nothing to do with its tests: adding 18 HTTP routes and 14 CLI commands in #55 and #58 made the `sindri-junit` report substantially worse purely because there was more compiled-but-not-asserted-by-that-job code, and the reported coverage dropped accordingly. This turns the upload off for `sindri-junit` using the new `upload-coverage` input, leaving `junit` as the single source of coverage truth for the repo. Nothing about what either job *tests* changes — `sindri-junit` still runs Sindri and still asserts the generated data, which is its actual purpose. This is a reporting-accuracy fix, not coverage gating. Coverage runs and publishes a report and nothing fails on it, which is the intended state for now — which is precisely why a report that is wrong by construction is worth removing: the report is currently read by hand. valkyrjaio/.github#155 is merged but not yet released, so the `sindri-junit` job pins the merge commit (`2574d99d1`) directly rather than the release SHA the other jobs use. This is temporary by construction — the workflo... (continued)
20 of 22 branches covered (90.91%)
Branch coverage included in aggregate %.
279 of 295 relevant lines covered (94.58%)
4.65 hits per line
Source File
Press 'n' to go to next uncovered line, 'b' for previous
20.0
Source Not Available
The file "src/main/java/app/grpc/data/AppContainerData.java" isn't available on github. Either it's been removed, or the repo root directory needs to be updated.