stacklok / toolhive / 30374909430

Build # 30374909430

Build Type

push

github

Committed by web-flow

Commit Message

Deflake TestWorkflowEngine_ParallelExecution (#6112)

The test asserted maxConcurrent >= 2 to prove the two independent
level-1 steps run in parallel, but that counter only reaches 2 when the
two 50ms mock sleeps overlap in wall-clock time. On a loaded CI runner
the second goroutine can be starved and start only after the first
already finished, leaving maxConcurrent at 1 and failing the test
regardless of the diff under test. This flaked the unit-test job on
main (previously "deflaked" in #4333, which only reduced but did not
remove the timing dependence).

Replace the sleeps with a rendezvous barrier: each fetch step blocks on
entry until both have arrived, so neither can complete until the other
has started. This makes the concurrency assertion deterministic under
any scheduler load, and turns a genuine regression to sequential
execution into a clear timeout failure instead of a lucky pass.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

81792 of 117024 relevant lines covered (69.89%)

97.48 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available