stacklok / toolhive / 30268388184

Build # 30268388184

Build Type

push

github

Committed by web-flow

Commit Message

Make e2e workload readiness waits reliable (#6012)

* Make e2e workload readiness waits reliable

The group specs time out waiting for a freshly started workload to reach
the running state on loaded CI runners. Reaching running covers the
container start plus ToolHive's own initialize probe against the proxy,
which the product waits up to 5 minutes for, so a 60s spec-side budget
fails while the workload is still legitimately starting.

WaitForMCPServer also matched the name and the word running anywhere in
the list table, so it could return before the named workload was running,
and its timeout carried no diagnostics.

Separately, CI pre-pulled hardcoded image tags for servers the tests
reach by registry name. Renovate bumps toolhive-catalog daily but has no
manager for those docker pull lines, so fetch (1.0.2 vs 1.0.5) and time
(2026.1.26 vs 2026.7.10) had drifted and the pre-pull no longer covered
what the tests run. Resolve those tags from the binary under test.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Bound the readiness poll's thv list call

Run() applies TestConfig.TestTimeout (10 minutes), so a single hung
list could outlast the readiness budget it is polling for. Callers
poll, so an overrunning list is retried rather than fatal.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Share the workload lookup with the isolated-env wait

waitForIsolatedMCPServer was a copy of WaitForMCPServer's old body and
carried the same defect: it matched the name and the word running
anywhere in the list table. Export FindWorkload, which takes the command
builder so an isolated config/home/data spec can supply its own, and
have both waits read the named workload's own record.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Coverage Stats

80214 of 115339 relevant lines covered (69.55%)

83.72 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available