29625079075

Committed 18 Jul 2026 01:22AM UTC coverage: 44.717% (+23.2%) from 21.548%

Build # 29625079075

Build Type

Pull #19

github

Committed by

claude

Commit Message

Extract repeated message-assembly logic into MessageFormatter

Six exception classes duplicated the same "indent a sibling exception's
message and join under a bullet" idiom (InvalidItemException,
InvalidTupleException, InvalidAdditionalPropertiesException,
InvalidPatternPropertiesException, InvalidComposedValueException,
ConditionalException); two more had byte-for-byte identical logic for a
different case, flattening one arbitrary nested exception's whole message
into bullets one level deeper (NestedObjectException,
InvalidSchemaDependencyException); three more repeated a "quote each item
and join" idiom for flat lists (InvalidTypeException, AdditionalProperties-
Exception, InvalidPropertyDependencyException).

Renamed ValueFormatter to MessageFormatter and added bulletList(),
flattenNestedMessage() and quotedList() alongside the existing format(),
so every exception class assembling a message reaches for the same shared
helpers instead of re-implementing str_replace/implode/preg_replace calls.

Purely a refactor: every call site's exact output is unchanged (verified
via the full existing suite, no test assertions needed updating), plus new
MessageFormatterTest coverage for the extracted methods directly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BZUchCwdY9cQFvyEXWnTZw

Pull Request Pull Request #19: Fix nested composition indentation + add data-instance JSON pointer (issue #131)

Coverage Stats

101 of 138 new or added lines in 39 files covered. (73.19%)

2 existing lines in 2 files now uncovered.

364 of 814 relevant lines covered (44.72%)

1.8 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

73.33

/src/Exception/Object/NestedObjectException.php

<?php

declare(strict_types=1);

namespace PHPModelGenerator\Exception\Object;

use Exception;
use PHPModelGenerator\Exception\ErrorRegistryExceptionInterface;
use PHPModelGenerator\Exception\MessageFormatter;
use PHPModelGenerator\Exception\ValidationException;

/**
 * Class NotAllowedAdditionalPropertiesException
 *
 * @package PHPModelGenerator\Exception\Object
 */
class NestedObjectException extends ValidationException
{
    /**
     * NotAllowedAdditionalPropertiesException constructor.
     *
     * @param $providedValue
     */
    public function __construct(
        $providedValue,
        string $propertyName,
        string $jsonPointer,
        private readonly Exception $nestedException
    ) {
        if ($this->nestedException instanceof ErrorRegistryExceptionInterface) {
            foreach ($this->nestedException->getErrors() as $error) {
                $error->setInstancePointerParent($this);
            }
        } elseif ($this->nestedException instanceof ValidationException) {
            $this->nestedException->setInstancePointerParent($this);
        }

        parent::__construct(
            "Invalid nested object for property '$propertyName':\n  - " .
                MessageFormatter::flattenNestedMessage($this->nestedException->getMessage()),
            $propertyName,
            $providedValue,
            $jsonPointer
        );
    }

    public function getNestedException(): Exception
    {
        return $this->nestedException;
    }
}

1	<?php
2
3	declare(strict_types=1);
4
5	namespace PHPModelGenerator\Exception\Object;
6
7	use Exception;
8	use PHPModelGenerator\Exception\ErrorRegistryExceptionInterface;
9	use PHPModelGenerator\Exception\MessageFormatter;
10	use PHPModelGenerator\Exception\ValidationException;
11
12	/**
13	* Class NotAllowedAdditionalPropertiesException
14	*
15	* @package PHPModelGenerator\Exception\Object
16	*/
17	class NestedObjectException extends ValidationException
18	{
19	/**
20	* NotAllowedAdditionalPropertiesException constructor.
21	*
22	* @param $providedValue
23	*/
24	public function __construct(	2✔
25	$providedValue,
26	string $propertyName,
27	string $jsonPointer,
28	private readonly Exception $nestedException
29	) {
30	if ($this->nestedException instanceof ErrorRegistryExceptionInterface) {	2✔
NEW 31	foreach ($this->nestedException->getErrors() as $error) {	×
NEW 32	$error->setInstancePointerParent($this);	×
33	}
34	} elseif ($this->nestedException instanceof ValidationException) {	2✔
35	$this->nestedException->setInstancePointerParent($this);	2✔
36	}
37
38	parent::__construct(	2✔
39	"Invalid nested object for property '$propertyName':\n - " .	2✔
40	MessageFormatter::flattenNestedMessage($this->nestedException->getMessage()),	2✔
41	$propertyName,	2✔
42	$providedValue,	2✔
43	$jsonPointer	2✔
44	);	2✔
45	}
46
47	public function getNestedException(): Exception	×
48	{
49	return $this->nestedException;	×
50	}
51	}

wol-soft / php-json-schema-model-generator-production / 29625079075

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous