29625079075

Committed 18 Jul 2026 01:22AM UTC coverage: 44.717% (+23.2%) from 21.548%

Build # 29625079075

Build Type

Pull #19

github

Committed by

claude

Commit Message

Extract repeated message-assembly logic into MessageFormatter

Six exception classes duplicated the same "indent a sibling exception's
message and join under a bullet" idiom (InvalidItemException,
InvalidTupleException, InvalidAdditionalPropertiesException,
InvalidPatternPropertiesException, InvalidComposedValueException,
ConditionalException); two more had byte-for-byte identical logic for a
different case, flattening one arbitrary nested exception's whole message
into bullets one level deeper (NestedObjectException,
InvalidSchemaDependencyException); three more repeated a "quote each item
and join" idiom for flat lists (InvalidTypeException, AdditionalProperties-
Exception, InvalidPropertyDependencyException).

Renamed ValueFormatter to MessageFormatter and added bulletList(),
flattenNestedMessage() and quotedList() alongside the existing format(),
so every exception class assembling a message reaches for the same shared
helpers instead of re-implementing str_replace/implode/preg_replace calls.

Purely a refactor: every call site's exact output is unchanged (verified
via the full existing suite, no test assertions needed updating), plus new
MessageFormatterTest coverage for the extracted methods directly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BZUchCwdY9cQFvyEXWnTZw

Pull Request Pull Request #19: Fix nested composition indentation + add data-instance JSON pointer (issue #131)

Coverage Stats

101 of 138 new or added lines in 39 files covered. (73.19%)

2 existing lines in 2 files now uncovered.

364 of 814 relevant lines covered (44.72%)

1.8 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/Exception/Object/AdditionalPropertiesException.php

<?php

declare(strict_types=1);

namespace PHPModelGenerator\Exception\Object;

use PHPModelGenerator\Exception\MessageFormatter;
use PHPModelGenerator\Exception\ValidationException;

/**
 * Class NotAllowedAdditionalPropertiesException
 *
 * @package PHPModelGenerator\Exception\Object
 */
class AdditionalPropertiesException extends ValidationException
{
    /**
     * NotAllowedAdditionalPropertiesException constructor.
     *
     * @param $providedValue
     * @param string[] $additionalProperties
     */
    public function __construct(
        $providedValue,
        string $propertyName,
        string $jsonPointer,
        protected array $additionalProperties
    ) {
        parent::__construct(
            "Provided JSON for '$propertyName' contains not allowed additional properties [" .
                MessageFormatter::quotedList($this->additionalProperties) . ']',
            $propertyName,
            $providedValue,
            $jsonPointer
        );
    }

    /**
     * @return string[]
     */
    public function getAdditionalProperties(): array
    {
        return $this->additionalProperties;
    }
}

1	<?php
2
3	declare(strict_types=1);
4
5	namespace PHPModelGenerator\Exception\Object;
6
7	use PHPModelGenerator\Exception\MessageFormatter;
8	use PHPModelGenerator\Exception\ValidationException;
9
10	/**
11	* Class NotAllowedAdditionalPropertiesException
12	*
13	* @package PHPModelGenerator\Exception\Object
14	*/
15	class AdditionalPropertiesException extends ValidationException
16	{
17	/**
18	* NotAllowedAdditionalPropertiesException constructor.
19	*
20	* @param $providedValue
21	* @param string[] $additionalProperties
22	*/
23	public function __construct(	×
24	$providedValue,
25	string $propertyName,
26	string $jsonPointer,
27	protected array $additionalProperties
28	) {
29	parent::__construct(	×
NEW 30	"Provided JSON for '$propertyName' contains not allowed additional properties [" .	×
NEW 31	MessageFormatter::quotedList($this->additionalProperties) . ']',	×
32	$propertyName,	×
33	$providedValue,	×
34	$jsonPointer	×
35	);	×
36	}
37
38	/**
39	* @return string[]
40	*/
41	public function getAdditionalProperties(): array	×
42	{
43	return $this->additionalProperties;	×
44	}
45	}

wol-soft / php-json-schema-model-generator-production / 29625079075

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous