29625079075

Committed 18 Jul 2026 01:22AM UTC coverage: 44.717% (+23.2%) from 21.548%

Build # 29625079075

Build Type

Pull #19

github

Committed by

claude

Commit Message

Extract repeated message-assembly logic into MessageFormatter

Six exception classes duplicated the same "indent a sibling exception's
message and join under a bullet" idiom (InvalidItemException,
InvalidTupleException, InvalidAdditionalPropertiesException,
InvalidPatternPropertiesException, InvalidComposedValueException,
ConditionalException); two more had byte-for-byte identical logic for a
different case, flattening one arbitrary nested exception's whole message
into bullets one level deeper (NestedObjectException,
InvalidSchemaDependencyException); three more repeated a "quote each item
and join" idiom for flat lists (InvalidTypeException, AdditionalProperties-
Exception, InvalidPropertyDependencyException).

Renamed ValueFormatter to MessageFormatter and added bulletList(),
flattenNestedMessage() and quotedList() alongside the existing format(),
so every exception class assembling a message reaches for the same shared
helpers instead of re-implementing str_replace/implode/preg_replace calls.

Purely a refactor: every call site's exact output is unchanged (verified
via the full existing suite, no test assertions needed updating), plus new
MessageFormatterTest coverage for the extracted methods directly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BZUchCwdY9cQFvyEXWnTZw

Pull Request Pull Request #19: Fix nested composition indentation + add data-instance JSON pointer (issue #131)

Coverage Stats

101 of 138 new or added lines in 39 files covered. (73.19%)

2 existing lines in 2 files now uncovered.

364 of 814 relevant lines covered (44.72%)

1.8 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

81.25

/src/Exception/Generic/InvalidTypeException.php

<?php

declare(strict_types=1);

namespace PHPModelGenerator\Exception\Generic;

use PHPModelGenerator\Exception\MessageFormatter;
use PHPModelGenerator\Exception\ValidationException;

/**
 * Class InvalidTypeException
 *
 * @package PHPModelGenerator\Exception\Generic
 */
class InvalidTypeException extends ValidationException
{
    /**
     * PatternException constructor.
     *
     * @param $providedValue
     * @param array|string $expectedType
     */
    public function __construct($providedValue, string $propertyName, string $jsonPointer, protected $expectedType)
    {
        parent::__construct(
            sprintf(
                "Invalid type for '%s': requires %s, got '%s'",
                $propertyName,
                is_array($this->expectedType)
                    ? '[' . MessageFormatter::quotedList($this->expectedType) . ']'
                    : "'{$this->expectedType}'",
                is_object($providedValue) ? $providedValue::class : gettype($providedValue)
            ),
            $propertyName,
            $providedValue,
            $jsonPointer
        );
    }

    /**
     * @return array|string
     */
    public function getExpectedType()
    {
        return $this->expectedType;
    }
}

1	<?php
2
3	declare(strict_types=1);
4
5	namespace PHPModelGenerator\Exception\Generic;
6
7	use PHPModelGenerator\Exception\MessageFormatter;
8	use PHPModelGenerator\Exception\ValidationException;
9
10	/**
11	* Class InvalidTypeException
12	*
13	* @package PHPModelGenerator\Exception\Generic
14	*/
15	class InvalidTypeException extends ValidationException
16	{
17	/**
18	* PatternException constructor.
19	*
20	* @param $providedValue
21	* @param array\|string $expectedType
22	*/
23	public function __construct($providedValue, string $propertyName, string $jsonPointer, protected $expectedType)	6✔
24	{
25	parent::__construct(	6✔
26	sprintf(	6✔
27	"Invalid type for '%s': requires %s, got '%s'",	6✔
28	$propertyName,	6✔
29	is_array($this->expectedType)	6✔
NEW 30	? '[' . MessageFormatter::quotedList($this->expectedType) . ']'	×
31	: "'{$this->expectedType}'",	6✔
32	is_object($providedValue) ? $providedValue::class : gettype($providedValue)	6✔
33	),	6✔
34	$propertyName,	6✔
35	$providedValue,	6✔
36	$jsonPointer	6✔
37	);	6✔
38	}
39
40	/**
41	* @return array\|string
42	*/
43	public function getExpectedType()	×
44	{
45	return $this->expectedType;	×
46	}
47	}

wol-soft / php-json-schema-model-generator-production / 29625079075

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous