29401790967

Committed 15 Jul 2026 08:43AM UTC coverage: 75.604% (-0.002%) from 75.606%

Build # 29401790967

Build Type

push

github

Committed by

web-flow

Commit Message

Fix #12622 - Avoid issues for starting new project (#12648) (#12652)

* Fix #12622 - Avoid issues for starting new project

* Fixed migration guidelines

(cherry picked from commit ba6f54ef2)

Coverage Stats

35718 of 56456 branches covered (63.27%)

44496 of 58854 relevant lines covered (75.6%)

122.09 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

41.77

/web/client/utils/cesium/GeoJSONStyledFeatures.js

import * as Cesium from 'cesium';
import turfFlatten from '@turf/flatten';
import omit from 'lodash/omit';
import isArray from 'lodash/isArray';
import { v1 as uuid } from 'uuid';
import { getMapScaleForCesium } from '../MapUtils';
import { geoStylerScaleDenominatorFilter } from '../styleparser/StyleParserUtils';

/**
 * validate the coordinates and ensure:
 * - values inside are not nested arrays
 * - the current coordinate are not a duplication of the previous one
 * @param {number[]} coords array of coordinates [longitude, latitude, height]
 * @param {number[]} prevCoords array of coordinates [longitude, latitude, height]
 * @returns the coordinates if valid and null if invalid
 */
const validateCoordinatesValue = (coords, prevCoords) => {
    if (!isArray(coords[0]) && !isArray(coords[1]) && !isArray(coords[2])) {
        // remove duplicated points
        // to avoid normalization errors
        return prevCoords && (prevCoords[0] === coords[0] && prevCoords[1] === coords[1] && prevCoords[2] === coords[2])
            ? null
            : coords;
    }
    return null;
};

const featureToCartesianPositions = (feature) => {
    if (feature.geometry.type === 'Point') {
        const validatedCoords = validateCoordinatesValue([
            feature.geometry.coordinates[0],
            feature.geometry.coordinates[1],
            feature.geometry.coordinates[2] || 0
        ]);
        return validatedCoords ? [[Cesium.Cartesian3.fromDegrees(
            validatedCoords[0],
            validatedCoords[1],
            validatedCoords[2] || 0
        )]] : null;
    }
    if (feature.geometry.type === 'LineString') {
        const positions = feature.geometry.coordinates.map((coords, idx) =>
            validateCoordinatesValue(coords, feature.geometry.coordinates[idx - 1])
                ? Cesium.Cartesian3.fromDegrees(coords[0], coords[1], coords[2])
                : null
        ).filter(coords => coords !== null);
        return positions.length > 1 ? [positions] : null;
    }
    if (feature.geometry.type === 'Polygon') {
        const positions = feature.geometry.coordinates.map(ring => {
            const ringPositions = ring.map((coords, idx) =>
                validateCoordinatesValue(coords, ring[idx - 1])
                    ? Cesium.Cartesian3.fromDegrees(coords[0], coords[1], coords[2])
                    : null
            ).filter(coords => coords !== null);
            return ringPositions.length > 2 ? ringPositions : null;
        }).filter(ring => ring !== null);
        return positions.length > 0 ? positions : null;
    }
    return null;
};
/**
 * Class to manage styles for layer with an array of features
 * @param {string} options.id layer identifier
 * @param {object} options.map a Cesium map instance
 * @param {number} options.opacity opacity of the layer
 * @param {boolean} options.queryable if false the features will not be queryable, default is true
 * @param {array} options.features array of valid geojson features
 * @param {boolean} options.mergePolygonFeatures if true will merge all polygons with similar styles in a single primitive. This could help to reduce the draw call to the render
 * @param {func} featureFilter a function to filter feature, it receives a GeoJSON feature as argument and it must return a boolean
 */
class GeoJSONStyledFeatures {
    constructor(options = {}) {
        this._msId = options.id;
        this._dataSource = new Cesium.CustomDataSource(options.id);
        this._primitives = new Cesium.PrimitiveCollection({ destroyPrimitives: true });
        this._map = options.map;
        this._onCameraMoveEndBound = this._updateScaleVisibility.bind(this);
        if (this._map) {
            this._map.scene.primitives.add(this._primitives);
            this._map.dataSources.add(this._dataSource);
            this._map.camera.moveEnd.addEventListener(this._onCameraMoveEndBound);
        }
        this._styledFeatures = [];
        // Map<id, { id, entity }>: keyed lookups during _updateEntities are
        // O(1) instead of O(N) scans. Wrapper shape preserved so the rest of
        // the class (and _updatePointEntity, _updateScaleVisibility, etc.)
        // can keep accessing { id, entity } unchanged.
        this._entities = new Map();
        this._opacity = options.opacity ?? 1;
        this._queryable = options.queryable === undefined ? true : !!options.queryable;
        this._mergePolygonFeatures = !!options?.mergePolygonFeatures;
        this._featureFilter = options.featureFilter;
        this._dataSource.entities.collectionChanged.addEventListener(() => {
            setTimeout(() => this._map.scene.requestRender(), 300);
        });
        // internal key to associate features with original features
        this._uuidKey = '__ms_uuid_key__' + uuid();
        // Concurrency control for _runUpdate. Only one style/render cycle
        // runs at a time. Requests received while a cycle is in flight
        // collapse into a single pending rerun, kicked off when the current
        // cycle completes. This serializes apply order (so an older, smaller
        // styledFeatures snapshot can't arrive after a newer one and erase
        // entities the newer one added) and still picks up later additions
        // (so a slow style function during streaming doesn't strand features).
        this._runUpdateInFlight = false;
        this._runUpdatePending = null;
        // needs to be run after this._uuidKey
        this.setFeatures(options.features);
        this._styleRules = options?.styleRules;
    }
    _addCustomProperties(obj) {
        obj._msIsQueryable = () => this._queryable;
        obj._msGetFeatureById = (id) => {
            const _id = id instanceof Cesium.Entity ? id.id : id;
            const [featureId] = _id.split(':');
            const feature = this._features.find((f) => f.id === featureId);
            const originalFeature = this._originalFeatures.find((f) => f.properties[this._uuidKey] === feature.properties[this._uuidKey]) || {};
            const { properties } = originalFeature;
            return {
                feature: {
                    ...originalFeature,
                    properties: omit(properties, [this._uuidKey])
                },
                msId: this._msId
            };
        };
    }
    _getEntityOptions(primitive) {
        const { entity, geometry, orientation, minimumHeights, maximumHeights } = primitive;
        if (entity.polygon) {
            return {
                polygon: {
                    ...entity.polygon,
                    hierarchy: new Cesium.ConstantProperty(new Cesium.PolygonHierarchy(
                        geometry[0].map(cartesian => cartesian.clone()),
                        geometry
                            .filter((hole, idx) => idx > 0)
                            .map(hole => new Cesium.PolygonHierarchy(hole.map((cartesian) => cartesian.clone())))
                    ))
                }
            };
        }
        if (entity.wall) {
            return {
                wall: {
                    ...entity.wall,
                    positions: geometry[0],
                    minimumHeights: minimumHeights?.[0],
                    maximumHeights: maximumHeights?.[0]
                }
            };
        }
        if (entity.polyline) {
            return {
                polyline: {
                    ...entity.polyline,
                    positions: geometry[0]
                }
            };
        }
        if (entity.polylineVolume) {
            return {
                polylineVolume: {
                    ...entity.polylineVolume,
                    positions: geometry[0]
                }
            };
        }
        return {
            ...entity,
            ...(orientation && { orientation }),
            position: geometry
        };
    }
    _updatePointEntity(primitive, previous) {
        if (previous && (primitive.entity.billboard || primitive.entity.label || primitive.entity.model)) {
            const entity = previous.entity;
            if (primitive.orientation) {
                entity.orientation = primitive.orientation;
            }
            if (primitive.geometry) {
                entity.position = primitive.geometry.clone();
            }
            const graphicKey = Object.keys(primitive.entity)[0];
            // it's better to recreate the point entity in case height reference change
            if (entity?.[graphicKey]?.heightReference?.getValue() !== primitive?.entity?.[graphicKey]?.heightReference) {
                return null;
            }
            const propertyKeys = Object.keys(primitive.entity[graphicKey]);
            propertyKeys.forEach((propertyKey) => {
                entity[graphicKey][propertyKey] = primitive.entity[graphicKey][propertyKey];
            });
            return previous;
        }
        return null;
    }
    _filterEntities({ primitive }) {
        return (this._mergePolygonFeatures && primitive?.entity?.polygon) ? false : !!primitive.entity;
    }
    _updateEntities(newStyledFeatures, forceUpdate) {
        const previousEntities = this._styledFeatures.filter((feature) => this._filterEntities(feature));
        const entities = newStyledFeatures.filter((feature) => this._filterEntities(feature));
        const currentIdsSet = new Set();
        for (let i = 0; i < entities.length; i++) {
            currentIdsSet.add(entities[i].id);
        }
        // Do NOT wrap remove+add of same-id entities in suspendEvents: Cesium's
        // EntityCollection treats a queued remove followed by an add of the
        // same id as a net no-op (see add()/removeById() in EntityCollection.js
        // - both clear the opposite queue without populating their own).
        // The visualizer is then never notified, the new primitive is never
        // built, and the layer keeps rendering with the old style.
        for (let i = 0; i < previousEntities.length; i++) {
            const id = previousEntities[i].id;
            if (currentIdsSet.has(id)) {
                continue;
            }
            const entry = this._entities.get(id);
            if (entry) {
                this._dataSource.entities.remove(entry.entity);
            }
        }
        const newEntitiesMap = new Map();
        for (let i = 0; i < entities.length; i++) {
            const { id, action, primitive } = entities[i];
            const previous = this._entities.get(id);
            if (!forceUpdate && action === 'none') {
                if (previous) {
                    newEntitiesMap.set(id, previous);
                }
                continue;
            }
            const updatedPoint = this._updatePointEntity(primitive, previous);
            if (updatedPoint) {
                newEntitiesMap.set(id, updatedPoint);
                continue;
            }
            if (previous) {
                this._dataSource.entities.remove(previous.entity);
            }
            const entity = this._dataSource.entities.add({
                id,
                ...this._getEntityOptions(primitive)
            });
            this._addCustomProperties(entity);
            newEntitiesMap.set(id, { id, entity });
        }
        this._entities = newEntitiesMap;
    }
    _updatePolygonPrimitive(newStyledFeatures, forceUpdate) {
        const previousPolygonPrimitives = this._styledFeatures.filter(({ primitive }) => primitive.type === 'polygon' && !primitive.clampToGround);
        const polygonPrimitives = newStyledFeatures.filter(({ primitive }) => primitive.type === 'polygon' && !primitive.clampToGround);
        const polygonPrimitivesIds = new Set(polygonPrimitives.map(({ id }) => id));
        const removedPrimitives = previousPolygonPrimitives.filter(({ id }) => !polygonPrimitivesIds.has(id));
        const noActions = !removedPrimitives.length && polygonPrimitives.length ? polygonPrimitives.every(({ action }) => !forceUpdate && action === 'none') : false;
        if (noActions) {
            return;
        }
        if (this?._polygonPrimitives?.length) {
            this._polygonPrimitives.forEach((primitive) => {
                this._primitives.remove(primitive);
            });
            this._polygonPrimitives = [];
        }
        if (polygonPrimitives.length <= 0) {
            return;
        }
        const groupByTranslucencyAndExtrusion = polygonPrimitives.reduce((acc, options) => {
            const { primitive } = options;
            const { material, extrudedHeight } = primitive?.entity?.polygon || {};
            const key = `t:${material.alpha === 1},e:${extrudedHeight !== undefined ? 'true' : 'false'}`;
            return {
                ...acc,
                [key]: [...(acc[key] || []), options]
            };
        }, {});
        this._polygonPrimitives = Object.keys(groupByTranslucencyAndExtrusion).map((key) => {
            const styledFeatures = groupByTranslucencyAndExtrusion[key];
            const cesiumPrimitive = new Cesium.Primitive({
                geometryInstances: styledFeatures.map(({ primitive, id }) => {
                    const polygon = primitive?.entity?.polygon || {};
                    return new Cesium.GeometryInstance({
                        geometry: new Cesium.PolygonGeometry({
                            polygonHierarchy: new Cesium.PolygonHierarchy(
                                primitive.geometry[0].map(cartesian => cartesian.clone()),
                                primitive.geometry
                                    .filter((hole, idx) => idx > 0)
                                    .map(hole => new Cesium.PolygonHierarchy(hole.map((cartesian) => cartesian.clone())))
                            ),
                            arcType: polygon.arcType,
                            perPositionHeight: polygon.height !== undefined ? false : polygon.perPositionHeight,
                            ...(polygon.height !== undefined && { height: polygon.height }),
                            ...(polygon.extrudedHeight !== undefined && { extrudedHeight: polygon.extrudedHeight }),
                            vertexFormat: Cesium.VertexFormat.POSITION_AND_NORMAL
                        }),
                        id,
                        attributes: {
                            color: new Cesium.ColorGeometryInstanceAttribute(
                                polygon.material.red,
                                polygon.material.green,
                                polygon.material.blue,
                                polygon.material.alpha
                            ),
                            // allow to click on multiple instances
                            show: new Cesium.ShowGeometryInstanceAttribute(true)
                        }
                    });
                }),
                appearance: new Cesium.PerInstanceColorAppearance({
                    flat: styledFeatures[0].primitive?.entity?.polygon?.extrudedHeight === undefined,
                    translucent: styledFeatures[0].primitive?.entity?.polygon?.material?.alpha !== 1
                }),
                asynchronous: true
            });
            this._addCustomProperties(cesiumPrimitive);
            return cesiumPrimitive;
        });
        this._polygonPrimitives.forEach((primitive) => {
            this._primitives.add(primitive);
        });
    }
    _updateGroundPolygonPrimitive(newStyledFeatures, forceUpdate) {
        const previousGroundPolygonPrimitives = this._styledFeatures.filter(({ primitive }) => primitive.type === 'polygon' && !!primitive.clampToGround);
        const groundPolygonPrimitives = newStyledFeatures.filter(({ primitive }) => primitive.type === 'polygon' && !!primitive.clampToGround);
        const groundPolygonPrimitivesIds = new Set(groundPolygonPrimitives.map(({ id }) => id));
        const removedPrimitives = previousGroundPolygonPrimitives.filter(({ id }) => !groundPolygonPrimitivesIds.has(id));
        const noActions = !removedPrimitives.length && groundPolygonPrimitives.length ? groundPolygonPrimitives.every(({ action }) => !forceUpdate && action === 'none') : false;
        if (noActions) {
            return;
        }
        if (this?._groundPolygonPrimitives?.length) {
            this._groundPolygonPrimitives.forEach((primitive) => {
                this._primitives.remove(primitive);
            });
            this._groundPolygonPrimitives = [];
        }
        if (groundPolygonPrimitives.length <= 0) {
            return;
        }
        const groupByColorAndClassification = groundPolygonPrimitives.reduce((acc, options) => {
            const { primitive } = options;
            const { material, classificationType } = primitive?.entity?.polygon || {};
            const key = `r:${material.red},g:${material.green},b:${material.blue},a:${material.alpha},c:${classificationType}`;
            return {
                ...acc,
                [key]: [...(acc[key] || []), options]
            };
        }, {});

        this._groundPolygonPrimitives = Object.keys(groupByColorAndClassification).map((key) => {
            const styledFeatures = groupByColorAndClassification[key];
            const cesiumPrimitive = new Cesium.GroundPrimitive({
                classificationType: styledFeatures[0].primitive?.entity?.polygon?.classificationType,
                geometryInstances: styledFeatures.map(({ primitive, id }) => {
                    const polygon = primitive?.entity?.polygon || {};
                    return new Cesium.GeometryInstance({
                        geometry: new Cesium.PolygonGeometry({
                            polygonHierarchy: new Cesium.PolygonHierarchy(
                                primitive.geometry[0].map(cartesian => cartesian.clone()),
                                primitive.geometry
                                    .filter((hole, idx) => idx > 0)
                                    .map(hole => new Cesium.PolygonHierarchy(hole.map((cartesian) => cartesian.clone())))
                            ),
                            arcType: polygon.arcType,
                            perPositionHeight: polygon.perPositionHeight
                        }),
                        id,
                        attributes: {
                            color: new Cesium.ColorGeometryInstanceAttribute(
                                polygon.material.red,
                                polygon.material.green,
                                polygon.material.blue,
                                polygon.material.alpha
                            ),
                            // allow to click on multiple instances
                            show: new Cesium.ShowGeometryInstanceAttribute(true)
                        }
                    });
                }),
                appearance: new Cesium.PerInstanceColorAppearance({
                    flat: true,
                    translucent: styledFeatures[0].primitive?.entity?.polygon?.material?.alpha !== 1
                }),
                asynchronous: true
            });

            this._addCustomProperties(cesiumPrimitive);
            return cesiumPrimitive;
        });

        this._groundPolygonPrimitives.forEach((primitive) => {
            this._primitives.add(primitive);
        });
    }
    _runUpdate(forceUpdate) {
        if (!this._styleFunction) {
            return;
        }
        // If a cycle is already running, queue exactly one rerun. Multiple
        // requests during the same in-flight window collapse together; the
        // rerun, when it fires, will reflect whatever state (features, style,
        // filter, opacity) is current at that point.
        if (this._runUpdateInFlight) {
            this._runUpdatePending = {
                forceUpdate: !!(this._runUpdatePending?.forceUpdate || forceUpdate)
            };
            return;
        }
        this._runUpdateInFlight = true;
        // Build an id-keyed lookup once per cycle so getPreviousStyledFeature
        // is O(1) per call instead of an Array.find over the entire previous
        // styled set. For large layers (where the style function calls this
        // for every feature) the prior O(N) per call multiplied to O(N²) per
        // cycle, the dominant cost during streaming.
        const previousStyledById = new Map();
        for (let i = 0; i < this._styledFeatures.length; i++) {
            const sf = this._styledFeatures[i];
            previousStyledById.set(sf.id, sf);
        }
        this._styleFunction({
            map: this._map,
            opacity: this._opacity,
            features: this._featureFilter ? this._features.filter(this._featureFilter) : this._features,
            getPreviousStyledFeature: (styledFeature) => previousStyledById.get(styledFeature.id)
        })
            .then((styledFeatures) => {
                this._updateEntities(styledFeatures, forceUpdate);
                if (this._mergePolygonFeatures) {
                    this._updatePolygonPrimitive(styledFeatures, forceUpdate);
                    this._updateGroundPolygonPrimitive(styledFeatures, forceUpdate);
                }
                this._styledFeatures = [...styledFeatures];
                this._updateScaleVisibility();
                setTimeout(() => this._map.scene.requestRender());
            })
            .finally(() => {
                this._runUpdateInFlight = false;
                if (this._runUpdatePending) {
                    const pending = this._runUpdatePending;
                    this._runUpdatePending = null;
                    this._runUpdate(pending.forceUpdate);
                }
            });
    }
    _update(forceUpdate) {
        if (this._timeout) {
            clearTimeout(this._timeout);
        }
        this._timeout = setTimeout(() => {
            this._timeout = undefined;
            this._runUpdate(forceUpdate);
        }, 300);
    }
    /**
     * Run any pending debounced _update synchronously. Used by the streaming
     * load path to force a render mid-load instead of waiting for the 300ms
     * debounce to fire after the last batch.
     */
    flushPendingUpdate(forceUpdate) {
        if (this._timeout) {
            clearTimeout(this._timeout);
            this._timeout = undefined;
        }
        this._runUpdate(forceUpdate);
    }
    setFeatures(newFeatures) {
        this._originalFeatures = (newFeatures ?? []).map((feature) => {
            return {
                ...feature,
                properties: {
                    ...feature.properties,
                    [this._uuidKey]: feature?.properties?.[this._uuidKey] ?? uuid()
                }
            };
        });
        const { features } = turfFlatten({ type: 'FeatureCollection', features: this._originalFeatures });
        this._features = features.filter(feature => feature.geometry)
            .map((feature) => {
                return {
                    ...feature,
                    id: uuid(),
                    positions: featureToCartesianPositions(feature)
                };
            }).filter(feature => feature.positions !== null);

    }
    /**
     * Append features without rebuilding existing ones. Existing entities and
     * positions are preserved; only the new batch is transformed and added.
     * Triggers a debounced _update; callers that need a synchronous render can
     * follow up with flushPendingUpdate().
     */
    addFeatures(newFeatures) {
        if (!newFeatures || newFeatures.length === 0) {
            return;
        }
        const newOriginal = newFeatures.map((feature) => ({
            ...feature,
            properties: {
                ...feature.properties,
                [this._uuidKey]: feature?.properties?.[this._uuidKey] ?? uuid()
            }
        }));
        // In-place push avoids the O(N) re-allocation that array spread incurs
        // every batch; for 30k features streamed in 200-feature batches the
        // spread version is O(N²) cumulative.
        for (let i = 0; i < newOriginal.length; i++) {
            this._originalFeatures.push(newOriginal[i]);
        }
        const { features } = turfFlatten({ type: 'FeatureCollection', features: newOriginal });
        for (let i = 0; i < features.length; i++) {
            const feature = features[i];
            if (!feature.geometry) {
                continue;
            }
            const positions = featureToCartesianPositions(feature);
            if (positions === null) {
                continue;
            }
            this._features.push({
                ...feature,
                id: uuid(),
                positions
            });
        }
        this._update();
    }
    setOpacity(opacity) {
        const previousOpacity = this._opacity;
        this._opacity = opacity;
        this._update(previousOpacity !== opacity);
    }
    setStyleFunction(styleFunction) {
        this._styleFunction = styleFunction;
        this._update();
    }
    setFeatureFilter(featureFilter) {
        this._featureFilter = featureFilter;
        this._update();
    }
    _updateScaleVisibility() {
        if (!this._map) return;
        const currentMapScale = getMapScaleForCesium(this._map);
        this._entities.forEach(wrapper => {
            const { entity} = wrapper;
            // If no custom rules → apply default visibility
            if (!this._styleRules || this._styleRules.length === 0) {
                entity.show = true; // Keep visible
                return;
            }
            const validRules = this._styleRules.filter(rule =>
                geoStylerScaleDenominatorFilter(rule, currentMapScale)
            );
            entity.show = validRules.length > 0;
        });
        this._map.scene.requestRender();
    }
    _setStyleRules(rules) {
        this._styleRules = rules;
    }
    destroy() {
        this._primitives.removeAll();
        this._map.scene.primitives.remove(this._primitives);
        this._dataSource.entities.removeAll();
        this._map.dataSources.remove(this._dataSource);
        this._map.camera.moveEnd.removeEventListener(this._onCameraMoveEndBound);
    }
}

GeoJSONStyledFeatures.featureToCartesianPositions = featureToCartesianPositions;

export default GeoJSONStyledFeatures;

geosolutions-it / MapStore2 / 29401790967

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous