kubeflow / mcp-server / 29187740074

Build # 29187740074

Build Type

push

github

Committed by web-flow

Commit Message

feat: add OpenTelemetry tracing for tool calls (#21)

* feat: add OpenTelemetry tracing for tool calls

Signed-off-by: priyank <priyank8445@gmail.com>

* fix: address telemetry review feedback

Signed-off-by: priyank <priyank8445@gmail.com>

* fix(telemetry): address review — SpanKind.CLIENT, set_status(ERROR), hoist tracer, noop kwargs

- Use SpanKind.CLIENT for tool spans (K8s API = external service)

- Replace manual record_exception() with set_status(Status(StatusCode.ERROR)) to avoid duplicate events and improve Jaeger trace visibility

- Move get_tracer() to _audit_wrap scope (once per tool, not per call)

- Add **kwargs and set_status() to _NoopTracer/_NoopSpan for API compatibility

Signed-off-by: priyank <priyank8445@gmail.com>

* fix: use standard OTEL_EXPORTER_OTLP_ENDPOINT env var

Replace custom KUBEFLOW_MCP_OTEL_ENDPOINT with the official OpenTelemetry env var across README, CLI help text, and config loader.

Signed-off-by: priyank <priyank8445@gmail.com>

* fix: address review — atexit shutdown, args preview, endpoint normalization, circuit breaker test

- Register atexit.shutdown on TracerProvider to flush in-flight spans

- Add tool.args_preview span attribute with masked kwargs (truncated to 300 chars)

- Auto-append /v1/traces for base URLs to match OTel SDK convention

- Add test for circuit breaker open path (tool.success=False)

- Document kubeflow-mcp-agent as separate Jaeger service

Signed-off-by: priyank <priyank8445@gmail.com>

* feat(telemetry): align OpenTelemetry tracing with MCP semantic conventions

Signed-off-by: priyank <priyank8445@gmail.com>

* fix(telemetry): address review — middleware ContextVars, export timeouts, env var fallback, service rename

Signed-off-by: priyank <priyank8445@gmail.com>

---------

Signed-off-by: priyank <priyank8445@gmail.com>

Coverage Stats

987 of 2437 relevant lines covered (40.5%)

1.22 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available