#5612

Committed 11 Jul 2026 03:47PM UTC coverage: 71.292% (-28.7%) from 100.0%

Build # #5612

Build Type

push

github

Committed by

ben-manes

Commit Message

Preserve timestamps on a raced same-instance refresh

The automatic refreshIfNeeded path checked for an equal-value reload
before the ABA/ownership check and returned without preserving the
timestamps, so a reload completing after a concurrent put(k,
sameInstance) did a full update — shifting the entry's expiration
forward by the reload's in-flight duration and stomping the write.
Mirror the explicit-refresh fix: check ownership first. An owned
reload installs the value (refreshing metadata even for a same
instance), while a raced reload preserves the write's timestamps and
only notifies REPLACED when the value differs.

Coverage Stats

2957 of 4134 branches covered (71.53%)

3 of 3 new or added lines in 1 file covered. (100.0%)

2408 existing lines in 53 files now uncovered.

5980 of 8388 relevant lines covered (71.29%)

0.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/jcache/src/main/java/com/github/benmanes/caffeine/jcache/management/JCacheMXBean.java

/*
 * Copyright 2015 Ben Manes. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.github.benmanes.caffeine.jcache.management;

import static java.util.Objects.requireNonNull;

import javax.cache.Cache;
import javax.cache.configuration.CompleteConfiguration;
import javax.cache.management.CacheMXBean;

/**
 * The Caffeine JCache management bean.
 *
 * @author ben.manes@gmail.com (Ben Manes)
 */
@SuppressWarnings("IdentifierName")
public final class JCacheMXBean implements CacheMXBean {
  private final Cache<?, ?> cache;

  public JCacheMXBean(Cache<?, ?> cache) {
    this.cache = requireNonNull(cache);
  }

  @Override
  public String getKeyType() {
    return configuration().getKeyType().getName();
  }

  @Override
  public String getValueType() {
    return configuration().getValueType().getName();
  }

  @Override
  public boolean isReadThrough() {
    return configuration().isReadThrough();
  }

  @Override
  public boolean isWriteThrough() {
    return configuration().isWriteThrough();
  }

  @Override
  public boolean isStoreByValue() {
    return configuration().isStoreByValue();
  }

  @Override
  public boolean isStatisticsEnabled() {
    return configuration().isStatisticsEnabled();
  }

  @Override
  public boolean isManagementEnabled() {
    return configuration().isManagementEnabled();
  }

  @SuppressWarnings("unchecked")
  private CompleteConfiguration<?, ?> configuration() {
    return cache.getConfiguration(CompleteConfiguration.class);
  }
}

1	/*
2	* Copyright 2015 Ben Manes. All Rights Reserved.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.github.benmanes.caffeine.jcache.management;
17
18	import static java.util.Objects.requireNonNull;
19
20	import javax.cache.Cache;
21	import javax.cache.configuration.CompleteConfiguration;
22	import javax.cache.management.CacheMXBean;
23
24	/**
25	* The Caffeine JCache management bean.
26	*
27	* @author ben.manes@gmail.com (Ben Manes)
28	*/
29	@SuppressWarnings("IdentifierName")
30	public final class JCacheMXBean implements CacheMXBean {
31	private final Cache<?, ?> cache;
32
UNCOV 33	public JCacheMXBean(Cache<?, ?> cache) {	×
UNCOV 34	this.cache = requireNonNull(cache);	×
UNCOV 35	}	×
36
37	@Override
38	public String getKeyType() {
UNCOV 39	return configuration().getKeyType().getName();	×
40	}
41
42	@Override
43	public String getValueType() {
UNCOV 44	return configuration().getValueType().getName();	×
45	}
46
47	@Override
48	public boolean isReadThrough() {
UNCOV 49	return configuration().isReadThrough();	×
50	}
51
52	@Override
53	public boolean isWriteThrough() {
UNCOV 54	return configuration().isWriteThrough();	×
55	}
56
57	@Override
58	public boolean isStoreByValue() {
UNCOV 59	return configuration().isStoreByValue();	×
60	}
61
62	@Override
63	public boolean isStatisticsEnabled() {
UNCOV 64	return configuration().isStatisticsEnabled();	×
65	}
66
67	@Override
68	public boolean isManagementEnabled() {
UNCOV 69	return configuration().isManagementEnabled();	×
70	}
71
72	@SuppressWarnings("unchecked")
73	private CompleteConfiguration<?, ?> configuration() {
UNCOV 74	return cache.getConfiguration(CompleteConfiguration.class);	×
75	}
76	}

ben-manes / caffeine / #5612

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous