#5612

Committed 11 Jul 2026 03:47PM UTC coverage: 71.292% (-28.7%) from 100.0%

Build # #5612

Build Type

push

github

Committed by

ben-manes

Commit Message

Preserve timestamps on a raced same-instance refresh

The automatic refreshIfNeeded path checked for an equal-value reload
before the ABA/ownership check and returned without preserving the
timestamps, so a reload completing after a concurrent put(k,
sameInstance) did a full update — shifting the entry's expiration
forward by the reload's in-flight duration and stomping the write.
Mirror the explicit-refresh fix: check ownership first. An owned
reload installs the value (refreshing metadata even for a same
instance), while a raced reload preserves the write's timestamps and
only notifies REPLACED when the value differs.

Coverage Stats

2957 of 4134 branches covered (71.53%)

3 of 3 new or added lines in 1 file covered. (100.0%)

2408 existing lines in 53 files now uncovered.

5980 of 8388 relevant lines covered (71.29%)

0.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/jcache/src/main/java/com/github/benmanes/caffeine/jcache/integration/DisabledCacheWriter.java

/*
 * Copyright 2015 Ben Manes. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.github.benmanes.caffeine.jcache.integration;

import java.util.Collection;

import javax.cache.Cache;
import javax.cache.integration.CacheWriter;

/**
 * A cache writer that does nothing.
 *
 * @author ben.manes@gmail.com (Ben Manes)
 */
public enum DisabledCacheWriter implements CacheWriter<Object, Object> {
  INSTANCE;

  /**
   * Returns a disabled cache writer.
   *
   * @param <K> the type of key
   * @param <V> the type of value
   * @return a cache writer that performs no operation
   */
  @SuppressWarnings("unchecked")
  public static <K, V> CacheWriter<K, V> get() {
    return (CacheWriter<K, V>) INSTANCE;
  }

  @Override
  public void write(Cache.Entry<?, ?> entry) {}

  @Override
  public void writeAll(Collection<Cache.Entry<?, ?>> entries) {}

  @Override
  public void delete(Object key) {}

  @Override
  public void deleteAll(Collection<?> keys) {}
}

1	/*
2	* Copyright 2015 Ben Manes. All Rights Reserved.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.github.benmanes.caffeine.jcache.integration;
17
18	import java.util.Collection;
19
20	import javax.cache.Cache;
21	import javax.cache.integration.CacheWriter;
22
23	/**
24	* A cache writer that does nothing.
25	*
26	* @author ben.manes@gmail.com (Ben Manes)
27	*/
UNCOV 28	public enum DisabledCacheWriter implements CacheWriter<Object, Object> {	×
UNCOV 29	INSTANCE;	×
30
31	/**
32	* Returns a disabled cache writer.
33	*
34	* @param <K> the type of key
35	* @param <V> the type of value
36	* @return a cache writer that performs no operation
37	*/
38	@SuppressWarnings("unchecked")
39	public static <K, V> CacheWriter<K, V> get() {
UNCOV 40	return (CacheWriter<K, V>) INSTANCE;	×
41	}
42
43	@Override
UNCOV 44	public void write(Cache.Entry<?, ?> entry) {}	×
45
46	@Override
UNCOV 47	public void writeAll(Collection<Cache.Entry<?, ?>> entries) {}	×
48
49	@Override
UNCOV 50	public void delete(Object key) {}	×
51
52	@Override
UNCOV 53	public void deleteAll(Collection<?> keys) {}	×
54	}

ben-manes / caffeine / #5612

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous