#5612

Committed 11 Jul 2026 03:47PM UTC coverage: 71.292% (-28.7%) from 100.0%

Build # #5612

Build Type

push

github

Committed by

ben-manes

Commit Message

Preserve timestamps on a raced same-instance refresh

The automatic refreshIfNeeded path checked for an equal-value reload
before the ABA/ownership check and returned without preserving the
timestamps, so a reload completing after a concurrent put(k,
sameInstance) did a full update — shifting the entry's expiration
forward by the reload's in-flight duration and stomping the write.
Mirror the explicit-refresh fix: check ownership first. An owned
reload installs the value (refreshing metadata even for a same
instance), while a raced reload preserves the write's timestamps and
only notifies REPLACED when the value differs.

Coverage Stats

2957 of 4134 branches covered (71.53%)

3 of 3 new or added lines in 1 file covered. (100.0%)

2408 existing lines in 53 files now uncovered.

5980 of 8388 relevant lines covered (71.29%)

0.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/jcache/src/main/java/com/github/benmanes/caffeine/jcache/event/Registration.java

/*
 * Copyright 2015 Ben Manes. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.github.benmanes.caffeine.jcache.event;

import static java.util.Objects.requireNonNull;

import javax.cache.configuration.CacheEntryListenerConfiguration;
import javax.cache.configuration.MutableCacheEntryListenerConfiguration;
import javax.cache.event.CacheEntryEventFilter;
import javax.cache.event.CacheEntryListener;

import org.jspecify.annotations.Nullable;

/**
 * The registration of a {@link CacheEntryListener} for event dispatching.
 *
 * @author ben.manes@gmail.com (Ben Manes)
 */
@SuppressWarnings("ClassEscapesDefinedScope")
public final class Registration<K, V> {
  private final CacheEntryListenerConfiguration<K, V> configuration;
  private final EventTypeAwareListener<K, V> listener;
  private final CacheEntryEventFilter<K, V> filter;

  public Registration(CacheEntryListenerConfiguration<K, V> configuration,
      CacheEntryEventFilter<K, V> filter, EventTypeAwareListener<K, V> listener) {
    this.configuration = new MutableCacheEntryListenerConfiguration<>(configuration);
    this.listener = requireNonNull(listener);
    this.filter = requireNonNull(filter);
  }

  /** Returns the configuration. */
  public CacheEntryListenerConfiguration<K, V> getConfiguration() {
    return configuration;
  }

  /** Returns the registered listener. */
  public EventTypeAwareListener<K, V> getCacheEntryListener() {
    return listener;
  }

  /** Returns the registered filter. */
  public CacheEntryEventFilter<K, V> getCacheEntryFilter() {
    return filter;
  }

  /** See {@link CacheEntryListenerConfiguration#isSynchronous()}. */
  public boolean isSynchronous() {
    return configuration.isSynchronous();
  }

  @Override
  public boolean equals(@Nullable Object o) {
    if (o == this) {
      return true;
    } else if (!(o instanceof Registration)) {
      return false;
    }
    var other = (Registration<?, ?>) o;
    return configuration.equals(other.configuration);
  }

  @Override
  public int hashCode() {
    return configuration.hashCode();
  }
}

1	/*
2	* Copyright 2015 Ben Manes. All Rights Reserved.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.github.benmanes.caffeine.jcache.event;
17
18	import static java.util.Objects.requireNonNull;
19
20	import javax.cache.configuration.CacheEntryListenerConfiguration;
21	import javax.cache.configuration.MutableCacheEntryListenerConfiguration;
22	import javax.cache.event.CacheEntryEventFilter;
23	import javax.cache.event.CacheEntryListener;
24
25	import org.jspecify.annotations.Nullable;
26
27	/**
28	* The registration of a {@link CacheEntryListener} for event dispatching.
29	*
30	* @author ben.manes@gmail.com (Ben Manes)
31	*/
32	@SuppressWarnings("ClassEscapesDefinedScope")
33	public final class Registration<K, V> {
34	private final CacheEntryListenerConfiguration<K, V> configuration;
35	private final EventTypeAwareListener<K, V> listener;
36	private final CacheEntryEventFilter<K, V> filter;
37
38	public Registration(CacheEntryListenerConfiguration<K, V> configuration,
UNCOV 39	CacheEntryEventFilter<K, V> filter, EventTypeAwareListener<K, V> listener) {	×
UNCOV 40	this.configuration = new MutableCacheEntryListenerConfiguration<>(configuration);	×
UNCOV 41	this.listener = requireNonNull(listener);	×
UNCOV 42	this.filter = requireNonNull(filter);	×
UNCOV 43	}	×
44
45	/** Returns the configuration. */
46	public CacheEntryListenerConfiguration<K, V> getConfiguration() {
UNCOV 47	return configuration;	×
48	}
49
50	/** Returns the registered listener. */
51	public EventTypeAwareListener<K, V> getCacheEntryListener() {
UNCOV 52	return listener;	×
53	}
54
55	/** Returns the registered filter. */
56	public CacheEntryEventFilter<K, V> getCacheEntryFilter() {
UNCOV 57	return filter;	×
58	}
59
60	/** See {@link CacheEntryListenerConfiguration#isSynchronous()}. */
61	public boolean isSynchronous() {
UNCOV 62	return configuration.isSynchronous();	×
63	}
64
65	@Override
66	public boolean equals(@Nullable Object o) {
UNCOV 67	if (o == this) {	×
UNCOV 68	return true;	×
UNCOV 69	} else if (!(o instanceof Registration)) {	×
UNCOV 70	return false;	×
71	}
UNCOV 72	var other = (Registration<?, ?>) o;	×
UNCOV 73	return configuration.equals(other.configuration);	×
74	}
75
76	@Override
77	public int hashCode() {
UNCOV 78	return configuration.hashCode();	×
79	}
80	}

ben-manes / caffeine / #5612

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous