#5612

Committed 11 Jul 2026 03:47PM UTC coverage: 71.292% (-28.7%) from 100.0%

Build # #5612

Build Type

push

github

Committed by

ben-manes

Commit Message

Preserve timestamps on a raced same-instance refresh

The automatic refreshIfNeeded path checked for an equal-value reload
before the ABA/ownership check and returned without preserving the
timestamps, so a reload completing after a concurrent put(k,
sameInstance) did a full update — shifting the entry's expiration
forward by the reload's in-flight duration and stomping the write.
Mirror the explicit-refresh fix: check ownership first. An owned
reload installs the value (refreshing metadata even for a same
instance), while a raced reload preserves the write's timestamps and
only notifies REPLACED when the value differs.

Coverage Stats

2957 of 4134 branches covered (71.53%)

3 of 3 new or added lines in 1 file covered. (100.0%)

2408 existing lines in 53 files now uncovered.

5980 of 8388 relevant lines covered (71.29%)

0.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/jcache/src/main/java/com/github/benmanes/caffeine/jcache/event/JCacheEvictionListener.java

/*
 * Copyright 2015 Ben Manes. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.github.benmanes.caffeine.jcache.event;

import static java.util.Objects.requireNonNull;

import javax.cache.Cache;

import org.jspecify.annotations.Nullable;

import com.github.benmanes.caffeine.cache.RemovalCause;
import com.github.benmanes.caffeine.cache.RemovalListener;
import com.github.benmanes.caffeine.jcache.Expirable;
import com.github.benmanes.caffeine.jcache.management.JCacheStatisticsMXBean;

/**
 * A listener that provides an adapter to publish events in the order of the actions being performed
 * on a key.
 *
 * @author ben.manes@gmail.com (Ben Manes)
 */
public final class JCacheEvictionListener<K, V> implements RemovalListener<K, Expirable<V>> {
  private final JCacheStatisticsMXBean statistics;
  private final EventDispatcher<K, V> dispatcher;

  private @Nullable Cache<K, V> cache;

  public JCacheEvictionListener(EventDispatcher<K, V> dispatcher,
      JCacheStatisticsMXBean statistics) {
    this.dispatcher = requireNonNull(dispatcher);
    this.statistics = requireNonNull(statistics);
  }

  /**
   * Sets the cache instance that was created with this listener.
   *
   * @param cache the cache that uses this loader
   */
  public void setCache(Cache<K, V> cache) {
    this.cache = requireNonNull(cache);
  }

  @Override
  public void onRemoval(@Nullable K key, @Nullable Expirable<V> expirable, RemovalCause cause) {
    requireNonNull(key);
    requireNonNull(cache);
    requireNonNull(expirable);
    V value = expirable.get();
    if (cause == RemovalCause.EXPIRED) {
      dispatcher.publishExpiredQuietly(cache, key, value);
    } else {
      dispatcher.publishRemovedQuietly(cache, key, value);
    }
    statistics.recordEvictions(1L);
  }
}

1	/*
2	* Copyright 2015 Ben Manes. All Rights Reserved.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.github.benmanes.caffeine.jcache.event;
17
18	import static java.util.Objects.requireNonNull;
19
20	import javax.cache.Cache;
21
22	import org.jspecify.annotations.Nullable;
23
24	import com.github.benmanes.caffeine.cache.RemovalCause;
25	import com.github.benmanes.caffeine.cache.RemovalListener;
26	import com.github.benmanes.caffeine.jcache.Expirable;
27	import com.github.benmanes.caffeine.jcache.management.JCacheStatisticsMXBean;
28
29	/**
30	* A listener that provides an adapter to publish events in the order of the actions being performed
31	* on a key.
32	*
33	* @author ben.manes@gmail.com (Ben Manes)
34	*/
35	public final class JCacheEvictionListener<K, V> implements RemovalListener<K, Expirable<V>> {
36	private final JCacheStatisticsMXBean statistics;
37	private final EventDispatcher<K, V> dispatcher;
38
39	private @Nullable Cache<K, V> cache;
40
41	public JCacheEvictionListener(EventDispatcher<K, V> dispatcher,
UNCOV 42	JCacheStatisticsMXBean statistics) {	×
UNCOV 43	this.dispatcher = requireNonNull(dispatcher);	×
UNCOV 44	this.statistics = requireNonNull(statistics);	×
UNCOV 45	}	×
46
47	/**
48	* Sets the cache instance that was created with this listener.
49	*
50	* @param cache the cache that uses this loader
51	*/
52	public void setCache(Cache<K, V> cache) {
UNCOV 53	this.cache = requireNonNull(cache);	×
UNCOV 54	}	×
55
56	@Override
57	public void onRemoval(@Nullable K key, @Nullable Expirable<V> expirable, RemovalCause cause) {
UNCOV 58	requireNonNull(key);	×
UNCOV 59	requireNonNull(cache);	×
UNCOV 60	requireNonNull(expirable);	×
UNCOV 61	V value = expirable.get();	×
UNCOV 62	if (cause == RemovalCause.EXPIRED) {	×
UNCOV 63	dispatcher.publishExpiredQuietly(cache, key, value);	×
64	} else {
UNCOV 65	dispatcher.publishRemovedQuietly(cache, key, value);	×
66	}
UNCOV 67	statistics.recordEvictions(1L);	×
UNCOV 68	}	×
69	}

ben-manes / caffeine / #5612

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous