#5612

Committed 11 Jul 2026 03:47PM UTC coverage: 71.292% (-28.7%) from 100.0%

Build # #5612

Build Type

push

github

Committed by

ben-manes

Commit Message

Preserve timestamps on a raced same-instance refresh

The automatic refreshIfNeeded path checked for an equal-value reload
before the ABA/ownership check and returned without preserving the
timestamps, so a reload completing after a concurrent put(k,
sameInstance) did a full update — shifting the entry's expiration
forward by the reload's in-flight duration and stomping the write.
Mirror the explicit-refresh fix: check ownership first. An owned
reload installs the value (refreshing metadata even for a same
instance), while a raced reload preserves the write's timestamps and
only notifies REPLACED when the value differs.

Coverage Stats

2957 of 4134 branches covered (71.53%)

3 of 3 new or added lines in 1 file covered. (100.0%)

2408 existing lines in 53 files now uncovered.

5980 of 8388 relevant lines covered (71.29%)

0.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/jcache/src/main/java/com/github/benmanes/caffeine/jcache/configuration/CaffeineConfiguration.java

/*
 * Copyright 2015 Ben Manes. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.github.benmanes.caffeine.jcache.configuration;

import static java.util.Objects.requireNonNull;

import java.util.Iterator;
import java.util.Objects;
import java.util.Optional;
import java.util.OptionalLong;
import java.util.Spliterator;
import java.util.concurrent.Executor;
import java.util.concurrent.ForkJoinPool;

import javax.cache.configuration.CacheEntryListenerConfiguration;
import javax.cache.configuration.CompleteConfiguration;
import javax.cache.configuration.Factory;
import javax.cache.configuration.MutableConfiguration;
import javax.cache.expiry.ExpiryPolicy;
import javax.cache.integration.CacheLoader;
import javax.cache.integration.CacheWriter;

import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

import com.github.benmanes.caffeine.cache.Expiry;
import com.github.benmanes.caffeine.cache.Scheduler;
import com.github.benmanes.caffeine.cache.Ticker;
import com.github.benmanes.caffeine.cache.Weigher;
import com.github.benmanes.caffeine.jcache.copy.Copier;
import com.github.benmanes.caffeine.jcache.copy.JavaSerializationCopier;
import com.google.errorprone.annotations.CanIgnoreReturnValue;

/**
 * A JCache configuration with Caffeine specific settings.
 * <p>
 * The initial settings disable <code>store by value</code> so that entries are not copied when
 * crossing the {@link javax.cache.Cache} API boundary. If enabled and the {@link Copier} is not
 * explicitly set, then the {@link JavaSerializationCopier} will be used. This differs from
 * {@link MutableConfiguration} which enables <code>store by value</code> at construction.
 *
 * @author ben.manes@gmail.com (Ben Manes)
 */
@NullMarked
public final class CaffeineConfiguration<K, V> implements CompleteConfiguration<K, V> {
  private static final Factory<Scheduler> DISABLED_SCHEDULER = Scheduler::disabledScheduler;
  private static final Factory<Copier> JAVA_COPIER = JavaSerializationCopier::new;
  private static final Factory<Executor> COMMON_POOL = ForkJoinPool::commonPool;
  private static final Factory<Ticker> SYSTEM_TICKER = Ticker::systemTicker;
  private static final long serialVersionUID = 1L;

  private final MutableConfiguration<K, V> delegate;
  private final boolean readOnly;

  private @Nullable Factory<Weigher<K, V>> weigherFactory;
  private @Nullable Factory<Expiry<K, V>> expiryFactory;

  private Factory<Scheduler> schedulerFactory;
  private Factory<Executor> executorFactory;
  private Factory<Copier> copierFactory;
  private Factory<Ticker> tickerFactory;

  private @Nullable Long refreshAfterWriteNanos;
  private @Nullable Long expireAfterAccessNanos;
  private @Nullable Long expireAfterWriteNanos;
  private @Nullable Long maximumWeight;
  private @Nullable Long maximumSize;
  private boolean nativeStatistics;

  public CaffeineConfiguration() {
    delegate = new MutableConfiguration<>();
    delegate.setStoreByValue(false);
    schedulerFactory = DISABLED_SCHEDULER;
    tickerFactory = SYSTEM_TICKER;
    executorFactory = COMMON_POOL;
    copierFactory = JAVA_COPIER;
    readOnly = false;
  }

  /** Returns a modifiable copy of the configuration. */
  public CaffeineConfiguration(CompleteConfiguration<K, V> configuration) {
    this(configuration, /* readOnly= */ false);
  }

  private CaffeineConfiguration(CompleteConfiguration<K, V> configuration, boolean readOnly) {
    delegate = new MutableConfiguration<>(configuration);
    if (configuration instanceof CaffeineConfiguration<?, ?>) {
      var config = (CaffeineConfiguration<K, V>) configuration;
      refreshAfterWriteNanos = config.refreshAfterWriteNanos;
      expireAfterAccessNanos = config.expireAfterAccessNanos;
      expireAfterWriteNanos = config.expireAfterWriteNanos;
      nativeStatistics = config.nativeStatistics;
      schedulerFactory = config.schedulerFactory;
      executorFactory = config.executorFactory;
      expiryFactory = config.expiryFactory;
      copierFactory = config.copierFactory;
      tickerFactory = config.tickerFactory;
      weigherFactory = config.weigherFactory;
      maximumWeight = config.maximumWeight;
      maximumSize = config.maximumSize;
    } else {
      schedulerFactory = DISABLED_SCHEDULER;
      tickerFactory = SYSTEM_TICKER;
      executorFactory = COMMON_POOL;
      copierFactory = JAVA_COPIER;
    }
    this.readOnly = readOnly;
  }

  /** Returns an unmodifiable copy of this configuration. */
  public CaffeineConfiguration<K, V> immutableCopy() {
    return new CaffeineConfiguration<>(this, /* readOnly= */ true);
  }

  private void checkIfReadOnly() {
    if (readOnly) {
      throw new UnsupportedOperationException();
    }
  }

  @Override
  public Class<K> getKeyType() {
    return delegate.getKeyType();
  }

  @Override
  public Class<V> getValueType() {
    return delegate.getValueType();
  }

  /** See {@link MutableConfiguration#setTypes}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setTypes(Class<K> keyType, Class<V> valueType) {
    checkIfReadOnly();
    delegate.setTypes(keyType, valueType);
    return this;
  }

  @Override
  public Iterable<CacheEntryListenerConfiguration<K, V>> getCacheEntryListenerConfigurations() {
    return new UnmodifiableIterable<>(delegate.getCacheEntryListenerConfigurations());
  }

  /** See {@link MutableConfiguration#addCacheEntryListenerConfiguration}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> addCacheEntryListenerConfiguration(
      CacheEntryListenerConfiguration<K, V> cacheEntryListenerConfiguration) {
    checkIfReadOnly();
    delegate.addCacheEntryListenerConfiguration(cacheEntryListenerConfiguration);
    return this;
  }

  /** See {@link MutableConfiguration#removeCacheEntryListenerConfiguration}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> removeCacheEntryListenerConfiguration(
      CacheEntryListenerConfiguration<K, V> cacheEntryListenerConfiguration) {
    checkIfReadOnly();
    delegate.removeCacheEntryListenerConfiguration(cacheEntryListenerConfiguration);
    return this;
  }

  @Override
  public @Nullable Factory<CacheLoader<K, V>> getCacheLoaderFactory() {
    return delegate.getCacheLoaderFactory();
  }

  /** See {@link MutableConfiguration#setCacheLoaderFactory}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setCacheLoaderFactory(
      @Nullable Factory<? extends CacheLoader<K, V>> factory) {
    checkIfReadOnly();
    delegate.setCacheLoaderFactory(factory);
    return this;
  }

  @Override
  public @Nullable Factory<CacheWriter<? super K, ? super V>> getCacheWriterFactory() {
    return delegate.getCacheWriterFactory();
  }

  /** Returns a writer created by the configured factory or null if not set. */
  public @Nullable CacheWriter<K , V> getCacheWriter() {
    var factory = delegate.getCacheWriterFactory();
    if (factory != null) {
      @SuppressWarnings("unchecked")
      var writer = (CacheWriter<K, V>) factory.create();
      return writer;
    }
    return null;
  }

  /** Returns if the cache writer factory is specified. */
  public boolean hasCacheWriter() {
    return getCacheWriterFactory() != null;
  }

  /** See {@link MutableConfiguration#setCacheWriterFactory}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setCacheWriterFactory(
      @Nullable Factory<? extends CacheWriter<? super K, ? super V>> factory) {
    checkIfReadOnly();
    delegate.setCacheWriterFactory(factory);
    return this;
  }

  @Override
  public Factory<ExpiryPolicy> getExpiryPolicyFactory() {
    return delegate.getExpiryPolicyFactory();
  }

  /** See {@link MutableConfiguration#setExpiryPolicyFactory}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setExpiryPolicyFactory(
      @Nullable Factory<? extends ExpiryPolicy> factory) {
    checkIfReadOnly();
    delegate.setExpiryPolicyFactory(factory);
    return this;
  }

  @Override
  public boolean isReadThrough() {
    return delegate.isReadThrough();
  }

  /** See {@link MutableConfiguration#setReadThrough}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setReadThrough(boolean isReadThrough) {
    checkIfReadOnly();
    delegate.setReadThrough(isReadThrough);
    return this;
  }

  @Override
  public boolean isWriteThrough() {
    return delegate.isWriteThrough();
  }

  /** See {@link MutableConfiguration#setWriteThrough}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setWriteThrough(boolean isWriteThrough) {
    checkIfReadOnly();
    delegate.setWriteThrough(isWriteThrough);
    return this;
  }

  @Override
  public boolean isStoreByValue() {
    return delegate.isStoreByValue();
  }

  /** See {@link MutableConfiguration#setStoreByValue}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setStoreByValue(boolean isStoreByValue) {
    checkIfReadOnly();
    delegate.setStoreByValue(isStoreByValue);
    return this;
  }

  /**
   * Checks whether native statistics collection is enabled in this cache.
   * <p>
   * The default value is <code>false</code>.
   *
   * @return true if native statistics collection is enabled
   */
  public boolean isNativeStatisticsEnabled() {
    return nativeStatistics;
  }

  /**
   * Sets whether native statistics gathering is enabled on a cache.
   *
   * @param enabled true to enable native statistics, false to disable.
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setNativeStatisticsEnabled(boolean enabled) {
    checkIfReadOnly();
    this.nativeStatistics = enabled;
    return this;
  }

  @Override
  public boolean isStatisticsEnabled() {
    return delegate.isStatisticsEnabled();
  }

  /** See {@link MutableConfiguration#setStatisticsEnabled}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setStatisticsEnabled(boolean enabled) {
    checkIfReadOnly();
    delegate.setStatisticsEnabled(enabled);
    return this;
  }

  /** See {@link CompleteConfiguration#isManagementEnabled}. */
  @Override
  public boolean isManagementEnabled() {
    return delegate.isManagementEnabled();
  }

  /** See {@link MutableConfiguration#setManagementEnabled}. */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setManagementEnabled(boolean enabled) {
    checkIfReadOnly();
    delegate.setManagementEnabled(enabled);
    return this;
  }

  /**
   * Returns the {@link Factory} for the {@link Copier} to be used for the cache.
   *
   * @return the {@link Factory} for the {@link Copier}
   */
  public Factory<Copier> getCopierFactory() {
    return copierFactory;
  }

  /**
   * Set the {@link Factory} for the {@link Copier}.
   *
   * @param factory the {@link Copier} {@link Factory}
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setCopierFactory(Factory<Copier> factory) {
    checkIfReadOnly();
    copierFactory = requireNonNull(factory);
    return this;
  }

  /**
   * Returns the {@link Factory} for the {@link Scheduler} to be used for the cache.
   *
   * @return the {@link Factory} for the {@link Scheduler}
   */
  public Factory<Scheduler> getSchedulerFactory() {
    return schedulerFactory;
  }

  /**
   * Set the {@link Factory} for the {@link Scheduler}.
   *
   * @param factory the {@link Scheduler} {@link Factory}
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setSchedulerFactory(Factory<Scheduler> factory) {
    checkIfReadOnly();
    schedulerFactory = requireNonNull(factory);
    return this;
  }

  /**
   * Returns the {@link Factory} for the {@link Ticker} to be used for the cache.
   *
   * @return the {@link Factory} for the {@link Ticker}
   */
  public Factory<Ticker> getTickerFactory() {
    return tickerFactory;
  }

  /**
   * Set the {@link Factory} for the {@link Ticker}.
   *
   * @param factory the {@link Ticker} {@link Factory}
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setTickerFactory(Factory<Ticker> factory) {
    checkIfReadOnly();
    tickerFactory = requireNonNull(factory);
    return this;
  }

  /**
   * Returns the {@link Factory} for the {@link Executor} to be used for the cache.
   *
   * @return the {@link Factory} for the {@link Executor}
   */
  public Factory<Executor> getExecutorFactory() {
    return executorFactory;
  }

  /**
   * Set the {@link Factory} for the {@link Executor}.
   *
   * @param factory the {@link Executor} {@link Factory}
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  public CaffeineConfiguration<K, V> setExecutorFactory(Factory<Executor> factory) {
    checkIfReadOnly();
    executorFactory = requireNonNull(factory);
    return this;
  }

  /**
   * Returns the refresh after write in nanoseconds.
   *
   * @return the duration in nanoseconds
   */
  public OptionalLong getRefreshAfterWrite() {
    return (refreshAfterWriteNanos == null)
        ? OptionalLong.empty()
        : OptionalLong.of(refreshAfterWriteNanos);
  }

  /**
   * Set the refresh after write in nanoseconds.
   *
   * @param refreshAfterWriteNanos the duration in nanoseconds
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  @SuppressWarnings("OptionalUsedAsFieldOrParameterType")
  public CaffeineConfiguration<K, V> setRefreshAfterWrite(OptionalLong refreshAfterWriteNanos) {
    checkIfReadOnly();
    this.refreshAfterWriteNanos = refreshAfterWriteNanos.isPresent()
        ? refreshAfterWriteNanos.getAsLong()
        : null;
    return this;
  }

  /**
   * Returns the expire after write in nanoseconds.
   *
   * @return the duration in nanoseconds
   */
  public OptionalLong getExpireAfterWrite() {
    return (expireAfterWriteNanos == null)
        ? OptionalLong.empty()
        : OptionalLong.of(expireAfterWriteNanos);
  }

  /**
   * Set the expire after write in nanoseconds.
   *
   * @param expireAfterWriteNanos the duration in nanoseconds
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  @SuppressWarnings("OptionalUsedAsFieldOrParameterType")
  public CaffeineConfiguration<K, V> setExpireAfterWrite(OptionalLong expireAfterWriteNanos) {
    checkIfReadOnly();
    this.expireAfterWriteNanos = expireAfterWriteNanos.isPresent()
        ? expireAfterWriteNanos.getAsLong()
        : null;
    return this;
  }

  /**
   * Returns the expire after access in nanoseconds.
   *
   * @return the duration in nanoseconds
   */
  public OptionalLong getExpireAfterAccess() {
    return (expireAfterAccessNanos == null)
        ? OptionalLong.empty()
        : OptionalLong.of(expireAfterAccessNanos);
  }

  /**
   * Set the expire after write in nanoseconds.
   *
   * @param expireAfterAccessNanos the duration in nanoseconds
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  @SuppressWarnings("OptionalUsedAsFieldOrParameterType")
  public CaffeineConfiguration<K, V> setExpireAfterAccess(OptionalLong expireAfterAccessNanos) {
    checkIfReadOnly();
    this.expireAfterAccessNanos = expireAfterAccessNanos.isPresent()
        ? expireAfterAccessNanos.getAsLong()
        : null;
    return this;
  }

  /**
   * Returns the {@link Factory} for the {@link Expiry} to be used for the cache.
   *
   * @return the {@link Factory} for the {@link Expiry}
   */
  public Optional<Factory<Expiry<K, V>>> getExpiryFactory() {
    return Optional.ofNullable(expiryFactory);
  }

  /**
   * Set the {@link Factory} for the {@link Expiry}.
   *
   * @param factory the {@link Expiry} {@link Factory}
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  @SuppressWarnings({"OptionalUsedAsFieldOrParameterType", "unchecked"})
  public CaffeineConfiguration<K, V> setExpiryFactory(
      Optional<Factory<? extends Expiry<K, V>>> factory) {
    checkIfReadOnly();
    expiryFactory = (Factory<Expiry<K, V>>) factory.orElse(null);
    return this;
  }

  /**
   * Returns the maximum size to be used for the cache.
   *
   * @return the maximum size
   */
  public OptionalLong getMaximumSize() {
    return (maximumSize == null)
        ? OptionalLong.empty()
        : OptionalLong.of(maximumSize);
  }

  /**
   * Set the maximum size.
   *
   * @param maximumSize the maximum size
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  @SuppressWarnings("OptionalUsedAsFieldOrParameterType")
  public CaffeineConfiguration<K, V> setMaximumSize(OptionalLong maximumSize) {
    checkIfReadOnly();
    this.maximumSize = maximumSize.isPresent()
        ? maximumSize.getAsLong()
        : null;
    return this;
  }

  /**
   * Returns the maximum weight to be used for the cache.
   *
   * @return the maximum weight
   */
  public OptionalLong getMaximumWeight() {
    return (maximumWeight == null)
        ? OptionalLong.empty()
        : OptionalLong.of(maximumWeight);
  }

  /**
   * Set the maximum weight.
   *
   * @param maximumWeight the maximum weighted size
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  @SuppressWarnings("OptionalUsedAsFieldOrParameterType")
  public CaffeineConfiguration<K, V> setMaximumWeight(OptionalLong maximumWeight) {
    checkIfReadOnly();
    this.maximumWeight = maximumWeight.isPresent()
        ? maximumWeight.getAsLong()
        : null;
    return this;
  }

  /**
   * Returns the {@link Factory} for the {@link Weigher} to be used for the cache.
   *
   * @return the {@link Factory} for the {@link Weigher}
   */
  public Optional<Factory<Weigher<K, V>>> getWeigherFactory() {
    return Optional.ofNullable(weigherFactory);
  }

  /**
   * Set the {@link Factory} for the {@link Weigher}.
   *
   * @param factory the {@link Weigher} {@link Factory}
   * @return the {@link CaffeineConfiguration} to permit fluent-style method calls
   */
  @CanIgnoreReturnValue
  @SuppressWarnings({"OptionalUsedAsFieldOrParameterType", "unchecked"})
  public CaffeineConfiguration<K, V> setWeigherFactory(
      Optional<Factory<? extends Weigher<K, V>>> factory) {
    checkIfReadOnly();
    weigherFactory = (Factory<Weigher<K, V>>) factory.orElse(null);
    return this;
  }

  @Override
  public boolean equals(@Nullable Object o) {
    if (o == this) {
      return true;
    } else if (!(o instanceof CaffeineConfiguration<?, ?>)) {
      return false;
    }
    var config = (CaffeineConfiguration<?, ?>) o;
    return (nativeStatistics == config.nativeStatistics)
        && Objects.equals(refreshAfterWriteNanos, config.refreshAfterWriteNanos)
        && Objects.equals(expireAfterAccessNanos, config.expireAfterAccessNanos)
        && Objects.equals(expireAfterWriteNanos, config.expireAfterWriteNanos)
        && Objects.equals(schedulerFactory, config.schedulerFactory)
        && Objects.equals(executorFactory, config.executorFactory)
        && Objects.equals(weigherFactory, config.weigherFactory)
        && Objects.equals(copierFactory, config.copierFactory)
        && Objects.equals(expiryFactory, config.expiryFactory)
        && Objects.equals(maximumWeight, config.maximumWeight)
        && Objects.equals(tickerFactory, config.tickerFactory)
        && Objects.equals(maximumSize, config.maximumSize)
        && delegate.equals(config.delegate);
  }

  @Override
  public int hashCode() {
    return Objects.hash(nativeStatistics, refreshAfterWriteNanos, expireAfterAccessNanos,
        expireAfterWriteNanos, schedulerFactory, executorFactory, weigherFactory, expiryFactory,
        copierFactory, maximumWeight, tickerFactory, maximumSize, delegate);
  }

  private static final class UnmodifiableIterable<E> implements Iterable<E> {
    private final Iterable<E> delegate;

    private UnmodifiableIterable(Iterable<E> delegate) {
      this.delegate = delegate;
    }
    @Override public Iterator<E> iterator() {
      var iterator = delegate.iterator();
      return new Iterator<>() {
        @Override public boolean hasNext() {
          return iterator.hasNext();
        }
        @Override public E next() {
          return iterator.next();
        }
      };
    }
    @Override public Spliterator<E> spliterator() {
      return delegate.spliterator();
    }
    @Override public String toString() {
      return delegate.toString();
    }
  }
}

ben-manes / caffeine / #5612

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous