#5612

Committed 11 Jul 2026 03:47PM UTC coverage: 71.292% (-28.7%) from 100.0%

Build # #5612

Build Type

push

github

Committed by

ben-manes

Commit Message

Preserve timestamps on a raced same-instance refresh

The automatic refreshIfNeeded path checked for an equal-value reload
before the ABA/ownership check and returned without preserving the
timestamps, so a reload completing after a concurrent put(k,
sameInstance) did a full update — shifting the entry's expiration
forward by the reload's in-flight duration and stomping the write.
Mirror the explicit-refresh fix: check ownership first. An owned
reload installs the value (refreshing metadata even for a same
instance), while a raced reload preserves the write's timestamps and
only notifies REPLACED when the value differs.

Coverage Stats

2957 of 4134 branches covered (71.53%)

3 of 3 new or added lines in 1 file covered. (100.0%)

2408 existing lines in 53 files now uncovered.

5980 of 8388 relevant lines covered (71.29%)

0.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/jcache/src/main/java/com/github/benmanes/caffeine/jcache/Expirable.java

/*
 * Copyright 2015 Ben Manes. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.github.benmanes.caffeine.jcache;

import static java.util.Locale.US;
import static java.util.Objects.requireNonNull;

/**
 * A value with an expiration timestamp.
 *
 * @author ben.manes@gmail.com (Ben Manes)
 */
public final class Expirable<V> {
  private final V value;

  private volatile long expireTimeMillis;

  public Expirable(V value, long expireTimeMillis) {
    this.value = requireNonNull(value);
    this.expireTimeMillis = expireTimeMillis;
  }

  /** Returns the value. */
  public V get() {
    return value;
  }

  /** Returns the time, in milliseconds, when the value will expire. */
  public long getExpireTimeMillis() {
    return expireTimeMillis;
  }

  /** Specifies the time, in milliseconds, when the value will expire. */
  public void setExpireTimeMillis(long expireTimeMillis) {
    this.expireTimeMillis = expireTimeMillis;
  }

  /** Returns if the value has expired and is eligible for eviction. */
  public boolean hasExpired(long currentTimeMillis) {
    return (currentTimeMillis - expireTimeMillis) >= 0;
  }

  /** Returns if the value will never expire. */
  public boolean isEternal() {
    return (expireTimeMillis == Long.MAX_VALUE);
  }

  @Override
  public String toString() {
    return String.format(US, "%s{value=%s, expireTimeMillis=%,d}",
        getClass().getSimpleName(), value, expireTimeMillis);
  }
}

1	/*
2	* Copyright 2015 Ben Manes. All Rights Reserved.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.github.benmanes.caffeine.jcache;
17
18	import static java.util.Locale.US;
19	import static java.util.Objects.requireNonNull;
20
21	/**
22	* A value with an expiration timestamp.
23	*
24	* @author ben.manes@gmail.com (Ben Manes)
25	*/
26	public final class Expirable<V> {
27	private final V value;
28
29	private volatile long expireTimeMillis;
30
UNCOV 31	public Expirable(V value, long expireTimeMillis) {	×
UNCOV 32	this.value = requireNonNull(value);	×
UNCOV 33	this.expireTimeMillis = expireTimeMillis;	×
UNCOV 34	}	×
35
36	/** Returns the value. */
37	public V get() {
UNCOV 38	return value;	×
39	}
40
41	/** Returns the time, in milliseconds, when the value will expire. */
42	public long getExpireTimeMillis() {
UNCOV 43	return expireTimeMillis;	×
44	}
45
46	/** Specifies the time, in milliseconds, when the value will expire. */
47	public void setExpireTimeMillis(long expireTimeMillis) {
UNCOV 48	this.expireTimeMillis = expireTimeMillis;	×
UNCOV 49	}	×
50
51	/** Returns if the value has expired and is eligible for eviction. */
52	public boolean hasExpired(long currentTimeMillis) {
UNCOV 53	return (currentTimeMillis - expireTimeMillis) >= 0;	×
54	}
55
56	/** Returns if the value will never expire. */
57	public boolean isEternal() {
UNCOV 58	return (expireTimeMillis == Long.MAX_VALUE);	×
59	}
60
61	@Override
62	public String toString() {
UNCOV 63	return String.format(US, "%s{value=%s, expireTimeMillis=%,d}",	×
UNCOV 64	getClass().getSimpleName(), value, expireTimeMillis);	×
65	}
66	}

ben-manes / caffeine / #5612

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous