#5612

Committed 11 Jul 2026 03:47PM UTC coverage: 71.292% (-28.7%) from 100.0%

Build # #5612

Build Type

push

github

Committed by

ben-manes

Commit Message

Preserve timestamps on a raced same-instance refresh

The automatic refreshIfNeeded path checked for an equal-value reload
before the ABA/ownership check and returned without preserving the
timestamps, so a reload completing after a concurrent put(k,
sameInstance) did a full update — shifting the entry's expiration
forward by the reload's in-flight duration and stomping the write.
Mirror the explicit-refresh fix: check ownership first. An owned
reload installs the value (refreshing metadata even for a same
instance), while a raced reload preserves the write's timestamps and
only notifies REPLACED when the value differs.

Coverage Stats

2957 of 4134 branches covered (71.53%)

3 of 3 new or added lines in 1 file covered. (100.0%)

2408 existing lines in 53 files now uncovered.

5980 of 8388 relevant lines covered (71.29%)

0.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/jcache/src/main/java/com/github/benmanes/caffeine/jcache/EntryProxy.java

/*
 * Copyright 2015 Ben Manes. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.github.benmanes.caffeine.jcache;

import java.util.AbstractMap.SimpleImmutableEntry;

import javax.cache.Cache;

/**
 * An implementation of JSR-107 {@link javax.cache.Cache.Entry}.
 *
 * @author ben.manes@gmail.com (Ben Manes)
 */
public final class EntryProxy<K, V> extends SimpleImmutableEntry<K, V>
    implements Cache.Entry<K, V> {
  private static final long serialVersionUID = 1L;

  public EntryProxy(K key, V value) {
    super(key, value);
  }

  @Override
  public <T> T unwrap(Class<T> clazz) {
    if (!clazz.isInstance(this)) {
      throw new IllegalArgumentException("Class " + clazz + " is unknown to this implementation");
    }
    @SuppressWarnings("unchecked")
    var castedEntry = (T) this;
    return castedEntry;
  }
}

1	/*
2	* Copyright 2015 Ben Manes. All Rights Reserved.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.github.benmanes.caffeine.jcache;
17
18	import java.util.AbstractMap.SimpleImmutableEntry;
19
20	import javax.cache.Cache;
21
22	/**
23	* An implementation of JSR-107 {@link javax.cache.Cache.Entry}.
24	*
25	* @author ben.manes@gmail.com (Ben Manes)
26	*/
27	public final class EntryProxy<K, V> extends SimpleImmutableEntry<K, V>
28	implements Cache.Entry<K, V> {
29	private static final long serialVersionUID = 1L;
30
31	public EntryProxy(K key, V value) {
UNCOV 32	super(key, value);	×
UNCOV 33	}	×
34
35	@Override
36	public <T> T unwrap(Class<T> clazz) {
UNCOV 37	if (!clazz.isInstance(this)) {	×
UNCOV 38	throw new IllegalArgumentException("Class " + clazz + " is unknown to this implementation");	×
39	}
40	@SuppressWarnings("unchecked")
UNCOV 41	var castedEntry = (T) this;	×
UNCOV 42	return castedEntry;	×
43	}
44	}

ben-manes / caffeine / #5612

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous