#5612

Committed 11 Jul 2026 03:47PM UTC coverage: 71.292% (-28.7%) from 100.0%

Build # #5612

Build Type

push

github

Committed by

ben-manes

Commit Message

Preserve timestamps on a raced same-instance refresh

The automatic refreshIfNeeded path checked for an equal-value reload
before the ABA/ownership check and returned without preserving the
timestamps, so a reload completing after a concurrent put(k,
sameInstance) did a full update — shifting the entry's expiration
forward by the reload's in-flight duration and stomping the write.
Mirror the explicit-refresh fix: check ownership first. An owned
reload installs the value (refreshing metadata even for a same
instance), while a raced reload preserves the write's timestamps and
only notifies REPLACED when the value differs.

Coverage Stats

2957 of 4134 branches covered (71.53%)

3 of 3 new or added lines in 1 file covered. (100.0%)

2408 existing lines in 53 files now uncovered.

5980 of 8388 relevant lines covered (71.29%)

0.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.33

/caffeine/src/main/java/com/github/benmanes/caffeine/cache/WriteThroughEntry.java

/*
 * Copyright 2015 Ben Manes. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.github.benmanes.caffeine.cache;

import static java.util.Objects.requireNonNull;

import java.util.AbstractMap.SimpleEntry;
import java.util.concurrent.ConcurrentMap;

/**
 * An entry that allows updates to write through to the backing map.
 *
 * @author ben.manes@gmail.com (Ben Manes)
 */
final class WriteThroughEntry<K, V> extends SimpleEntry<K, V> {
  private static final long serialVersionUID = 1;

  @SuppressWarnings("serial")
  private final ConcurrentMap<K, V> map;

  WriteThroughEntry(ConcurrentMap<K, V> map, K key, V value) {
    super(key, value);
    this.map = requireNonNull(map);
  }

  @Override
  public V setValue(V value) {
    // See ConcurrentHashMap: "Sets our entry's value and writes through to the map. The value to
    // return is somewhat arbitrary here. Since we do not necessarily track asynchronous changes,
    // the most recent "previous" value could be different from what we return (or could even have
    // been removed, in which case the put will re-establish). We do not and cannot guarantee more."
    map.put(getKey(), value);
    return super.setValue(value);
  }

  Object writeReplace() {
    return new SimpleEntry<>(this);
  }
}

1	/*
2	* Copyright 2015 Ben Manes. All Rights Reserved.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.github.benmanes.caffeine.cache;
17
18	import static java.util.Objects.requireNonNull;
19
20	import java.util.AbstractMap.SimpleEntry;
21	import java.util.concurrent.ConcurrentMap;
22
23	/**
24	* An entry that allows updates to write through to the backing map.
25	*
26	* @author ben.manes@gmail.com (Ben Manes)
27	*/
28	final class WriteThroughEntry<K, V> extends SimpleEntry<K, V> {
29	private static final long serialVersionUID = 1;
30
31	@SuppressWarnings("serial")
32	private final ConcurrentMap<K, V> map;
33
34	WriteThroughEntry(ConcurrentMap<K, V> map, K key, V value) {
35	super(key, value);	1✔
36	this.map = requireNonNull(map);	1✔
37	}	1✔
38
39	@Override
40	public V setValue(V value) {
41	// See ConcurrentHashMap: "Sets our entry's value and writes through to the map. The value to
42	// return is somewhat arbitrary here. Since we do not necessarily track asynchronous changes,
43	// the most recent "previous" value could be different from what we return (or could even have
44	// been removed, in which case the put will re-establish). We do not and cannot guarantee more."
45	map.put(getKey(), value);	1✔
46	return super.setValue(value);	1✔
47	}
48
49	Object writeReplace() {
UNCOV 50	return new SimpleEntry<>(this);	×
51	}
52	}

ben-manes / caffeine / #5612

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous