IQSS / dataverse / #29557

Pull #12435

github

Address review findings: earlier signing-secret gate, byte-exact stripping, docs and tests #12435

- Gate the four signed-URL POST /api/access endpoints before any guestbook-response
  or MakeDataCount side effects, via requireSigningSecretForSignedUrl(); keep a silent
  backstop in returnSignedUrl for the callers that discard its response. Generic error
  message for these guest-reachable endpoints, actionable detail in the server log.
- stripReservedParameters: preserve empty query segments and fragments byte-for-byte
  (split("&", -1), fragment split off before query surgery).
- Log a warning and hide the permissions-history CSV link when no signing secret is set.
- Tests: unsigned-fallback path, signUrlWithApiKey/isSigningSecretConfigured, strip edge cases.
- Docs: signing-secret now documented as required in native-api.rst; fix env var name
  DATAVERSE_API_SIGNING_SECRET in config.rst; conditional-signing notes in external-tools.rst
  and globus-api.rst; release note lists all gated endpoints and the real error message.

33 of 72 new or added lines in 8 files covered. (45.83%)

23835 of 95223 relevant lines covered (25.03%)

0.25 hits per line