28793654629

Committed 06 Jul 2026 01:05PM UTC coverage: 48.793% (-30.2%) from 79.041%

Build # 28793654629

Build Type

Pull #1206

github

Committed by

web-flow

Commit Message

Merge 056d0b5f9 into d54b900bf

Pull Request Pull Request #1206: fix: leak of request into pools

Coverage Stats

3210 of 7101 branches covered (45.2%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

3858 existing lines in 164 files now uncovered.

6208 of 12201 relevant lines covered (50.88%)

63.5 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

17.65

/src/http/routes/render/renderAuthenticatedImage.ts

import { getTenantConfig } from '@internal/database'
import { ImageRenderer } from '@storage/renderer'
import { FastifyInstance } from 'fastify'
import { FromSchema } from 'json-schema-to-ts'
import { getConfig } from '../../../config'
import { transformationOptionsSchema } from '../../schemas/transformations'
import { ROUTE_OPERATIONS } from '../operations'

const { storageS3Bucket, isMultitenant } = getConfig()

const renderAuthenticatedImageParamsSchema = {
  type: 'object',
  properties: {
    bucketName: { type: 'string', examples: ['avatars'] },
    '*': { type: 'string', examples: ['folder/cat.png'] },
  },
  required: ['bucketName', '*'],
} as const

const renderImageQuerySchema = {
  type: 'object',
  properties: {
    ...transformationOptionsSchema,
    download: { type: 'string', examples: ['filename.png'] },
  },
} as const

interface renderImageRequestInterface {
  Params: FromSchema<typeof renderAuthenticatedImageParamsSchema>
  Querystring: FromSchema<typeof renderImageQuerySchema>
}

export default async function routes(fastify: FastifyInstance) {
  const summary = 'Render an authenticated image with the given transformations'
  fastify.get<renderImageRequestInterface>(
    '/authenticated/:bucketName/*',
    {
      schema: {
        params: renderAuthenticatedImageParamsSchema,
        querystring: renderImageQuerySchema,
        summary,
        response: { '4xx': { $ref: 'errorSchema#', description: 'Error response' } },
        tags: ['transformation'],
      },
      config: {
        operation: { type: ROUTE_OPERATIONS.RENDER_AUTH_IMAGE },
      },
    },
    async (request, response) => {
      const { download } = request.query
      const { bucketName } = request.params
      const objectName = request.params['*']

      const obj = await request.storage
        .from(bucketName)
        .findObject(objectName, 'id,version,metadata')

      const s3Key = request.storage.location.getKeyLocation({
        tenantId: request.tenantId,
        bucketId: bucketName,
        objectName,
      })

      const renderer = request.storage.renderer('image') as ImageRenderer

      if (isMultitenant) {
        const tenantConfig = await getTenantConfig(request.tenantId)
        renderer.setLimits({
          maxResolution: tenantConfig.features.imageTransformation.maxResolution,
        })
      }

      return renderer.setTransformations(request.query).render(request, response, {
        bucket: storageS3Bucket,
        key: s3Key,
        version: obj.version,
        download,
        xRobotsTag: obj.metadata?.['xRobotsTag'] as string | undefined,
        signal: request.signals.disconnect.signal,
      })
    }
  )
}

1	import { getTenantConfig } from '@internal/database'
2	import { ImageRenderer } from '@storage/renderer'
3	import { FastifyInstance } from 'fastify'
4	import { FromSchema } from 'json-schema-to-ts'
5	import { getConfig } from '../../../config'
6	import { transformationOptionsSchema } from '../../schemas/transformations'
7	import { ROUTE_OPERATIONS } from '../operations'
8
9	const { storageS3Bucket, isMultitenant } = getConfig()	2✔
10
11	const renderAuthenticatedImageParamsSchema = {	2✔
12	type: 'object',
13	properties: {
14	bucketName: { type: 'string', examples: ['avatars'] },
15	'*': { type: 'string', examples: ['folder/cat.png'] },
16	},
17	required: ['bucketName', '*'],
18	} as const
19
20	const renderImageQuerySchema = {	2✔
21	type: 'object',
22	properties: {
23	...transformationOptionsSchema,
24	download: { type: 'string', examples: ['filename.png'] },
25	},
26	} as const
27
28	interface renderImageRequestInterface {
29	Params: FromSchema<typeof renderAuthenticatedImageParamsSchema>
30	Querystring: FromSchema<typeof renderImageQuerySchema>
31	}
32
33	export default async function routes(fastify: FastifyInstance) {
UNCOV 34	const summary = 'Render an authenticated image with the given transformations'	×
UNCOV 35	fastify.get<renderImageRequestInterface>(	×
36	'/authenticated/:bucketName/*',
37	{
38	schema: {
39	params: renderAuthenticatedImageParamsSchema,
40	querystring: renderImageQuerySchema,
41	summary,
42	response: { '4xx': { $ref: 'errorSchema#', description: 'Error response' } },
43	tags: ['transformation'],
44	},
45	config: {
46	operation: { type: ROUTE_OPERATIONS.RENDER_AUTH_IMAGE },
47	},
48	},
49	async (request, response) => {
UNCOV 50	const { download } = request.query	×
UNCOV 51	const { bucketName } = request.params	×
UNCOV 52	const objectName = request.params['*']	×
53
UNCOV 54	const obj = await request.storage	×
55	.from(bucketName)
56	.findObject(objectName, 'id,version,metadata')
57
UNCOV 58	const s3Key = request.storage.location.getKeyLocation({	×
59	tenantId: request.tenantId,
60	bucketId: bucketName,
61	objectName,
62	})
63
UNCOV 64	const renderer = request.storage.renderer('image') as ImageRenderer	×
65
UNCOV 66	if (isMultitenant) {	×
67	const tenantConfig = await getTenantConfig(request.tenantId)	×
68	renderer.setLimits({	×
69	maxResolution: tenantConfig.features.imageTransformation.maxResolution,
70	})
71	}
72
UNCOV 73	return renderer.setTransformations(request.query).render(request, response, {	×
74	bucket: storageS3Bucket,
75	key: s3Key,
76	version: obj.version,
77	download,
78	xRobotsTag: obj.metadata?.['xRobotsTag'] as string \| undefined,
79	signal: request.signals.disconnect.signal,
80	})
81	}
82	)
83	}

supabase / storage / 28793654629

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous