• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

AfterShip / clickhouse-sql-parser / 28775814529

06 Jul 2026 07:42AM UTC coverage: 54.333% (+1.5%) from 52.881%
28775814529

Pull #281

github

git-hulk
Fail ParseStmts when a recorded lexer error survives to the success path

Review follow-up: lastError was only consulted through wrapError, which
only runs when the parser itself fails. A failed lex can leave the
offset advanced - consumeIdent skips the opening backtick before
discovering the quote is unclosed - so with `SELECT 1 `bad` the
retained input re-lexes cleanly to EOF, parsing reaches the success
path, and the recorded error was silently dropped.

- ParseStmts now fails if lexerState still carries an error when
  parsing reaches end of input.
- peekToken restores the saved state on the error path too, so a failed
  lookahead neither leaves the offset advanced nor records an error for
  input the parser has not actually reached.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Pull Request #281: Surface lexer errors instead of misreporting them as EOF

30 of 37 new or added lines in 3 files covered. (81.08%)

2912 existing lines in 10 files now uncovered.

8953 of 16478 relevant lines covered (54.33%)

3025.41 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

69.87
/parser/parser_table.go


Source Not Available

STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc