dunglas / mercure / 28740716882

Pull #1269

github

refactor(matchers): review cleanups

Lower-severity items from the topic-matcher review:

- Reject a publish "data" field that is not valid UTF-8 (400), matching the
  protocol's UTF-8 requirement that ParseForm does not enforce.
- Iterate subscribe query parameters in sorted order so the resulting matcher
  order (observable in subscription IDs, the subscription API and span
  attributes) is deterministic instead of depending on Go map iteration order.
- Drop the dead maxQueryTopics constant (the subscribe path is capped by
  maxMatcherCount) and point the test at the enforced limit.
- Remove the unreachable deprecatedMatcherTypeName case in matcherTypeFromParam
  (the internal type is not addressable from the wire; default already rejects
  it).

627 of 737 new or added lines in 22 files covered. (85.07%)

2319 of 2787 relevant lines covered (83.21%)

88.01 hits per line