ronso0 / mixxx / 28721027172

push

github

Library scanner: clear fs_deleted only for files still on disk

Resolves mixxxdj/mixxx#13533 (track stuck in "Missing Tracks" forever
when the directory hash is unchanged) without resurrecting tracks whose
files were genuinely removed before the saved hash was last updated.

Instead, plumb the actual list of currently-present audio files from
RecursiveScanDirectoryTask through the directoryUnchanged signal into
ScannerGlobal::addVerifiedTrack, and let cleanUpScan run the existing
markTrackLocationsAsVerified over the unified set. That call already
clears needs_verification AND fs_deleted, but only for the exact
locations passed in — so a row whose file is no longer in the directory
keeps fs_deleted=1 and is later confirmed by verifyRemainingTracks.

markTracksInDirectoriesAsVerified loses its only caller and is removed.

The trackdao test now asserts both directions: a present file gets
recovered, and a sibling whose file is missing keeps fs_deleted=1.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

0 of 9 new or added lines in 2 files covered. (0.0%)

32054 of 104145 relevant lines covered (30.78%)

46420.28 hits per line