28496595030

Committed 01 Jul 2026 05:50AM UTC coverage: 50.727% (-1.6%) from 52.278%

Build # 28496595030

Build Type

Pull #83

github

Committed by

web-flow

Commit Message

Merge 8f1ff4df5 into 2efed6649

Pull Request Pull Request #83: refactor and improve code QoL

Coverage Stats

31872 of 80367 branches covered (39.66%)

Branch coverage included in aggregate %.

770 of 1591 new or added lines in 85 files covered. (48.4%)

5070 existing lines in 182 files now uncovered.

32742 of 47009 relevant lines covered (69.65%)

9887.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.67

/src/dftracer/utils/python/arrow_helpers.cpp

#include <dftracer/utils/core/common/config.h>
#ifdef DFTRACER_UTILS_ENABLE_ARROW

#define PY_SSIZE_T_CLEAN
#include <Python.h>
#include <dftracer/utils/python/arrow_helpers.h>
#include <dftracer/utils/python/trace_reader_iterator.h>

namespace dftracer::utils::python {

PyObject *wrap_arrow_result(ArrowExportResult result) {
    if (!result.valid()) {
        PyErr_SetString(PyExc_RuntimeError,
                        "Cannot wrap invalid ArrowExportResult");
        return NULL;
    }

    auto *cap = (ArrowBatchCapsuleObject *)ArrowBatchCapsuleType.tp_alloc(
        &ArrowBatchCapsuleType, 0);
    if (!cap) return NULL;

    cap->result = new ArrowExportResult(std::move(result));
    return (PyObject *)cap;
}

PyObject *wrap_arrow_table(PyObject *batch_list) {
    if (!batch_list) {
        PyErr_SetString(PyExc_RuntimeError, "batch_list is NULL");
        return NULL;
    }

    PyObject *mod = PyImport_ImportModule("dftracer.utils.arrow");
    if (!mod) {
        Py_DECREF(batch_list);
        return NULL;
    }

    PyObject *cls = PyObject_GetAttrString(mod, "ArrowTable");
    Py_DECREF(mod);
    if (!cls) {
        Py_DECREF(batch_list);
        return NULL;
    }

    PyObject *table = PyObject_CallFunctionObjArgs(cls, batch_list, NULL);
    Py_DECREF(cls);
    Py_DECREF(batch_list);
    return table;
}

PyObject *wrap_arrow_stream_table(PyObject *stream_obj) {
    // dftracer.utils.arrow.ArrowTable accepts either a batch list or a stream
    // object, so wrapping is identical for both.
    return wrap_arrow_table(stream_obj);
}

PyObject *arrow_result_to_table(ArrowExportResult result) {
    PyObject *capsule = wrap_arrow_result(std::move(result));
    if (!capsule) return NULL;

    PyObject *list = PyList_New(1);
    if (!list) {
        Py_DECREF(capsule);
        return NULL;
    }
    PyList_SET_ITEM(list, 0, capsule);  // steals ref

    return wrap_arrow_table(list);
}

}  // namespace dftracer::utils::python

#endif  // DFTRACER_UTILS_ENABLE_ARROW

1	#include <dftracer/utils/core/common/config.h>
2	#ifdef DFTRACER_UTILS_ENABLE_ARROW
3
4	#define PY_SSIZE_T_CLEAN
5	#include <Python.h>
6	#include <dftracer/utils/python/arrow_helpers.h>
7	#include <dftracer/utils/python/trace_reader_iterator.h>
8
9	namespace dftracer::utils::python {
10
11	PyObject *wrap_arrow_result(ArrowExportResult result) {	22✔
12	if (!result.valid()) {	22!
13	PyErr_SetString(PyExc_RuntimeError,	×
14	"Cannot wrap invalid ArrowExportResult");
15	return NULL;	×
16	}
17
18	auto cap = (ArrowBatchCapsuleObject )ArrowBatchCapsuleType.tp_alloc(	22✔
19	&ArrowBatchCapsuleType, 0);
20	if (!cap) return NULL;	22!
21
22	cap->result = new ArrowExportResult(std::move(result));	22!
23	return (PyObject *)cap;	22✔
24	}	22✔
25
26	PyObject wrap_arrow_table(PyObject batch_list) {	34✔
27	if (!batch_list) {	34!
28	PyErr_SetString(PyExc_RuntimeError, "batch_list is NULL");	×
29	return NULL;	×
30	}
31
32	PyObject *mod = PyImport_ImportModule("dftracer.utils.arrow");	34✔
33	if (!mod) {	34!
UNCOV 34	Py_DECREF(batch_list);	×
35	return NULL;	×
36	}
37
38	PyObject *cls = PyObject_GetAttrString(mod, "ArrowTable");	34✔
39	Py_DECREF(mod);	34✔
40	if (!cls) {	34!
UNCOV 41	Py_DECREF(batch_list);	×
42	return NULL;	×
43	}
44
45	PyObject *table = PyObject_CallFunctionObjArgs(cls, batch_list, NULL);	34✔
46	Py_DECREF(cls);	34✔
47	Py_DECREF(batch_list);	34✔
48	return table;	34✔
49	}	34✔
50
51	PyObject wrap_arrow_stream_table(PyObject stream_obj) {	13✔
52	// dftracer.utils.arrow.ArrowTable accepts either a batch list or a stream
53	// object, so wrapping is identical for both.
54	return wrap_arrow_table(stream_obj);	13✔
55	}
56
57	PyObject *arrow_result_to_table(ArrowExportResult result) {	6✔
58	PyObject *capsule = wrap_arrow_result(std::move(result));	6!
59	if (!capsule) return NULL;	6!
60
61	PyObject *list = PyList_New(1);	6✔
62	if (!list) {	6!
UNCOV 63	Py_DECREF(capsule);	×
64	return NULL;	×
65	}
66	PyList_SET_ITEM(list, 0, capsule); // steals ref	6✔
67
68	return wrap_arrow_table(list);	6✔
69	}	6✔
70
71	} // namespace dftracer::utils::python
72
73	#endif // DFTRACER_UTILS_ENABLE_ARROW

llnl / dftracer-utils / 28496595030

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous