bstoll / kne / 28410823909

Pull #10

github

Fix golangci-lint violations and format YAML/Go files

This change aggregates several fixes to address golangci-lint violations, format code files, and update deprecated APIs.

Key changes:
- Refactored Go code to address golangci-lint violations and update deprecated APIs:
  - Replaced deprecated `k8s.io/utils/pointer` with `k8s.io/utils/ptr`.
  - Replaced deprecated `grpc.DialContext` with `grpc.NewClient`.
  - Replaced deprecated `remotecommand.Stream` with `StreamWithContext`.
  - Handled or logged errors from `CloseSend`, `ReadFrom`, `BindPFlags`, etc.
  - Standardized error message capitalization (removed leading capitals and ending punctuation).
  - Simplified boolean expressions and struct field accesses.
  - Addressed various linter-raised spelling errors and style comments (e.g. in `topo/node/sonic` and other nodes).
  - Renamed internal fields for better readability (e.g., `wantInitCtr` to `wantInitContainer` and `wantSonicCtr` to `wantSonicContainer` in `sonic.go`).
- Ran `go fmt` across all Go source files.
- Formatted YAML files and manifests according to linter configurations (added `---` document start markers, fixed spacing/indentation in cloudbuild config, deployments, and various topological templates).
- Updated configuration files for Super-Linter:
  - Added codespell configuration file `.github/linters/.codespellrc`.
  - Adjusted `.golangci.yml` linter settings.
  - Added rules to `.github/linters/.checkov.yaml`, `.github/linters/.gitleaks.toml`, etc.
  - Added dependency cooldown periods in `.github/dependabot.yml`.
- Ran Prettier and resolved various Markdown lint errors (non-descriptive link text, spacing around code blocks, spelling errors).

62 of 134 new or added lines in 26 files covered. (46.27%)

5186 of 12353 relevant lines covered (41.98%)

0.48 hits per line